Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/334
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/334#issuecomment-156597223
You don't need to squash. I will use a patch to commit it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/334#issuecomment-156279652
Fixed. Should I squash the commits?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/334#discussion_r44732404
--- Diff: proxy/http2/HTTP2.cc ---
@@ -448,7 +448,7 @@ convert_from_2_to_1_1_header(HTTPHdr *headers)
// Combine Cookie headers ([RFC 7
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/334#discussion_r44732321
--- Diff: proxy/http2/HTTP2.cc ---
@@ -448,7 +448,7 @@ convert_from_2_to_1_1_header(HTTPHdr *headers)
// Combine Cookie headers ([RFC 7
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/334#discussion_r44732079
--- Diff: proxy/http2/HTTP2.cc ---
@@ -461,6 +461,15 @@ convert_from_2_to_1_1_header(HTTPHdr *headers)
headers->field_delete(HPACK_VALUE_METH
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/334#discussion_r44731073
--- Diff: proxy/hdrs/MIME.h ---
@@ -765,6 +768,23 @@ MIMEField::name_set(HdrHeap *heap, MIMEHdrImpl *mh,
const char *name, int length
/*
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/334#discussion_r44731109
--- Diff: proxy/hdrs/MIME.h ---
@@ -852,6 +872,23 @@ MIMEField::value_append(HdrHeap *heap, MIMEHdrImpl
*mh, const char *value, int l
mime_fie
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/334
TS-4019: Validate header names and values before passing to FetchSM
https://issues.apache.org/jira/browse/TS-4019
You can merge this pull request into a Git repository by running:
$ git p
