Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/624
@ogoodman would you mind also starting a thread on
dev@trafficserver.apache.org for API review? I can also kick off this
discussion if you'd like.
---
If your project is set up for it,
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/624
@bgaff The new API should go through API review. IMHO it would be best to
make a separate JIRA and pull request for the API changes.
---
If your project is set up for it, you can reply
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/624
also is there a jira ticket for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/624
Hi @ogoodman , I want to get this landed soon can you please just make one
final change which puts it under an experimental/ folder in examples? After
that I'm happy to commit this for yo
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/624#issuecomment-220376297
.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/624#issuecomment-219194912
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/624#issuecomment-219191864
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/624#issuecomment-219190135
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/624#issuecomment-219186487
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/624#issuecomment-218782549
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/624#issuecomment-218525564
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/624#issuecomment-218336364
With the C plugins we've had an experimental directory for plugins that
were fairly new, we should probably consider adding this to a folder under
atscppapi/example
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/624#discussion_r62779359
--- Diff: lib/atscppapi/examples/websocket/WebSocket.cc ---
@@ -0,0 +1,311 @@
+#include "WebSocket.hh"
+
+#include
+#include "ts/ink_base
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/624#discussion_r62779253
--- Diff: lib/atscppapi/examples/websocket/WebSocket.cc ---
@@ -0,0 +1,311 @@
+#include "WebSocket.hh"
+
+#include
+#include "ts/ink_base
Github user ogoodman commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/624#discussion_r62778999
--- Diff: lib/atscppapi/examples/websocket/WebSocket.cc ---
@@ -0,0 +1,246 @@
+#include "WebSocket.hh"
+
+#include
+#include "ts/ink_b
Github user ogoodman commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/624#discussion_r62778854
--- Diff: lib/atscppapi/examples/websocket/WebSocket.cc ---
@@ -0,0 +1,246 @@
+#include "WebSocket.hh"
+
+#include
+#include "ts/ink_b
Github user ogoodman commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/624#discussion_r62778716
--- Diff: lib/atscppapi/examples/websocket/WebSocket.cc ---
@@ -0,0 +1,246 @@
+#include "WebSocket.hh"
+
+#include
+#include "ts/ink_b
Github user ogoodman commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/624#discussion_r62778445
--- Diff: proxy/InkAPI.cc ---
@@ -4858,6 +4858,15 @@ TSHttpTxnInfoIntGet(TSHttpTxn txnp, TSHttpTxnInfoKey
key, TSMgmtInt *value)
return TS_SUCC
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/624#discussion_r62701424
--- Diff: proxy/api/ts/ts.h ---
@@ -2328,6 +2328,7 @@ tsapi TSReturnCode
TSHttpTxnCacheLookupUrlGet(TSHttpTxn txnp, TSMBuffer bufp, TS
tsapi TS
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/624#discussion_r62701032
--- Diff: proxy/InkAPI.cc ---
@@ -4858,6 +4858,15 @@ TSHttpTxnInfoIntGet(TSHttpTxn txnp, TSHttpTxnInfoKey
key, TSMgmtInt *value)
return TS_SUCCESS
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/624#discussion_r62700530
--- Diff: lib/atscppapi/examples/websocket/WebSocket.cc ---
@@ -0,0 +1,246 @@
+#include "WebSocket.hh"
+
+#include
+#include "ts/ink_base
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/624#discussion_r62699616
--- Diff: lib/atscppapi/examples/websocket/WebSocket.cc ---
@@ -0,0 +1,246 @@
+#include "WebSocket.hh"
+
+#include
+#include "ts/ink_base
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/624#discussion_r62699378
--- Diff: lib/atscppapi/examples/websocket/WebSocket.cc ---
@@ -0,0 +1,246 @@
+#include "WebSocket.hh"
+
+#include
+#include "ts/ink_base
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/624#discussion_r62698874
--- Diff: lib/atscppapi/examples/websocket/WebSocket.cc ---
@@ -0,0 +1,246 @@
+#include "WebSocket.hh"
+
+#include
+#include "ts/ink_base
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/624#discussion_r62698746
--- Diff: lib/atscppapi/examples/websocket/WebSocket.cc ---
@@ -0,0 +1,246 @@
+#include "WebSocket.hh"
+
+#include
+#include "ts/ink_base
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/624#discussion_r62698040
--- Diff: lib/atscppapi/examples/websocket/WebSocket.cc ---
@@ -0,0 +1,246 @@
+#include "WebSocket.hh"
+
+#include
+#include "ts/ink_base
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/624#discussion_r62697922
--- Diff: lib/atscppapi/examples/websocket/WebSocket.cc ---
@@ -0,0 +1,246 @@
+#include "WebSocket.hh"
+
+#include
+#include "ts/ink_base
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/624#discussion_r62697756
--- Diff: lib/atscppapi/examples/websocket/WebSocket.cc ---
@@ -0,0 +1,246 @@
+#include "WebSocket.hh"
+
+#include
+#include "ts/ink_base
GitHub user ogoodman opened a pull request:
https://github.com/apache/trafficserver/pull/624
C++ API WebSocket example
There are two commits. The first one adds an API function to determine
whether a transaction is a websocket request and adds code to the
InterceptPlugin to make it
29 matches
Mail list logo
