Github user ogoodman commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/624#discussion_r62778445
  
    --- Diff: proxy/InkAPI.cc ---
    @@ -4858,6 +4858,15 @@ TSHttpTxnInfoIntGet(TSHttpTxn txnp, TSHttpTxnInfoKey 
key, TSMgmtInt *value)
       return TS_SUCCESS;
     }
     
    +bool
    +TSHttpTxnIsWebsocket(TSHttpTxn txnp)
    +{
    +  sdk_assert(sdk_sanity_check_txn(txnp) == TS_SUCCESS);
    +
    +  HttpSM *sm = (HttpSM *)txnp;
    +  return sm->t_state.is_upgrade_request && sm->t_state.upgrade_token_wks 
== MIME_VALUE_WEBSOCKET;
    --- End diff --
    
    I'm not sure why but this doesn't work for detecting an incoming websocket 
connection. Perhaps some of those flags are only set when proxying after the 
origin server has started responding.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to