Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/624#discussion_r62701424
--- Diff: proxy/api/ts/ts.h ---
@@ -2328,6 +2328,7 @@ tsapi TSReturnCode
TSHttpTxnCacheLookupUrlGet(TSHttpTxn txnp, TSMBuffer bufp, TS
tsapi TSReturnCode TSHttpTxnCacheLookupUrlSet(TSHttpTxn txnp, TSMBuffer
bufp, TSMLoc obj);
tsapi TSReturnCode TSHttpTxnPrivateSessionSet(TSHttpTxn txnp, int
private_session);
tsapi int TSHttpTxnBackgroundFillStarted(TSHttpTxn txnp);
+tsapi bool TSHttpTxnIsWebsocket(TSHttpTxn txnp);
--- End diff --
should be using "int" instead of "bool" to be consistent?
also we need an API review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
