Re: [E] Proposal: make utilities declared in Cleanup.h part of TS API

2023-09-05 Thread Walt Karas
Where would we put it? Just copy it into each plugin where it's used? Have each plugin rewrite code to support RAII? On Tue, Sep 5, 2023 at 1:01 PM Chris McFarlen wrote: > I would advocate for a much higher level plugin API in the direction of > Cripts that encapsulates much of the minutia of h

Re: [E] Proposal: make utilities declared in Cleanup.h part of TS API

2023-09-05 Thread Chris McFarlen
I would advocate for a much higher level plugin API in the direction of Cripts that encapsulates much of the minutia of hooking into the transaction lifecycle and reduces the rote boilerplate that exists in current plugins. Hopefully something that will cover the vast majority of use cases with

Re: [E] Proposal: make utilities declared in Cleanup.h part of TS API

2023-09-05 Thread Walt Karas
Would it be possible to propose concrete alternatives? We can't just simply delete Cleanup.h, the xdebug plugin won't compile. On Tue, Sep 5, 2023 at 12:27 PM Chris McFarlen wrote: > I have read through Cleanup.h and its uses and I agree this is not a style > we should promote. This code alrea

Re: [E] Proposal: make utilities declared in Cleanup.h part of TS API

2023-09-05 Thread Chris McFarlen
I have read through Cleanup.h and its uses and I agree this is not a style we should promote. This code already feels like tech debt in that its bridging C and C++ APIs in a bolt-on fashion that I think we will want to deprecate shortly. While certainly RAII and "smart" pointers are important

Re: [E] Proposal: make utilities declared in Cleanup.h part of TS API

2023-09-05 Thread Masakazu Kitajo
I was not talking about the need to use RAII. I just don't think we should promote Cleanup.h. On Tue, Sep 5, 2023 at 7:28 AM Walt Karas wrote: > It seems that some are not convinced of the need to use RAII. I won' t get > into that, it's easy to find writeups advocating for it, which are better

Re: [E] Proposal: make utilities declared in Cleanup.h part of TS API

2023-09-05 Thread Walt Karas
It seems that some are not convinced of the need to use RAII. I won' t get into that, it's easy to find writeups advocating for it, which are better than anything I could write. I have no strong feelings about how things are spelled or abbreviated. On Sat, Sep 2, 2023 at 11:22 PM James Peach wr

Re: [E] Proposal: make utilities declared in Cleanup.h part of TS API

2023-09-02 Thread James Peach
> On 2 Sep 2023, at 3:44 am, Masakazu Kitajo wrote: > >> Its a judgement call, how much to minimize the API. > > Yes, that's why we send API proposals on the dev list. And I don't think > I'm absolutely right. If we, as a community, want to have utilities as TS > API, that's what we should do.