I was not talking about the need to use RAII. I just don't think we should promote Cleanup.h.
On Tue, Sep 5, 2023 at 7:28 AM Walt Karas <wka...@yahooinc.com.invalid> wrote: > It seems that some are not convinced of the need to use RAII. I won' t get > into that, it's easy to find writeups advocating for it, which are better > than anything I could write. > > I have no strong feelings about how things are spelled or abbreviated. > > On Sat, Sep 2, 2023 at 11:22 PM James Peach <jpe...@apache.org> wrote: > > > > > > On 2 Sep 2023, at 3:44 am, Masakazu Kitajo <m4s...@gmail.com> wrote: > > > > > >> Its a judgement call, how much to minimize the API. > > > > > > Yes, that's why we send API proposals on the dev list. And I don't > think > > > I'm absolutely right. If we, as a community, want to have utilities as > TS > > > API, that's what we should do. I'm disappointed that others don't join > > this > > > discussion, but if they don't mind making Cleanup.h TS API, that means > we > > > have many potential maintainers. I guess I could just abide and hope > you > > > and they maintain it. > > > > > > Is providing Cleanup.h as TS API the one and only way? I don't > understand > > > why not promoting Cleanup.h means inevitable resource leak. Plugin > > > developers can take care of it in their own way, right? One could copy > > > Cleanup.h anytime if they want. > > > > It looks like there’s only one internal plugin using this, so it’s not > > self-evidently essential. How about adopting it internally before making > it > > public API? > > > > Also, could we change it to spell `UniqPtr` correctly? > > > > J >
