> > Thanks Pushkar, I'll try that...
> >
> > On Mon, Mar 4, 2019 at 4:44 PM Pushkar Pradhan
> > wrote:
> >
> >> Perhaps compiling with LSAN will help: --enable-lsan enable
> >> stand-alone Leak Sanitizer
> >>
> >>
>
"(,"client-request":)" + collect_headers(buffer,
hdr_loc, TSHttpTxnClientReqBodyBytesGet(txnp));
TSHandleMLocRelease(buffer, TS_NULL_MLOC, hdr_loc);
buffer = nullptr;
}
On Mon, Mar 4, 2019 at 6:06 PM Dk Jack wrote:
> Thanks Pushkar, I'll try that...
>
> On
This change broke the cookie_remap plugin and so I am fixing it.
Should I use the pristine URL to get the HTTP headers or the remapped url
(rri)?
Since now the remapped url is the 'before' url I think they would always
yield identical results.
I am curious what's the recommended way?
On Tue, Feb 1
Perhaps compiling with LSAN will help: --enable-lsan enable
stand-alone Leak Sanitizer
On Mon, Mar 4, 2019 at 4:42 PM Bryan Call wrote:
> Looking at the graphs it looks like your headers and http1client sessions
> are leaking. Have you looked at this example to on how to send back e
Walt,
What is your proposal, is it to run all tests with debug output?
This would require modifying all existing tests. That also brings up
another question, what sections should be enabled?
I.e. http, dns, iocore,
One potential downfall to turning on debugging is that writing to the debug
lo
In my PR https://github.com/apache/trafficserver/pull/4859 against 7.1.x I
see that the clang-format job fails randomly.
Even though I didn't change the code from what's in the master, this job
fails:
https://ci.trafficserver.apache.org/job/clang-format-github/7691/console
Does anyone know why thi
All,
I am aware that the master build is broken and it looks like it's because
of my cookie_remap plugin commit. I am working on reproducing the issue and
fixing it.
Thanks,
pushkar
Hello,
I would like to backport the cookie_remap plugin to 7.1.x.
This should be pretty safe because there is no change to the core.
However, it requires yaml-cpp for parsing the configs and yaml-cpp is
included in ATS 8.x and master, but not in 7.1.x.
I can use an external yaml-cpp installation a
My PR for cookie_remap plugin in 7.1.x is failing because the plugin needs
yaml-cpp and the CI/CD doesn't have a yaml-cpp available.
https://github.com/apache/trafficserver/pull/4859
https://ci.trafficserver.apache.org/job/centos-github/9092/consoleFull
How are things handled when plugins have ext
Please ignore. It was my test above that was failing because of setup
issues.
On Fri, Jan 11, 2019 at 10:34 PM Pushkar Pradhan wrote:
> I got this in my branch, is this a known issue?
> REGRESSION_TEST initialization begun
> REGRESSION TEST ParseX509Fields started
> REGRE
I got this in my branch, is this a known issue?
REGRESSION_TEST initialization begun
REGRESSION TEST ParseX509Fields started
REGRESSION_RESULT ParseX509Fields: PASSED
REGRESSION TEST ParseExpansion started
[sslheaders] : SslHdrParseExpansion: sslheaders: missing '=' in
icserver/commit/d4d4bcd33cf60e5d936107561de5d31389c783dc
>
> -Bryan
>
>
>
> > On Jan 4, 2019, at 5:55 PM, Pushkar Pradhan
> wrote:
> >
> > It seems the API TSHttpTxnSetHttpRetStatus in 7.x was changed to
> > TSHttpTxnStatusSet in 8.x.
> > The underlying code seems to
ion testing.
>
> On Tue, Jan 8, 2019 at 11:15 PM Leif Hedstrom wrote:
> >
> >
> >
> > > On Jan 8, 2019, at 5:34 PM, Pushkar Pradhan
> wrote:
> > >
> > > Miles is right. Here's my output:
> > > [iwonttellyoumyusername@iwonttellyo
url --help' or 'curl --manual' for more information
On Tue, Jan 8, 2019 at 4:19 PM Miles Libbey wrote:
> On Tue, Jan 8, 2019 at 3:45 PM Leif Hedstrom wrote:
> > > On Jan 8, 2019, at 4:06 PM, Pushkar Pradhan
> wrote:
> > >
> > > Even RHEL7 s
e to configure it correctly.
>
> Jason
>
> On Mon, Jan 7, 2019 at 9:39 PM Leif Hedstrom wrote:
>
> >
> >
> > > On Jan 7, 2019, at 5:28 PM, Pushkar Pradhan >
> > wrote:
> > >
> > > Yes I saw that condition later. I think it could be don
it also skipped TLS related tests, I am sure there's another tool
I am missing.
On Mon, Jan 7, 2019 at 7:39 PM Leif Hedstrom wrote:
>
>
> > On Jan 7, 2019, at 5:28 PM, Pushkar Pradhan
> wrote:
> >
> > Yes I saw that condition later. I think it could be done fo
> # need Curl
> Test.SkipUnless(
> Condition.HasProgram("curl", "Curl need to be installed on system
> for this test to work"),
> Condition.HasCurlFeature('http2')
> )
>
> On Mon, Jan 7, 2019 at 4:58 PM Pushkar Pradhan
> wrote:
> >
>
I tried running the autests on the master branch and saw many many failures.
Most of them failed because my RHEL box doesn't have a recent curl that
supports http1.1 option.
The fix was obvious but I got no warning about this, I had to figure this
out.
Would it be reasonable to include and build t
It seems the API TSHttpTxnSetHttpRetStatus in 7.x was changed to
TSHttpTxnStatusSet in 8.x.
The underlying code seems to be the same, only the name has changed.
I am writing a plugin that calls this function and that I want to work in
both 7.x and 8.x codelines.
I can wrap the names in a #iifdef l
Yeah I am curious too, how could it make ATS unstable. It's a pretty
popular library.
Maybe ATS has a mismatch of malloc/free etc.something that is masked by the
free list?
On Tue, Dec 11, 2018 at 3:19 PM Walt Karas wrote:
> I thought jemalloc is used as a drop-in replacement for the standard li
The plugin has dependencies on libyaml and libpcre.
AFAIK TS already depends on these two.
On Thu, Nov 29, 2018 at 10:10 AM Bryan Call wrote:
> Is the plugin going to introduce any new dependencies?
>
> -Bryan
>
>
>
> > On Nov 28, 2018, at 12:06 PM, Pushkar Pradhan
Not yet. I am cleaning up the code for open sourcing.
On Wed, Nov 28, 2018 at 2:29 PM Susan Hinrichs wrote:
> Do you have a PR for this plugin?
>
> On Wed, Nov 28, 2018 at 3:49 PM Pushkar Pradhan >
> wrote:
>
> > Hello,
> > I would like to opensource a plugin
Hello,
I would like to opensource a plugin we are using into 7.1.x branch.
Please let me know if this would be acceptable?
--
pushkar
What is the trafficserver version you are using?
When you said it doesn't work what happens? Is it empty or logging
something else.
Instead of replacing % did you try appending it to the specifier or
replacing some other field?
On Mon, Nov 19, 2018 at 11:27 AM Sevan Gelici wrote:
> Hello,
>
> I
So we would have to explicitly install python 3.5 right?
Would it also work if it were python 3.6 or higher?
If it's strictly python 3.5 I find it a little restrictive.
Many of the tests launch a python script using Command = 'python
tcp_client.py' syntax.
That would continue to pull the correct p
Is your client sending a TLSv1.2 handshake? Maybe it's a lower version or
non TLS.
On Fri, Nov 2, 2018 at 11:41 AM Dk Jack wrote:
> Hi,
> I enabled SSL on my ATS and my ssl requests are failing with handshake
> error. From the logs I can tell that it loaded my cert/key correct. When I
> started
s and probably just an aesthetic
> > issue (gets optimized out).
> > On Fri, Oct 26, 2018 at 5:32 PM Pushkar Pradhan
> wrote:
> > >
> > > Good catch. In Modern Effective C++ Scott Myers talks about a few
> > scenarios when auto doesn't do what the progra
Good catch. In Modern Effective C++ Scott Myers talks about a few scenarios
when auto doesn't do what the programmer intended.
Earlier I was inclined to suggest that we should avoid auto in ATS but I
think it's better to make mistakes and learn.
On Fri, Oct 26, 2018 at 3:21 PM Walt Karas wrote:
good enough to leave a
> > documentation note and mark fixing this as an intern project or
> > something.
> > Writing some off thread logging code and writing a poor man’s multi
> > producer queue sounds like a pretty nice project.
> >
> > Daniel
> >
>
ds, but many more than one per core. The
> purpose(s) of the large number and various types of threads is
> unclear. Our discussion of mutexes quickly turned into blah blah blah
> mumble mumble.
> On Wed, Oct 10, 2018 at 11:38 AM Pushkar Pradhan
> wrote:
> >
> > I
I was going through the code in Diags.cc and I saw that if debug logging is
on, ATS calls vfprintf in the thread that handles the client request.
E.g.
https://github.com/apache/trafficserver/blob/master/src/tscore/Diags.cc#L301
Is this a good idea?
Or is the assumption that if you have turned on d
I think Alan is referring to the below code.
It's a try lock, so if it doesn't succeed it's just rescheduled for later.
void
EThread::process_event(Event *e, int calling_code)
{
ink_assert((!e->in_the_prot_queue && !e->in_the_priority_queue));
MUTEX_TRY_LOCK_FOR(lock, e->mutex, this, e->contin
Alan,
Can you clarify if Monday (Oct 1) is hackday or C++ clinic?
On Fri, Sep 14, 2018 at 12:07 PM Alan Carroll
wrote:
> I have a room at Oath for Monday and Thursday. We'll see about Thursday,
> but I'll be there all day Monday. Ping me for access.
>
> On Fri, Sep 14, 2018 at 1:59 PM Leif Heds
Yes I am interested in attending.
On Thu, Sep 6, 2018 at 8:57 AM John Rushford wrote:
> I've made travel arrangements already and my plane doesn't arrive until
> 1pm. I'll try to get to this as soon as possible.
> thanks
> John
>
> On Thu, Sep 6, 2018 at 9:07 AM Alan Carroll
> wrote:
>
> > I w
Hi Leif,
I usually do one feature/fix per PR but do have multiple commits.
Would it easier if we squash the commits into one and then create the PR?
On Tue, Aug 7, 2018 at 1:42 PM Leif Hedstrom wrote:
> Hi,
>
> There are some serious shortcomings in Github when it comes to PRs with
> multiple co
How about adding:Whether the object was compressed in RAM, If it was from disk,
the number of milliseconds to read the first byte in.But going by the name of
the variable sounds like you don't want to get timings. pushkar
On Tuesday, September 1, 2015 3:43 PM, Sudheer Vinukonda
wrote:
commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #282
commit 7b9f36d78eea80ca0b2018b82e0fcbcbf0b6fbcb
Author: Pushkar Pradhan
Date: 2015-08-17T22:54:05Z
This is the fix for TS-3848.
The values for wait_for_cache are
1. I wanted to limit the scope of this ticket to only detect disk failures in
initialization.2. I haven't verified that individual plugins can override the
proxy.config.http.cache.http but assuming that is true maybe we can allow this
exception since we cannot check run time plugin requirements
Hello,Please review my pull request:TS3848 by pushkarpradhan · Pull Request
#279 · apache/trafficserver
| |
| | | | | | | |
| TS3848 by pushkarpradhan · Pull Request #279 · apache/...This is a proposed
fix for TS-3848. The idea is that if traffic_server fails to read/initialize
o
The TestRegressions environment setup is killing traffic_cop, traffic_manager
and traffic_server so as to start up traffic_server without any monitoring.Now
I need to debug why it just sits there in my environment. pushkar
On Thursday, August 20, 2015 6:08 PM, Pushkar Pradhan
wrote
I am trying to run the regression tests in TSQA but traffic_server just sits
there doing nothing.Here's what I have found so far:The framework launches
traffic_cop which kicks off traffic_manager which kicks off
traffic_server.Meanwhile, the test itself launches traffic_server with args -R
1. I
Hello,I am working on ATS and I have created my own branch for it. I want to
push to the repository (to my branch so that I don't lose my commits on my box)
and later plan to send a pull request.I created an account on github but I am
unable to push to my branch using those credentials (fatal: A
42 matches
Mail list logo
