+1 for concept and rationale
Might be good to survey the common log rotation tools to verify custom
signals are supported.
On Thu, Jan 23, 2020 at 11:16:25AM -0600, Brian Neradt wrote:
>
> Context
> ==
>
> Traffic Server currently implements its own mechanism for rotating its logs
> and cle
> > I changing TSVConnSSLConnectionGet to TSVConnSslConnectionGet. PR
> > #5937 makes this change.
+1
On Tue, Sep 24, 2019 at 02:43:53PM -0700, Bryan Call wrote:
>
> +1 - sounds good!
>
> -Bryan
>
>
> > On Sep 23, 2019, at 8:25 AM, SUSAN HINRICHS wrote:
> >
> > TSVConnSSLConnectionGet is t
’s perspective?
> It feels like it is something that needs to be fixed in the Origin server in
> the first place than add defense on the proxy following the redirects?
>
>
> Thanks,
>
> Sudheer
>
> > On Aug 10, 2019, at 8:27 PM, Derek Dagit wrote:
> >
>
oo specific and custom to be made
> part of the core. Not to mention, the interaction between the existing
> redirect follow and cache isn’t super clean already and this new overload of
> that config seems like it has the potential to make it a lot worse.
>
> Thanks,
>
> Su
I want to port the following PR to the 8.x line, but as it is changing
configs and adding a feature, it should target a minor release.
https://github.com/apache/trafficserver/pull/4145
Earlier I fetched an 8.1.x branch, but now that I have a branch ready
for a pull request it appears that branch
+1
On Fri, May 10, 2019 at 6:53 AM Steven R. Feltner
wrote:
> +1 - I like this idea a lot
>
>
> On 5/9/19, 12:06 PM, "Leif Hedstrom" wrote:
>
> Notice: This email is from an external sender.
>
>
>
> Hi,
>
> As fa Follow-up to previous emails, I’d like to propose that new
> features
ng to use it. That's where I learned about anchors and merging map
structures, and I use those features day-to-day now.
On Fri, Apr 26, 2019 at 2:50 PM Walt Karas
wrote:
> TL;DR love of Satan
>
> On Fri, Apr 26, 2019 at 2:48 PM Derek Dagit wrote:
>
> > I think it should be c
I think it should be consistent.
The first line establishes an indentation width of 2 spaces.
The second line is a list element that itself is a map of one entry, and
your multi-line text is the value for this entry.
Since it is nested, in effect we need to indent twice, and so I think that
is w
> Also, it's already very easy to write code that asserts later on. Trying
scheduling a TSCont that doesn't have a mutex.
A little off-topic: There are already several useful TS API functions that
require a mutex. Currently the plugin author must be diligent in reading
the documentation to learn w
I also favor enforcement even on intercept plugins.
ip_allow is a white-listing function that is often configured to implement
a security policy.
If one wishes to bypass it, then we could make such a thing explicit via
the plugin API.
On the other hand it would be nice of there were big, red, ug
Greetings,
I wanted to let the community know that after this week my responsibilities
at
my employer will be shifting me away from primary work on ATS.
I will be working on completing a few pull requests for changes that we
have in
progress, and if you are waiting on me for reviews, rework, or a
> The assert would be good but I think the docs need a warning that two
AcidPtr instances or two AcidCommitPtr instances should not exist at the
same time in the same thread.
+1 for clarification
On Mon, Sep 17, 2018 at 1:51 PM, Walt Karas wrote:
> The assert would be good but I think the docs
> > Leif, can we make this "overridable" in follow-on work?
> Sure.
#4145 is merged.
Created https://github.com/apache/trafficserver/issues/4252 for the
"overridable" task.
On Mon, Aug 27, 2018 at 2:57 PM, Leif Hedstrom wrote:
>
>
> > On Aug 27
Looks like it was a temporary glitch. Things seem fine now.
On Thu, Sep 6, 2018 at 12:48 PM, Bryan Call wrote:
> There have been 1,224 PRs for the 8.0.0 release, making it one of the
> releases with the greatest number of changes from the Apache Traffic Server
> Community!
>
> This is a time to
Tried to add info for #4145 just now, but I think the wiki server is having
trouble.
On Thu, Sep 6, 2018 at 12:48 PM, Bryan Call wrote:
> There have been 1,224 PRs for the 8.0.0 release, making it one of the
> releases with the greatest number of changes from the Apache Traffic Server
> Communit
Leif, can we make this "overridable" in follow-on work?
This is a bit tricky because of custom parsing.
On Sat, Aug 25, 2018 at 6:21 PM, Leif Hedstrom wrote:
>
>
> > On Aug 24, 2018, at 12:31, Derek Dagit wrote:
> >
> > Sounds good let me take a look.
> &g
Sounds good let me take a look.
On Fri, Aug 24, 2018 at 12:24 PM, Bryan Call wrote:
> I am OK with it. I would add a default tag, so you can specify what
> action to take by default if there is no match (e.g.
> routable:follow,default:reject).
>
> -Bryan
>
>
>
> > On Aug 24, 2018, at 9:16 AM, A
OK I think we can converge on the PR now:
https://github.com/apache/trafficserver/pull/4145#issuecomment-415647049
I expect more iterations.
On Thu, Aug 23, 2018 at 8:52 PM, Derek Dagit wrote:
> Thanks, working on it.
>
> On Thu, Aug 23, 2018 at 6:19 PM, Bryan Call wrote:
&g
Thanks, working on it.
On Thu, Aug 23, 2018 at 6:19 PM, Bryan Call wrote:
> Inline
>
> -Bryan
>
> > On Aug 22, 2018, at 11:37 AM, Derek Dagit
> wrote:
> >
> > Bryan, some clarification questions:
> >
> >
> >> 2. 403
> >
> >
OK let me draft something for the wiki...
On Thu, Aug 23, 2018 at 5:50 PM, Bryan Call wrote:
> Sounds good, want to create one?
>
> -Bryan
>
>
>
> > On Aug 22, 2018, at 11:44 AM, Derek Dagit
> wrote:
> >
> > +1
> >
> > My cheat sheet for
+1
My cheat sheet for these rules is growing lengthy. Would it be a good idea
to publish to the wiki?
On Wed, Aug 22, 2018 at 1:23 PM, Bryan Call wrote:
> +1 - sounds good
>
> -Bryan
>
>
>
> > On Aug 9, 2018, at 4:15 PM, Leif Hedstrom wrote:
> >
> > We have a few commits that have been reverte
ult.
>
> When checking for localhost you should resolve the ip and check to see if
> it matches any of the IPs on the server. That could be a long list if
> there servers has many IP aliases. This still doesn’t block IPs used by
> other servers in the same network.
>
> -Brya
Thanks for clarifying the scope. Good notes.
I do like the idea of having a schema. Hopefully if we enable external
registration we could provide a way for those also to have schemas with
validation.
What makes this more plausible now is the integration of YAML support to
ATS, whereas before we m
I was not at Cork, so I am probably missing a lot of the details.
It seems having true RPC here would greatly expand the possibilities for
management and monitoring.
- What are the current and planned use cases for this RPC?
- What if we want to add authentication/authorization for multi-tenant
Just FYI, IF we went with merge comments then I believe github by default
lets us give the message in the new commit that it creates—It is the PR
title by default I think. With rebase-merge github won't change the commit
message I think, but we could require an Issue # to be in commit comments
befo
> It not only makes it difficult to know what commits are associated with a
PR
> it also makes back porting / cherry-picking PRs from master to an LTS
branch really problematic
Counter-proposal: Use merge commits.
Part of git's design is the element of a commit, whose sha1 ID can be used
to trac
1. Yep
2. I see multiple possible answers as well...
3. ... and the 0,1,2-style config having either default sounds OK.
Regarding 1)2), Could we resolve and then check if the address is a
loopback address?
3) Hmm, not sure about the use of *cast addresses either.
4) The VIP deployment I
+1 for the rename
+1 for adding the two new functions
On Mon, Aug 6, 2018 at 4:41 PM, Alan Carroll <
solidwallofc...@oath.com.invalid> wrote:
> +1
>
> On Mon, Aug 6, 2018 at 4:18 PM Leif Hedstrom wrote:
>
> >
> >
> > > On Aug 6, 2018, at 3:14 PM, Leif Hedstrom wrote:
> > >
> > > We have this AP
ATS can be configured such that when it receives a redirect (3xx) response
from an origin server, it will follow the redirect itself rather than
return the response to the client.
Consider the scenario when the redirect response contains a Location header
field with a destination of localhost.
In
Sounds good.
> 3) Perhaps most importantly, this is not a problem that ATS should solve iMO.
> There are much better systems out there, such as Kafka, Elastic Search,
> Splunk etc., all which solves this problem in a much better way.
Would we offer a recommendation along these lines during whil
Bryan,
Would it be reasonable to update robots.txt on the docs server in
order that documentation for older/unsupported versions of ATS less
prevalent in search engine results?
--
Derek
+1
On Mon, Jun 18, 2018 at 10:09 AM, Alan Carroll <
solidwallofc...@oath.com.invalid> wrote:
> +1
>
> On Mon, Jun 18, 2018 at 10:06 AM, David Calavera >
> wrote:
>
> > I noticed that atscppapi::RegisterGlobalPlugin doesn't return any value.
> > This makes impossible for plugins that use to to kn
Seems fine to me.
Is this going to stay on master only or would we want to bring this change
to any of our existing branches?
(I am thinking back-ports to supported branches could get tricky unless we
make this change there too.)
On Tue, Jun 12, 2018 at 3:27 PM, Leif Hedstrom wrote:
> Hi,
>
>
Some of the non-API code would be helpful to have available to plugins,
like URL parsing. (That's not to say headers for such things ought to be
combined with API headers.)
On Thu, May 24, 2018 at 11:11 AM, Alan Carroll <
solidwallofc...@oath.com.invalid> wrote:
> To paraphrase, I'm extremely ne
+1 for replacing LuaJIT configs with YAML.
On Tue, May 8, 2018 at 3:01 AM, Bryan Call wrote:
> +1
>
> -Bryan
>
>
> > On May 7, 2018, at 12:47 PM, Leif Hedstrom wrote:
> >
> > Hi,
> >
> > I’d like to propose that we eliminate the existing LuaJIT configurations
> with a simple YAML format. This w
+1 to remove it.
On Thu, May 3, 2018 at 10:38 AM, Leif Hedstrom wrote:
> I don’t think this script has a purpose any more, and it’s not maintained.
> Does anyone have any objections to nuking it for ATS v8.0.0 ? Fwiw, this
> script was intended as a replacement for an older C++ version of
> traf
+1 for this
There is probably a lot of context from earlier big-picture technical
discussions that I was missing when I tried to review one of the PRs.
Specific examples of code that would be improved or problems that would be
fixed would be really helpful in deciding if the changes make sense fo
Yes, there is evidently a race between the microserver binding the port and
the
server
actually spinning up.
As far as the API we have to use, I think it would be good to be very
specific
in our naming.
I would replace PortReady with something like CanTcpConnect, because that is
what the code
One reason this could be scary is that should we change any of these
headers going forward, it could mean a backward-incompatible release for
ATS.
In-place upgrades may not be possible for administrators without
recompiling their plugins.
On Tue, Mar 27, 2018 at 5:08 PM, Walt Karas wrote:
> If
If we can put a comment in the file to say as much, I think it would be OK.
I would like to avoid confusion around whether this is sufficient or
required to build independent of these other tools—it would be good to have
something about its status and what it is intended for.
I support making lif
> Or maybe no default to avoid confusion?
Yeah this sounds fine to me too.
On Mon, Mar 19, 2018 at 4:23 PM, Walt Karas wrote:
> Or maybe no default to avoid confusion?
>
> On Mon, Mar 19, 2018 at 4:08 PM, Derek Dagit
> wrote:
> > I think that would be better, because it&
ar 19, 2018 at 4:04 PM, Derek Dagit
> wrote:
> > A continuation's Mutex is also used for certain API functions, like
> > TSHostLookup:
> >
> > https://docs.trafficserver.apache.org/en/latest/
> developer-guide/api/functions/TSHostLookup.en.html
> >
> > But
A continuation's Mutex is also used for certain API functions, like
TSHostLookup:
https://docs.trafficserver.apache.org/en/latest/developer-guide/api/functions/TSHostLookup.en.html
But you do not always need them.
On Mon, Mar 19, 2018 at 3:48 PM, Alan Carroll <
solidwallofc...@oath.com.invalid>
r discussion, I got exasperated trying to
> make sure of this looking through the code with just vi.)
>
> On Mon, Mar 19, 2018 at 10:23 AM, Derek Dagit
> wrote:
> > I might be missing the connection to the proposed Continuation
> constructor
> > behavior with regard to the mute
https://cwiki.apache.org/confluence/display/TS/CommitPolicies
Some of these wiki topics look outdated.
Should we update them, or even remove them to avoid confusion?
--
Derek
Walt Karas
wrote:
> The current C interface is bad because resources are not freed in
> destructors, and the use of raw void pointers is necessary.
>
> On Mon, Mar 19, 2018 at 10:09 AM, Derek Dagit
> wrote:
> > OK, so I am in favor of consistency with the existing C API, i
OK, so I am in favor of consistency with the existing C API, if possible
and only if there is not good reason to break with the way the C API is
doing it.
On Mon, Mar 19, 2018 at 9:58 AM, Walt Karas wrote:
> yes
>
>
> On Mon, Mar 19, 2018 at 9:54 AM, Derek Dagit
> wrote:
>
> Continuation(TSMutex mutexp = TSMutexCreate()) :
Not every continuation requires a mutex. To get behavior similar to the
current C API we would need to pass a `nullptr` to the constructor, right?
On Fri, Mar 16, 2018 at 6:39 PM, Walt Karas wrote:
> Does this seem like a good wrapper class fo
What happened to proposed 7.2.x releases?
I think some of the confusion on my part is around how to indicate a
back-port is requested for 7.2.x versus 7.1.x.
Happy to oblige,
On Thu, Mar 8, 2018 at 1:02 PM, Leif Hedstrom wrote:
> Hi all,
>
>
> we’re getting very close to make a v7.1.3 release.
+1 (non-binding) for #2
Steven's description seems reasonable to me also.
On Thu, Feb 8, 2018 at 11:26 AM, Bryan Call wrote:
> +1 - well said
>
> I prefer #2.
>
> -Bryan
>
> > On Feb 7, 2018, at 7:20 PM, Masaori Koshiba wrote:
> >
> > Hi,
> >
> > It looks like #1 violate the Semantic Versionin
3) Does it run on platforms that are supported by ATS, like FreeBSD? I
thought there was not official support without patching it, but not
sure.
On Thu, Sep 28, 2017 at 7:58 PM, Alan Carroll
wrote:
> There are two big issues for me:
>
> 1) What level of use will we have in the rest of the ATS cor
http://editorconfig.org/
Visual Studio and IntelliJ support this directly, and other editors including
VS Code, Vim, and Emacs support it with plugins.
Maybe we could standardize on editorconfig and let the plugins do the work?
--
Derek
On Friday, June 16, 2017, 9:18:34 AM CDT, Jason Kenny
52 matches
Mail list logo
