[GitHub] trafficserver pull request: TS-4291 Adds log field "pqnhl" which i...

2016-04-19 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/588#discussion_r60353113 --- Diff: proxy/hdrs/MIME.cc --- @@ -1197,6 +1197,27 @@ mime_hdr_length_get(MIMEHdrImpl *mh) return length; } +int +mime_hdr_ne

[GitHub] trafficserver pull request: TS-4291 Adds log field "pqnhl" which i...

2016-04-19 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/588#discussion_r60352813 --- Diff: proxy/logging/LogAccessTest.cc --- @@ -300,6 +300,19 @@ LogAccessTest::marshal_proxy_req_header_len(char *buf)

[GitHub] trafficserver pull request: TS-4291 Adds log field "pqnhl" which i...

2016-04-19 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/588#discussion_r60352665 --- Diff: proxy/logging/Log.cc --- @@ -594,6 +594,11 @@ Log::init_fields() global_field_list.add(field, false); ink_hash_table_insert(field

[GitHub] trafficserver pull request: TS-4291 Adds log field "pqnhl" which i...

2016-04-19 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/588#discussion_r60352588 --- Diff: proxy/hdrs/HTTP.cc --- @@ -642,6 +653,19 @@ http_hdr_length_get(HTTPHdrImpl *hdr) /*--

[GitHub] trafficserver pull request: TS-4291 Adds log field "pqnhl" which i...

2016-04-19 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/588#discussion_r60352567 --- Diff: proxy/hdrs/HTTP.cc --- @@ -593,8 +593,8 @@ http_hdr_describe(HdrHeapObjImpl *raw, bool recurse) /*

[GitHub] trafficserver pull request: TS-4291 Adds log field "pqnhl" which i...

2016-04-19 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/588#discussion_r60352521 --- Diff: proxy/hdrs/HTTP.h --- @@ -871,6 +873,16 @@ HTTPHdr::length_get() /*---

[GitHub] trafficserver pull request: TS-3429: Fix reference counting for TS...

2016-04-19 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/576#issuecomment-212225694 @shinrich that makes sense. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] trafficserver pull request: Adding STL Allocator which uses io buf...

2016-04-19 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/556#issuecomment-212224968 I'll open a new PR with feedback soon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] trafficserver pull request: Adding STL Allocator which uses io buf...

2016-04-19 Thread bgaff
Github user bgaff closed the pull request at: https://github.com/apache/trafficserver/pull/556 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] trafficserver pull request: removing a bad comma

2016-04-19 Thread bgaff
Github user bgaff closed the pull request at: https://github.com/apache/trafficserver/pull/587 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] trafficserver pull request: TS-4291 Adds log field "pqnhl" which i...

2016-04-19 Thread ogoodman
GitHub user ogoodman opened a pull request: https://github.com/apache/trafficserver/pull/588 TS-4291 Adds log field "pqnhl" which ignores internal headers. This should be a very safe fix in that it only adds a new log field and does not change the behaviour of any existing functions

[GitHub] trafficserver pull request: Add VIA_ERROR_MOVED_TEMPORARILY

2016-04-19 Thread JamesPeach
Github user JamesPeach commented on the pull request: https://github.com/apache/trafficserver/pull/586#issuecomment-212182075 Please update ``traffic_via`` and any other places that document or reference the Via string. --- If your project is set up for it, you can reply to this emai

[GitHub] trafficserver pull request: removing a bad comma

2016-04-19 Thread zizhong
GitHub user zizhong opened a pull request: https://github.com/apache/trafficserver/pull/587 removing a bad comma removing a bad comma You can merge this pull request into a Git repository by running: $ git pull https://github.com/zizhong/trafficserver bad_comma Alternatively y

[GitHub] trafficserver pull request: Add VIA_ERROR_MOVED_TEMPORARILY

2016-04-19 Thread zizhong
GitHub user zizhong opened a pull request: https://github.com/apache/trafficserver/pull/586 Add VIA_ERROR_MOVED_TEMPORARILY add VIA_ERROR_MOVED_TEMPORARILY to deal with redirect by remapping correctly for instrumentation (logging, metrics) You can merge this pull request into a Gi

[GitHub] trafficserver pull request: TS-4055: another clean up fix to elimi...

2016-04-19 Thread shinrich
GitHub user shinrich opened a pull request: https://github.com/apache/trafficserver/pull/585 TS-4055: another clean up fix to eliminate the crash case. Another fix for TS-4055 to eliminate NULL server_entry->write_vio's. See discussion on PR #373 You can merge this pull request i

[GitHub] trafficserver pull request: TS-4055: InactivityCop callback SM wit...

2016-04-19 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/373#issuecomment-212108558 Ok, I see, @bcall commited this change on 12/14/15, but was off by one in the bug number, So all the commits didn't necessarily line up nicely. The commit # was

[GitHub] trafficserver pull request: TS-4055: InactivityCop callback SM wit...

2016-04-19 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/373#issuecomment-212107082 Sorry for the long delay. It looks like the original code change in this PR got committed to master through one path or another. @oknet you can go ahead and cl

[GitHub] trafficserver pull request: TS-4180: Support for multiple intermed...

2016-04-19 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/578#issuecomment-212078480 Well looking at the existing tests anyway told me that my initial solution was wrong. We are moving into the area where behavior changes between 1.0.2 and 1.0.1

[GitHub] trafficserver pull request: TS-4147 Allow gzip plugin to be a rema...

2016-04-19 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/579 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] trafficserver pull request: TS-4147 Allow gzip plugin to be a rema...

2016-04-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/579#issuecomment-212042359 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] trafficserver pull request: TS-4318 Fix a regression in regex rule...

2016-04-19 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/580 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] trafficserver pull request: TS-4361: Remove TS_FETCH_EVENT handler...

2016-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/581 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4364: Address remnants from HTTP/2 ...

2016-04-19 Thread shinrich
GitHub user shinrich opened a pull request: https://github.com/apache/trafficserver/pull/584 TS-4364: Address remnants from HTTP/2 refactoring Add back in support for HttpSM->plugin_tag to enable protocol logging and fix for TS-3954 You can merge this pull request into a Git reposi

[GitHub] trafficserver pull request: TS-4361: Remove TS_FETCH_EVENT handler...

2016-04-19 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/581#issuecomment-211986088 Yes, those events should no longer appear. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] trafficserver pull request: TS-4187: Keep the currently_open conne...

2016-04-19 Thread shinrich
GitHub user shinrich opened a pull request: https://github.com/apache/trafficserver/pull/583 TS-4187: Keep the currently_open connections in sync with open sockets This is an improvement on the original fix for TS-4187. The original fix would in some case over count the open socket

[GitHub] trafficserver pull request: TS-3429: Fix reference counting for TS...

2016-04-19 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/576#issuecomment-211951906 Actually, that is why I added the check against period. If you do a schedule every, the handler gets called with event= EVENT_INTERVAL and e->period is non zero

[GitHub] trafficserver pull request: TS-3429: Fix reference counting for TS...

2016-04-19 Thread shinrich
Github user shinrich commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/576#discussion_r60242660 --- Diff: proxy/InkAPI.cc --- @@ -991,7 +991,16 @@ INKContInternal::handle_event(int event, void *edata) Warning("INKCont Deletable but not

[GitHub] trafficserver pull request: TS-4046: Prevent memory leak of HTTP h...

2016-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/577 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature