GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/583
TS-4187: Keep the currently_open connections in sync with open sockets
This is an improvement on the original fix for TS-4187. The original fix
would in some case over count the open sockets. It seems sometimes, the
connection would have already been closed or rather be scheduled to be closed
multiple times. We would increase the currently_open count for every scheduled
close, but only decrease it for the actual free.
I've changed things around to decrease in the do_io_close if it is called
with a valid file descriptor.
This seems to better keep the currently_open count in sync with the
established socket count on the systems. However, both grow until we run out
of memory on our production boxes. But that is being tracked by TS-4330
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shinrich/trafficserver ts-4348
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/583.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #583
----
commit 93069041e3d42255e016d818f5c849587a52b025
Author: Susan Hinrichs <[email protected]>
Date: 2016-04-15T16:34:25Z
TS-4187: Keep the currently_open connections in sync with the number of
sockets open.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
