Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/588#discussion_r60353113
--- Diff: proxy/hdrs/MIME.cc ---
@@ -1197,6 +1197,27 @@ mime_hdr_length_get(MIMEHdrImpl *mh)
return length;
}
+int
+mime_hdr_net_length_get(MIMEHdrImpl *mh)
--- End diff --
I think it would be better if this function and ``mime_hdr_length_get``
shared an internal implementation, passing a parameter to determine whether to
include internal headers.
Since you are studying this code, why is ``length`` initialized to 2? Is it
to account for the ``\r\n``?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
