Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/245#issuecomment-120191769
@jpeach from our conversations on IRC it sounds like you aren't opposed to
adding this, but rather want to start making this more general. If we could
make a ti
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/245#issuecomment-120191816
@SolidWallOfCode How does this PR look to you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/245#issuecomment-120151397
Because generating raw HTML in core code is unmaintainable. The right
approach is to extract the data and publish it in the appropriate format for
the consumer (e.
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/245#issuecomment-120147643
Why do we want to kill the httpui? We use it all the time for stats
collection
---
If your project is set up for it, you can reply to this email and have your
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/194#issuecomment-120100458
@shinrich rebased off apache/master and opened a new PR for this here. this
one had some weirdness because of issues w/ apache/master and yahoo/master
be
Github user ericcarlschwartz closed the pull request at:
https://github.com/apache/trafficserver/pull/194
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
GitHub user ericcarlschwartz opened a pull request:
https://github.com/apache/trafficserver/pull/246
TS-3534 Wiretracing SSL Connections
Initial Commit
TS-3534 Cleanup before PR
remove tcp_info traces
fix sni server name
update rand mechanism and u
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/194#issuecomment-120092663
@ushachar @shinrich I tend to agree that having some simple stuff available
as records.config settings for those who don't want to write a new plugin each
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/245#issuecomment-120083151
Absolutely agree, lets not put more stuff into httpui, we should aim to
eliminate it for 7.0.0. Move things over to the management port and traffic_ctl
please.
--
Github user ushachar commented on the pull request:
https://github.com/apache/trafficserver/pull/194#issuecomment-120083030
I think moving the entire "when to debug" logic to plugin space would be a
better idea -- yes.
Mostly in order to simplify the core code, but also to allow so
Github user fpesce closed the pull request at:
https://github.com/apache/trafficserver/pull/218
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user fpesce commented on the pull request:
https://github.com/apache/trafficserver/pull/218#issuecomment-120059157
Done @shinrich :smiley:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/243#issuecomment-120055508
I didn't have any specific reason. It seemed like it wouldn't cause any
problems, so I just added it in.
---
If your project is set up for it, you can reply to t
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/245#issuecomment-120039117
I'm strongly in favor of introspecting HostDB, but I don't like extending
HTTPUI. The right way to do this IMHO is to add management APIs so you can
expose it thro
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/194#issuecomment-120036935
I think @ushachar is suggesting that this whole feature should be in a
plugin?
---
If your project is set up for it, you can reply to this email and have your
rep
Github user ericcarlschwartz commented on the pull request:
https://github.com/apache/trafficserver/pull/244#issuecomment-120004282
@shinrich ah yeah I wasn't sure why it'd been dropped but I also can't see
any reason adding it back would introduce any problems either
---
If your pro
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/194#issuecomment-119973950
@ushachar I agree with your comment about making the computeSSLTrace
decision accessible from the plugin. I read your earlier comment too quickly
and thought yo
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/243#issuecomment-119959897
Looks good. My only question is why you bothered to make this a dynamic
config. It seems like requiring a restart would not be bad.
I don't think the
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/244#issuecomment-119953440
Looks reasonable as a stopgap to me. Hopefully we can in the near future do
better through restructuring the underlying protocol handling structure as in
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/244#issuecomment-119948800
Looks good to me.
My only question was why had the PluginIdentity been earlier removed as a
parent of the SpdyClientSession? @SolidWallOfCode dug up
Github user ushachar commented on the pull request:
https://github.com/apache/trafficserver/pull/194#issuecomment-119945084
I still think all the SSLNetVConnection::computeSSLTrace() logic should be
moved into plugin space - even if not extending TSHttpSsnDebugSet and keeping
this as
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/218#issuecomment-119944358
Sorry I had a git log mishap pushing these changes. I missed the "This
closes" comment and the changes showed up in the following for comments.
{code}
22 matches
Mail list logo
