Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/243#issuecomment-119959897
Looks good. My only question is why you bothered to make this a dynamic
config. It seems like requiring a restart would not be bad.
I don't think there are any bad race conditions here. And I suppose of the
operator is honing in on a desirable collection interval the dynamic restart
might be useful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
