Github user shinrich commented on the pull request:

    https://github.com/apache/trafficserver/pull/244#issuecomment-119948800
  
    Looks good to me.  
    
    My only question was why had the PluginIdentity been earlier removed as a  
parent of the SpdyClientSession?  @SolidWallOfCode dug up the commit and it 
turned out I did it as part of a commit to move more logic into that abstract 
ProxyClientSession class.  I'm sure that was an accident, so adding it back 
should be just fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to