[GitHub] trafficserver pull request: Fixes for TS-3720

2015-06-25 Thread jacksontj
Github user jacksontj commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/234#discussion_r33326252 --- Diff: iocore/hostdb/I_HostDBProcessor.h --- @@ -254,6 +254,41 @@ struct HostDBInfo { uint64_t md5_high; + /* + * Giv

[GitHub] trafficserver pull request: Fixes for TS-3720

2015-06-25 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/234#discussion_r33326221 --- Diff: iocore/hostdb/I_HostDBProcessor.h --- @@ -254,6 +254,41 @@ struct HostDBInfo { uint64_t md5_high; + /* +

[GitHub] trafficserver pull request: Fixes for TS-3720

2015-06-25 Thread jacksontj
GitHub user jacksontj opened a pull request: https://github.com/apache/trafficserver/pull/234 Fixes for TS-3720 The first commit here is to revert @SolidWallOfCode 's commit that has broken it right now. We actually had a long conversation about this on IRC and we'd prefer a better

[GitHub] trafficserver pull request: TS-2150: Add Milestone log tags

2015-06-25 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/229#issuecomment-115379759 Looking much better. I think the `std::map` use is acceptable - it's not modified on the critical path and so there are no allocations which should be fin

[GitHub] trafficserver pull request: TS-2150: Add Milestone log tags

2015-06-25 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/229#discussion_r33297453 --- Diff: proxy/logging/LogField.cc --- @@ -132,6 +168,13 @@ LogField::LogField(const char *name, const char *symbol, Type type, MarshalFunc

[GitHub] trafficserver pull request: TS-3136: Update default ciphersuite li...

2015-06-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/233 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature