Re: [dev] [dvtm] [PATCH] Use ERR as the modifier for direct key bindings.

2014-02-11 Thread Marc André Tanner
On Wed, Feb 05, 2014 at 11:17:27PM +0100, Mark Edgar wrote: > On Sat, Jan 11, 2014 at 11:15 PM, Marc André Tanner > wrote: > > If I recall correctly you mentioned that you have a patch which makes > > the window title configurable: top / bottom / disable. Would you mind >

Re: [dev] dvtm cmd-fifo issue

2014-02-11 Thread Marc André Tanner
vation to look into it more seriously. Marc -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] tmux/screen alternative

2014-02-23 Thread Marc André Tanner
t I hope that in combination with dvtm this will serve as a cleaner, simpler, more robust and generally suckless alternative to tmux/screen. Comments welcome. Marc -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] tmux/screen alternative

2014-02-23 Thread Marc André Tanner
On Sun, Feb 23, 2014 at 11:58:36AM +, Raphaël Proust wrote: > On Sun, Feb 23, 2014 at 11:45 AM, Marc André Tanner > wrote: > > http://repo.or.cz/w/abduco.git > > Can you explain why you coded it? What in dtach(1) didn't you like? To be honest it started out a year ag

[dev] [ANNOUNCE] dvtm-0.11

2014-03-08 Thread Marc André Tanner
logout properly using the existing system mechanism. Cheers, Marc -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

[dev] [RFC] abduco: session {at,de}tach support

2014-03-08 Thread Marc André Tanner
7 of the SLOC. Try it out and report back! As always patches welcome. git clone git://repo.or.cz/abduco.git Cheers, Marc -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [ANNOUNCE] dvtm-0.11

2014-03-17 Thread Marc André Tanner
On Sat, Mar 08, 2014 at 10:07:40PM +0100, Sanel Zukan wrote: > On 03/08/14,Marc André Tanner wrote: > > * the lock functionality (MOD-X) has been removed, use a session > >management tool like abduco to detach from your controlling > >terminal and logout proper

Re: [dev] [ANNOUNCE] dvtm-0.11

2014-03-17 Thread Marc André Tanner
o try the tagging branch and come up with better keybindings... Marc -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [ANNOUNCE] dvtm-0.11

2014-03-18 Thread Marc André Tanner
brings a tag into your current view. No, it adds/removes a given tag to/from the focused window > 'toggleview' doesn't seem to do...anything. adds/removes all windows with a given tag to/from the view Hope that helps. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] Using the scrollback from dvtm

2014-03-22 Thread Marc André Tanner
On Fri, Mar 21, 2014 at 11:10:36AM -0400, Nick wrote: > Is the shift + pgup / pgdown thing documented anywhere, and I just > missed it? If not, it probably should be. Thanks for the suggestion. It was indeed missing from the man page. Should be fixed now. Thanks, Marc -- Marc André

Re: [dev] Re: [dvtm] [PATCH] Fix redraw bug when show_border() changes.

2014-06-18 Thread Marc André Tanner
Applied both. Thanks, Marc -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] Why do you use tmux/screen?

2014-07-03 Thread Marc André Tanner
nent in the above setup is probably dvtm's scrollback buffer whose size you can control via the -h command line option. Marc -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

[dev] [ANNOUNCE] dvtm-0.12, tiling window management for the console

2014-07-05 Thread Marc André Tanner
his patches. Cheers, Marc [1] http://repo.or.cz/w/dvtm.git/shortlog/refs/heads/tagging -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

[dev] [ANNOUNCE] abduco-0.1, a lightweight alternative to tmux and screen

2014-07-05 Thread Marc André Tanner
e for further information. Feedback welcome, hope it is useful to some of you. Marc -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [sandy] [PATCH] VIM key bindings.

2014-07-09 Thread Marc André Tanner
t for me this includes a design based on piece tables rather than the double linked list approach taken by sandy. Also it would be nice if the actual text editing component would be clearly separated out, such that different editor frontends can be implemented easily. Marc -- Marc André T

Re: [dev] [ANNOUNCE] abduco-0.1, a lightweight alternative to tmux and screen

2014-07-09 Thread Marc André Tanner
On Sat, Jul 05, 2014 at 10:28:52AM +0200, Marc André Tanner wrote: > I'm pleased to announce the first official release of abduco The git version of abduco and dvtm should now also work on Solaris. Furthermore abduco is now also packaged for Fedora[0]. If some Debian developer is lurkin

Re: [dev] [sandy] [PATCH] VIM key bindings.

2014-07-10 Thread Marc André Tanner
On Wed, Jul 09, 2014 at 05:00:45PM -0400, Carlos Torres wrote: > Hey Marc, > > On Wed, Jul 9, 2014 at 4:42 PM, Marc André Tanner wrote: > > On Wed, Jul 09, 2014 at 09:14:16PM +0200, Rafa Garcia Gallego wrote: > > ...this includes > > a design based on piece tables ra

Re: [dev] [dvtm] [PATCH] Replace interpret_esc_xterm with interpret_osc.

2014-07-14 Thread Marc André Tanner
On Sun, Jul 13, 2014 at 10:51:02PM +0200, Mark Edgar wrote: > The patch below fixes a bug where title changes are not recognized, e.g.: > > printf '\033];title\007' > > The missing parameter (before the semicolon) should be interpreted as 0. Thanks, applied! --

Re: [dev] [abduco] Read-only connect to session from other user

2014-08-14 Thread Marc André Tanner
x27;connect'). Also abduco currently doesn't understand your option string '-ar' but instead requires it as '-a -r'. Hope this helps. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [abduco] Read-only connect to session from other user

2014-08-14 Thread Marc André Tanner
should work fine with most applications and for the others running them under dvtm might be an option. abduco -c foo dvtm tcsh Though that seems to show a black window upon exiting from tcsh. After another key press a dvtm window running your default shell appears. Cheers, Marc -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] Re: [dvtm] Focus by id instead of order

2014-09-08 Thread Marc André Tanner
r version makes perfect sense. Depending on whether you also use the Mod+n functionality you might want to duplicate the function instead of modifying focusn directly. Are your changes / scripting commands online somewhere? Marc -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

[dev] [RFC] Design of a vim like text editor

2014-09-13 Thread Marc André Tanner
s the interested people started. Feel free to ask questions if something is unclear! There are still a lot of bugs left to fix, but by now I'm fairly sure that the general concept should work. As always, comments and patches welcome! Cheers, Marc [0] http://www.inf.ethz.ch/personal/wirth/ProjectOberon/ [1] https://www.openhub.net/p/vim [2] http://swtch.com/~rsc/regexp/ [3] http://lists.suckless.org/dev/1408/23219.html -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] Re: [RFC] Design of a vim like text editor

2014-09-13 Thread Marc André Tanner
On Sat, Sep 13, 2014 at 04:39:15PM +0200, Christian Neukirchen wrote: > Marc André Tanner writes: > > TLDR: I'm writing an experimental but (hopefully) highly efficient vim > > like text editor based on a piece chain data structure. You will find > > an url to a git rep

Re: [dev] [RFC] Design of a vim like text editor

2014-09-13 Thread Marc André Tanner
course! They will be evaluated on an individual basis. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [RFC] Design of a vim like text editor

2014-09-13 Thread Marc André Tanner
patches > to add the feature, or should this list be considered a blacklist? Yes I will certainly evaluate patches which add other kind of functionality. It is more a list of stuff which I personally don't (currently?) use/need and therefore have no particular interest in. On a technical level for this to work, you would also have to repeat past commands but to be honest I don't even know what is possible with macros. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] Re: [RFC] Design of a vim like text editor

2014-09-14 Thread Marc André Tanner
ted. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [RFC] Design of a vim like text editor

2014-09-14 Thread Marc André Tanner
ith "ee"'s in each line. Then do a dd. The last line > won't get deleted and sometimes, a line is removed, but leaves a single "e" > as a trace. This should now be fixed, however due to the way new lines are handled the cursor is not moved a line up. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [RFC] Design of a vim like text editor

2014-09-14 Thread Marc André Tanner
On Sat, Sep 13, 2014 at 11:32:44PM +0200, Christian Hesse wrote: > Marc André Tanner on Sat, 2014/09/13 16:01: > > TLDR: I'm writing an experimental but (hopefully) highly efficient vim > > like text editor based on a piece chain data structure. You will find > > an

Re: [dev] [vis][PATCH] Window line up/down

2014-09-15 Thread Marc André Tanner
+ { { CONTROL('y')}, cursor, { .m = window_line_up > } }, > + { { CONTROL('e')}, cursor, { .m = window_line_down > } }, As you probably found out in the meantime this should probably not be hooked up via the basic_movement array which is the &quo

Re: [dev] [RFC] Design of a vim like text editor

2014-09-15 Thread Marc André Tanner
On Sun, Sep 14, 2014 at 09:02:30PM -0500, M Farkas-Dyck wrote: > On 13/09/2014, Marc André Tanner wrote: > > The default interface is a vim clone called vis. > > Name clash on BSD [1][2][3] This is somewhat unfortunate but the opportunity was too good not to make a reference to

Re: [dev] [RFC] Design of a vim like text editor

2014-09-15 Thread Marc André Tanner
On Mon, Sep 15, 2014 at 10:49:09AM +0300, Dimitris Zervas wrote: > On September 13, 2014 5:01:15 PM EEST, "Marc André Tanner" > wrote: > >TLDR: I'm writing an experimental but (hopefully) highly efficient vim > >like text editor based on a piece chain data struc

Re: [dev] [RFC] Design of a vim like text editor

2014-09-15 Thread Marc André Tanner
4 at 04:01:15PM +0200, Marc André Tanner wrote: > > Text management using a piece table/chain > > = > > > > [...] > > While this looks like a nice data structure for editing arbitrary byte > string, you can get much better actu

Re: [dev] [vis][PATCH] Window line up/down

2014-09-16 Thread Marc André Tanner
Thanks -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [RFC] Design of a vim like text editor

2014-09-16 Thread Marc André Tanner
ries to make syntax highlighting more efficient. I will have to take another look. In any case make sure to use the latest git version which has some code cleanups in window.c (not related to drawing though). Thanks, -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [dvtm][PATCH] Makefile and terminfo

2014-09-16 Thread Marc André Tanner
On Tue, Sep 16, 2014 at 11:31:05AM -0400, Wolfgang Corcoran-Mathe wrote: > I do think it would be nice if this line were in config.mk, as > it seems to be system-specific. I agree, will do. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [vis][PATCH] Window line up/down

2014-09-17 Thread Marc André Tanner
On Tue, Sep 16, 2014 at 03:41:43PM -0300, Amadeus Folego wrote: > On Tue, Sep 16, 2014 at 07:55:40PM +0200, Marc André Tanner wrote: > > I have cleaned up the cursor handling code in window.[ch] and implemented > > the CTRL-{U,D,E,Y} functionality in normal mode. However

Re: [dev] [RFC] Design of a vim like text editor

2014-09-17 Thread Marc André Tanner
ke: n>mj simply indent the next n*m lines by one level. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [RFC] Design of a vim like text editor

2014-09-18 Thread Marc André Tanner
, that you should not have too long > and to deep indents. Yes. > the other workaround is to use == (automatic aligning) on the next n > lines (or, again, on i{). which will mostly automatically do the m > indenting you're looking for. > personally, i only use == on single li

Re: [dev] [RFC] Design of a vim like text editor

2014-09-24 Thread Marc André Tanner
ulation, current filename) I also think that using environment variables for those (if needed at all) makes more sense. > - inserting registers with ctrl-r (ctrl-r% inserts the filename in the file > itself) CTRL-R [reg] should work in insert mode, no special registers are implemented though. > - optional syntax highlighting do you mean a way to disable it? :set syntax off should work? > - i'm not sure that having j/k behaving like gj/gk is a good idea Yes, I will give the other option a try. The lines however will always be wrapped. Horizontal scrolling will not be supported. Thanks again for your valuable feedback! I hope some issues are already fixed and others will hopefully be in the future. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [RFC] Design of a vim like text editor

2014-09-24 Thread Marc André Tanner
ntly only has one count for both operators and movements. vim multiplies them if I recall correctly. vis doesn't do this at the moment. It just performs the movement count times but preserves the value given in OperatorContext->count. Hence also my question the other day regarding how to shift m lines by n levels ... Strictly speaking 'p' is not even an operator but it is implemented that way to make it repeatable. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [RFC] Design of a vim like text editor

2014-09-24 Thread Marc André Tanner
On Wed, Sep 24, 2014 at 04:05:46PM -0400, Wolfgang Corcoran-Mathe wrote: > Quoth Marc André Tanner on Wed, Sep 24 2014 21:21 +0200: > >>o O should go into insert mode after adding the line > >>a appends at the current cursor place > > > >Fixed > > Marc, &g

Re: [dev] [RFC] Design of a vim like text editor

2014-09-25 Thread Marc André Tanner
On Wed, Sep 24, 2014 at 05:20:44PM -0400, random...@fastmail.us wrote: > On Wed, Sep 24, 2014, at 15:21, Marc André Tanner wrote: > > > x should not delete the end of line character (but this might be solved > > > with the placement issue above) > > > > I (and a

Re: [dev] [RFC] Design of a vim like text editor

2014-09-25 Thread Marc André Tanner
On Wed, Sep 24, 2014 at 05:33:49PM -0400, random...@fastmail.us wrote: > On Wed, Sep 24, 2014, at 15:36, Marc André Tanner wrote: > > > - 'J' in visual mode is not implemented > > > > Why would one use it? > > To be able to select lines to be joined intera

Re: [dev] [RFC] Design of a vim like text editor

2014-09-27 Thread Marc André Tanner
things to do. Therefore the window layout code of vis is intentionally very simple (about 20 LOC) and only supports equally sized windows arranged either horizontally or vertically. > > > - optional syntax highlighting > > > > do you mean a way to disable it? > > we

Re: [dev] [RFC] Design of a vim like text editor

2014-09-30 Thread Marc André Tanner
On Wed, Sep 24, 2014 at 10:58:11PM +0200, Silvan Jegen wrote: > On Wed, Sep 24, 2014 at 09:36:12PM +0200, Marc André Tanner wrote: > > On Wed, Sep 24, 2014 at 06:12:30PM +0200, Silvan Jegen wrote: > > > On Tue, Sep 23, 2014 at 08:03:45PM +0200, ale rimoldi wrote: > > >

Re: [dev] [st][PATCH] Add support for utmp in st

2014-10-10 Thread Marc André Tanner
ood idea? The user asked to execute args[0] instead of the shell, but this doesn't imply that args[0] is his shell. With this change "st -e dvtm" results in a fork bomb because dvtm uses $SHELL to launch its internal windows and thus executes itself within itself ... -- Mar

Re: [dev] [stali] What happened to stali?

2014-10-16 Thread Marc André Tanner
gle executable as well as into individual binaries. The design philosophy seems reasonable. http://landley.net/code/toybox/design.html Cheers, -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [PATCH] [st] Fix issues with wcwidth() returning -1 for

2014-10-27 Thread Marc André Tanner
int wcwidth(wchar_t wc): "... or return -1 (if wc does not correspond to a printable wide-character code)." Therefore I think a return value of -1 should be handled gracefully. Having said that in dvtm it seems completely broken at the moment, no char shows up at all. Patches for that are certainly welcome ... -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [dvtm] Truecolor support

2014-10-27 Thread Marc André Tanner
ng up some dvtm internals. It would thus be a good time to send patches. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [dvtm] Truecolor support

2014-10-27 Thread Marc André Tanner
ese terminals which do not yet have support built in? The whole point of terminfo/curses is to abstract away these ugly details. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [dvtm] Truecolor support

2014-10-29 Thread Marc André Tanner
OP wants option 2). This could probably be achieved by using init_color(3) and maintaining some sort of mapping from (fg-rgb, bg-rgb) -> color pair. Or probably better using 2 such mappings (r,g,b) -> color number and (fg, bg) -> color pair. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

[dev] dvtm status update

2014-11-01 Thread Marc André Tanner
for those of you interested in SLOC, the copy mode change removed ~500 lines of code whereas the tagging stuff added around ~300. [0] git clone git://repo.or.cz/dvtm.git -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] dvtm status update

2014-11-07 Thread Marc André Tanner
On Sat, Nov 01, 2014 at 11:21:49AM +0100, Marc André Tanner wrote: > The copy mode, allowing you to move around in the scroll back buffer > history, selecting text and then later pasting it into different > windows was rewritten. It now works by piping the whole history to > your

Re: [dev] [abduco] [patch] more descriptive execvp error message

2014-11-10 Thread Marc André Tanner
No such file or directory > $ abduco -c test badname > server-execvp: badname: No such file or directory Thanks applied! I agree, the messages have still potential for improvement. Not sure whether it makes sense to include the function name as a prefix. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

[dev] [ANNOUNCE] abduco-0.2

2014-11-15 Thread Marc André Tanner
n be displayed by running: $ abduco Active sessions (on host hostname) Sat2014-11-15 15:10:18demo The session can be restored with $ abduco -a demo Read the manual page for further information. Cheers, Marc -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

[dev] [ANNOUNCE] dvtm-0.13

2014-11-15 Thread Marc André Tanner
interfaces. * Solaris and AIX support (with some tweaks to config.mk) All in all a lot of code was changed, comments, patches and a thorough review is always welcome! As a kind of social experiment I also pushed a mirror of the repository to github: https://github.com/martanne/dvtm Cheers, Marc --

Re: [dev] [sbase] style

2014-11-19 Thread Marc André Tanner
never understood this preference. It makes it clear that the variable is only used in the current scope. Recycling index-integers for mulitple loops makes the code less readable. The compiler will generate the same code anyway. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] why avoid install?

2014-11-19 Thread Marc André Tanner
not be security relevant. Getting a file descriptor and then performing the desired operations doesn't sound like such a bad idea ... -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] Patches to fix . for insert and change commands

2014-11-20 Thread Marc André Tanner
is also needs to be taken into account. Keeping track of the keystrokes makes the implementation somewhat uglier/harder but is probably necessary to provide certain features. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [vis] [PATCH] Set tabwidth and expandtab in config.def.h

2015-01-04 Thread Marc André Tanner
tor frontend implementing the specific vis/nano/sam/whatever interface. It should thus not directly refer to global variables. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [vis] [PATCH] Do not lump together replace actions

2015-02-03 Thread Marc André Tanner
buffer_repeat, k.str, strlen(k.str)); > editor_delete_key(vis); > editor_insert_key(vis, k.str, strlen(k.str)); Thanks for the patch! I will fix it by adding an explicit: text_snapshot(vis->win->text); And yes the replace implementation could be improved. Cheers, Marc -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

[dev] [ANNOUNCE] abduco-0.3

2015-02-19 Thread Marc André Tanner
long * Code cleanups and fixes from static analyzers * DragonFly BSD support As always comments and patches welcome! -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

[dev] [ANNOUNCE] dvtm-0.14

2015-02-19 Thread Marc André Tanner
ts for Wayland and curses? Cheers, Marc -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [ANNOUNCE] abduco-0.3

2015-02-26 Thread Marc André Tanner
hanges you should remove or chmod 700 your $HOME/.abduco folder. Please provide feedback whether this works as expected. Thanks -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

[dev] [ANNOUNCE] abduco-0.4

2015-03-18 Thread Marc André Tanner
the permission was set on the socket itself which is not portable. * Remove -C flag and instead introduce -f which forces session creation when combined with one of [-c|-n|-A]. * Rewritten README in markdown Cheers, Marc -- Marc André Tanner >< http://www.brain-dump.org/ >

Re: [dev] [vis][PATCH] Implement 'o' in visual mode: go to other end of selection.

2015-03-24 Thread Marc André Tanner
might be better suited for the second case? That was the original idea, however in practice it is not strictly followed. For example navigation of the jumplist/changelist is done via the second option which means it can't be prefixed with a count. Thanks! -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [vis][PATCH] Implement 'o' in visual mode: go to other end of selection.

2015-03-24 Thread Marc André Tanner
On Tue, Mar 24, 2015 at 04:36:14PM -0300, Marcel Rodrigues wrote: > Thanks for the helpful reply! > > I have reworked the patch (see attachment) based on your input. Thanks, applied. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [vis] buffer_alloc issues

2015-03-29 Thread Marc André Tanner
tate is always preferable to crashing and losing unsaved changes. > Another issue is that there is another buffer_alloc in text.c: > http://repo.or.cz/w/vis.git/blob/HEAD:/text.c > > Maybe these functions and data structures should be renamed to avoid > name conflict. I'm not

Re: [dev] [PATCH][RFC] bug: copy the command string in order to not sigsegv

2015-03-29 Thread Marc André Tanner
command -> > exec_cmdline_command. I'm in the process of separating the ui related code and generally providing a more library like interface to the the vis core, exec_command should thus take a const pointer and not modify its argument. While I agree the copying is somewhat ugly it i

Re: [dev] [vis] [PATCH] Fixed multiline comment regexp.

2015-04-03 Thread Marc André Tanner
ighting and reuse/convert their rule set. However given the implementation complexity (~50 LOC without rules) of the current solution, it works suprisingly well (at least for C like languages) ... -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [vis] [PATCH] Change behaviour of 'cw' and 'cW'

2015-04-03 Thread Marc André Tanner
x this is to check in movement(...) whether the action.operator is set to &ops[OP_CHANGE] and if so adjust action.movement accordingly. Would be nice if you sent a follow up patch. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [vis] [PATCH] Fixed multiline comment regexp.

2015-04-03 Thread Marc André Tanner
On Fri, Apr 03, 2015 at 07:44:22PM +, noname wrote: > Comments like "/***/" with odd number of asterisks are handled like > normal comments now. Previously they were handled like unfinished > comments. Thanks applied! -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [vis] [PATCH] Change behaviour of 'cw' and 'cW'

2015-04-03 Thread Marc André Tanner
On Fri, Apr 03, 2015 at 05:44:29PM -0300, Matias Linares wrote: > >To prevent errors like these, the various pointers in the Action struct > >should be marked const. > Should I add this changes on the patch? I will do it in a separate patch. -- Marc André Tanner >< http

[dev] [vis] ui separation and mainloop considerations

2015-04-03 Thread Marc André Tanner
rposes? Sending raw structs around or using something like msgpack? http://repo.or.cz/w/vis.git https://github.com/martanne/vis -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [vis][PATCH] small change to syntax coloring

2015-04-05 Thread Marc André Tanner
On Sat, Apr 04, 2015 at 07:11:29PM -0400, Aaron Burrow wrote: > This patch makes it so that the syntax coloring updates when you give > a document a name for the first time. Thanks, I will incorporate your changes later on. -- Marc André Tanner >< http://www.brain-dump.org

Re: [dev] [vis] [PATCH] Highlight null directive.

2015-04-15 Thread Marc André Tanner
Thanks, applied! -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [vis] [PATCH] Fix handling of file load errors

2015-04-15 Thread Marc André Tanner
ch breaks the simple case of opening/creating a not yet existing file as in: $ vis fancy-new-file-name [...] # editing :wq -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [vis] [PATCH] Fix handling of file load errors

2015-04-21 Thread Marc André Tanner
when opening a directory. > Also, opening a file you are not permitted to read, will now give an > error, instead of showing the file as empty. Thanks again for the patch! The issue should hopefully be fixed by http://repo.or.cz/w/vis.git/commitdiff/7aa5fcb1a8ea079dd1c8d948a170ddc56fc1c53d Ch

Re: [dev] [vis] [PATCH] Add '--' as end of options.

2015-05-06 Thread Marc André Tanner
> Some programs (like ranger) expect the editor to have this feature. Thanks for the patch, however it doesn't do what it describes? $ vis -- -v Still prints the version instead of opening a file called "-v". Also it would be nice to add a note to the man page. -- Marc An

Re: [dev] [vis][PATCH] Make the '.' Filerange work on one line

2015-05-06 Thread Marc André Tanner
ine_command. This should probably be changed such that the commands are called with an empty range. Then each command can decide what its default should be. For example :write should default to the whole file while :s/foo/bar/ should only be applied to the current line by default. Thanks, Marc -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [vis][PATCH] Use the command name without the Filerange in argv

2015-05-06 Thread Marc André Tanner
Thanks, will apply. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [vis][RFC][PATCH 1/2] Replace first '/' of substitute command with \0

2015-05-06 Thread Marc André Tanner
h the strategy outlined above argv[1] would contain the argument (= search pattern) which could be prefixed by 's'. Furthermore if the pattern doesn't contain the delimiter at the end, it should be appended. Please send an updated patch if you think this makes sense ... -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [vis][RFC][PATCH 2/2] Implement the execution of external commands and cmd_substitute

2015-05-06 Thread Marc André Tanner
if (data to read) read range and insert into [100, 110] ([110, 120], ...) 3) read command exit status depending on success - either delete original range [10, 100] and snapshot - or revert to last snapshot (text_undo) -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [vis] [PATCH] Add '--' as end of options.

2015-05-13 Thread Marc André Tanner
with the cursor placed at the first occurrence of pattern{1,2} respectively. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [vis][PATCH] Make the '.' Filerange work on one line

2015-05-13 Thread Marc André Tanner
On Thu, May 07, 2015 at 09:39:23AM +0200, Silvan Jegen wrote: > On Wed, May 6, 2015 at 8:35 PM, Marc André Tanner wrote: > > Also should '.' include the new line character? It seems like it does > > in vim. Then text_line_next should be used. > > I think the beh

Re: [dev] [vis][RFC][PATCH 1/2 v2] Rework the separation of command name and parameters

2015-05-13 Thread Marc André Tanner
The filter command is also named '!' which currently won't be recognized. Hence you need to distinguish whether '!' is used as a command name itself or rather after a command to indicate force. If you provide a patch doing that I will apply it. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [vis][RFC][PATCH 2/2] Implement the execution of external commands and cmd_substitute

2015-05-13 Thread Marc André Tanner
On Thu, May 07, 2015 at 10:15:34AM +0200, Silvan Jegen wrote: > On Wed, May 6, 2015 at 9:47 PM, Marc André Tanner wrote: > > Thanks, this will require more time to properly review than I currently > > have. What follows are therefore only a few general remarks. > > >

Re: [dev] [vis][PATCH v2] Make the '.' Filerange work on one line

2015-05-17 Thread Marc André Tanner
parse_range(char **cmd) { > break; > default: > r.start = parse_pos(cmd); > - if (**cmd != ',') > + if (orig != ',') { This part is wrong. I commited a (hopefully) fixed version. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [vis][RFC][PATCH 2/2] Implement the execution of external commands and cmd_substitute

2015-05-17 Thread Marc André Tanner
. If a range was suplied it gets replaced by the file content. Similarly :r! and :r ! are an alias for :! Finally :s/search/replace/ is translated to :!sed s/search/replace/ -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [vis][RFC][PATCH 1/2 v2] Rework the separation of command name and parameters

2015-05-17 Thread Marc André Tanner
On Thu, May 14, 2015 at 12:00:48AM +0200, Marc André Tanner wrote: > On Sat, May 09, 2015 at 06:12:53PM +0200, Silvan Jegen wrote: > > By replacing the first non-alphanumeric character (except '!' which is > > replaced by ' ' to get it ignored) > > I

Re: [dev] [vis][RFC][PATCH 2/2] Implement the execution of external commands and cmd_substitute

2015-05-18 Thread Marc André Tanner
On Mon, May 18, 2015 at 09:31:22PM +0200, Silvan Jegen wrote: > On Sun, May 17, 2015 at 01:18:26PM +0200, Marc André Tanner wrote: > > I have commited a couple of patches which should implement this > > functionality as described in another mail (i.e. without allocating > &g

Re: [dev] [dvtm] Pertag patch for dvtm

2015-05-26 Thread Marc André Tanner
patches nor a place to keep track of them. If there is interest I could offer to push it to a topic branch and update it before every release. Unfortunately I most likely won't have time during the next 2-3 weeks to properly try it out ... Thanks, Marc -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [dvtm] TAGKEYS macro for dvtm

2015-05-26 Thread Marc André Tanner
gt; > well. Patch is attached. > > > > The parentheses in the patch seem to be unbalanced. > > They may seem that way, but if you count them out they're balanced. My compiler also thinks that they are unbalanced ... -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] dvtm: don't change master or numbering

2015-05-26 Thread Marc André Tanner
s probably not what you want. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [dvtm] Bug fix for MOD after a mouse action

2015-06-23 Thread Marc André Tanner
ith a key binding, so will print to the current terminal > instead. Thanks, applied. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [dvtm] TAGKEYS macro for dvtm

2015-06-23 Thread Marc André Tanner
hat much space for tags makes sense ... > + TAGKEYS( '1', 0) Also it might be more intuitive to pass in the same tag number here and subtract one inside the TAGKEYS macro? I.e. TAGKEYS('1', 1) But as it is the same in dwm, I will leave it for now ... Thanks -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [dvtm] Mouse clicks on tags patch

2015-06-23 Thread Marc André Tanner
your rewrite? Should I wait for it, or should I consider applying the patch as is? Thanks -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] Re: [abduco] Strange behavior with abduco -A

2015-06-23 Thread Marc André Tanner
-A foo > > abduco: foo: detached > > abduco: foo: detached > > $ > > I found where this issue was introduced and I propose the attached patch > to fix it. Thanks for your analysis and the patch, it has been applied. -- Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

Re: [dev] [vis][RFC][PATCH 2/2] Implement the execution of external commands and cmd_substitute

2015-06-23 Thread Marc André Tanner
On Wed, May 27, 2015 at 06:53:11PM +0200, Silvan Jegen wrote: > On Mon, May 18, 2015 at 10:28:06PM +0200, Marc André Tanner wrote: > > On Mon, May 18, 2015 at 09:31:22PM +0200, Silvan Jegen wrote: > > > I did some light testing and the only issue I could find is that the >

Re: [dev] [PATCH][vis] Do not take a snapshot in text_range_write

2015-07-03 Thread Marc André Tanner
On Tue, Jun 23, 2015 at 08:36:01PM +0200, Silvan Jegen wrote: > This is a quick and dirty fix for the issues encountered with undoing > the filter command. There are still other issues to tackle though... Thanks, applied. Could you elaborate on the remaining issues to tackle? -- Marc

  1   2   >