Re: [dev][sbase][RFC] "tr" with -d option or without?

2014-04-12 Thread Silvan Jegen
On Fri, Apr 11, 2014 at 11:17:53PM +0100, sin wrote: > On Fri, Apr 11, 2014 at 09:07:10PM +0200, Silvan Jegen wrote: > > I can see the need for a '-d' flag for compatibility reasons but my > > preference would be to just ignore the flag if it is specified. What are > > peoples opinion on the '-d' f

Re: [dev][sbase][RFC] "tr" with -d option or without?

2014-04-12 Thread Martti Kühne
On Fri, Apr 11, 2014 at 9:07 PM, Silvan Jegen wrote: > I can see the need for a '-d' flag for compatibility reasons but my > preference would be to just ignore the flag if it is specified. What are > peoples opinion on the '-d' flag? > > In any case, the tr.1 man page should be updated and the TOD

Re: [dev][sbase][RFC] "tr" with -d option or without?

2014-04-12 Thread sin
On Sat, Apr 12, 2014 at 11:08:29AM +0200, Martti Kühne wrote: > On Fri, Apr 11, 2014 at 9:07 PM, Silvan Jegen wrote: > > I can see the need for a '-d' flag for compatibility reasons but my > > preference would be to just ignore the flag if it is specified. What are > > peoples opinion on the '-d'

Re: [dev][sbase][RFC] "tr" with -d option or without?

2014-04-12 Thread Hiltjo Posthuma
On Sat, Apr 12, 2014 at 9:31 AM, Silvan Jegen wrote: > On Fri, Apr 11, 2014 at 11:17:53PM +0100, sin wrote: >> On Fri, Apr 11, 2014 at 09:07:10PM +0200, Silvan Jegen wrote: >> > I can see the need for a '-d' flag for compatibility reasons but my >> > preference would be to just ignore the flag if

Re: [dev] [quark] [PATCH] correct information in README

2014-04-12 Thread sin
On Thu, Apr 10, 2014 at 08:55:08PM +0200, Jakob Kramer wrote: > There is wrong information about the installation directory and about > how to run quark in the README. Applied, thanks.

[dev] [lsw] [patch] Memory leak from XGetTextProperty

2014-04-12 Thread Virgile Andreani
Dear suckless developers, The manpage of XGetTextProperty mentions: > An extra byte containing null (which is not included in the nitems > member) is stored at the end of the value field of text_prop_return. Which, if I understand correctly, means that the value field of the property is dynamica

Re: [dev][sbase][RFC] "tr" with -d option or without?

2014-04-12 Thread Silvan Jegen
On Sat, Apr 12, 2014 at 01:06:17PM +0200, Hiltjo Posthuma wrote: > On Sat, Apr 12, 2014 at 9:31 AM, Silvan Jegen wrote: > > On Fri, Apr 11, 2014 at 11:17:53PM +0100, sin wrote: > >> On Fri, Apr 11, 2014 at 09:07:10PM +0200, Silvan Jegen wrote: > >> > I can see the need for a '-d' flag for compatib

Re: [dev][sbase][RFC] "tr" with -d option or without?

2014-04-12 Thread Hiltjo Posthuma
On Sat, Apr 12, 2014 at 6:58 PM, Silvan Jegen wrote: > >> I'll also probably rewrite the mmap code to use malloc since it causes >> issues on some machines. > > The reason we used mmap was that it allocates memory only on use. So > even if we mmap space for 1'114'112 ints (one for each unicode poi

[dev] [surf] link hinting

2014-04-12 Thread Swiatoslaw Gal
Did anyone implemented links hinting without java script? s.

Re: [dev][sbase][RFC] "tr" with -d option or without?

2014-04-12 Thread Silvan Jegen
On Sat, Apr 12, 2014 at 07:19:45PM +0200, Hiltjo Posthuma wrote: > On Sat, Apr 12, 2014 at 6:58 PM, Silvan Jegen wrote: > > > >> I'll also probably rewrite the mmap code to use malloc since it causes > >> issues on some machines. > > > > The reason we used mmap was that it allocates memory only on

Re: [dev] [surf] link hinting

2014-04-12 Thread Troels Henriksen
Swiatoslaw Gal writes: > Did anyone implemented links hinting without java script? Why would you want that? It would be hundreds of lines of tremendously ugly C-code for navigating the DOM, creating CSS, installing key handlers... -- \ Troels /\ Henriksen

Re: [dev] [surf] link hinting

2014-04-12 Thread Swiatoslaw Gal
> > Did anyone implemented links hinting without java script? > > Why would you want that? It would be hundreds of lines of tremendously > ugly C-code for navigating the DOM, creating CSS, installing key > handlers... The reason I switched javascript on default is… quite embarrassing. I use comp

Re: [dev] [surf] link hinting

2014-04-12 Thread Troels Henriksen
Swiatoslaw Gal writes: >> > Did anyone implemented links hinting without java script? >> >> Why would you want that? It would be hundreds of lines of tremendously >> ugly C-code for navigating the DOM, creating CSS, installing key >> handlers... > > The reason I switched javascript on default i

Re: [dev][sbase][RFC] "tr" with -d option or without?

2014-04-12 Thread sin
On Sat, Apr 12, 2014 at 09:02:05PM +0200, Silvan Jegen wrote: > True. I would suggest just adding checks and bailing out when the return > code is <0. Maybe something like the following? Looks good. Can you resend with an attachment?

Re: [dev][sbase][RFC] "tr" with -d option or without?

2014-04-12 Thread Silvan Jegen
On Sat, Apr 12, 2014 at 08:42:22PM +0100, sin wrote: > On Sat, Apr 12, 2014 at 09:02:05PM +0200, Silvan Jegen wrote: > > True. I would suggest just adding checks and bailing out when the return > > code is <0. Maybe something like the following? > > Looks good. Can you resend with an attachment?

Re: [dev][sbase][RFC] "tr" with -d option or without?

2014-04-12 Thread sin
On Sat, Apr 12, 2014 at 10:20:14PM +0200, Silvan Jegen wrote: > On Sat, Apr 12, 2014 at 08:42:22PM +0100, sin wrote: > > On Sat, Apr 12, 2014 at 09:02:05PM +0200, Silvan Jegen wrote: > > > True. I would suggest just adding checks and bailing out when the return > > > code is <0. Maybe something lik