Re: [dev] Introducing the imagefile-format

2014-07-28 Thread Louis Santillan
I know you're going for portability, but pulling in arpa/inet.h doesn't seem so suckless. The selection of bzip as the compression algorithm seems like a compromise. suckless flate[0], lzham[1], miniz[2], lz4/lz4hc[3], minilzo[4], fastlz[5] maybe deserve some consideration? flate, miniz, lz4, mi

Re: [dev] Introducing the imagefile-format

2014-07-28 Thread Anthony J. Bentley
FRIGN writes: > The only reason I used ntohl() and htonl() here is > the fact they're POSIX, and endian.h isn't. Isn't yet... http://austingroupbugs.net/view.php?id=162 -- Anthony J. Bentley

Re: [dev] Introducing the imagefile-format

2014-07-28 Thread Charlie Murphy
FRIGN wrote: > Bytes Description > 9 "imagefile" > 4 32-bit BE - width > 4 32-bit BE - height > [] RGBA Hello! I changed my mind and agree that using 32-bit integers is better than using ASCII strings. > Porting the xscreenshot-tool to imagefile cut almost half the LOC a

Re: [dev] Introducing the imagefile-format

2014-07-28 Thread Staven
On Tue, Jul 29, 2014 at 1:59 AM, FRIGN wrote: > Be careful: the n in ntohl does not stand for native, but network. > More or less by convention, the Network Byte Order today is BE. What > ntohl makes sure is that in case we are on a LE-system, it's arranged > properly. > ntohl is only superfluous

Re: [dev] Introducing the imagefile-format

2014-07-28 Thread FRIGN
On Tue, 29 Jul 2014 01:37:30 +0200 Staven wrote: > Isn't ntohl superfluous here? In fact, wouldn't this break on a big-endian > architecture? If I'm reading this right, we're storing the value in memory in > reverse (of native) byte order, assume it's now big-endian and convert it to > native byt

Re: [dev] Introducing the imagefile-format

2014-07-28 Thread FRIGN
On Tue, 29 Jul 2014 00:43:20 +0200 Robert Hülle wrote: > Possible problem with grayscale PNGs in png2if. I get bytes "00 ff 00 > ff" for black pixel when it should be "00 00 00 ff". At first I thought, this couldn't be, as I set PNG_TRANSFORM_EXPAND in png_read_png, but after some research, I fo

Re: [dev] Introducing the imagefile-format

2014-07-28 Thread Staven
On Mon, Jul 28, 2014 at 6:55 PM, FRIGN wrote: > fread(hdr, 1, 17, fd); > width = ntohl((hdr[9] << 0) | (hdr[10] << 8) | (hdr[11] << 16) | > (hdr[12] << 24)); > height = ntohl((hdr[13] << 0) | (hdr[14] << 8) | (hdr[15] << 16) | > (hdr[16] << 24)); Isn't ntohl superfluous

Re: [dev] Introducing the imagefile-format

2014-07-28 Thread Robert Hülle
On 2014-07-28 18:55:59, somebody claiming to be FRIGN wrote: > 4) USING THE IMAGEFILE-TOOLS > > The imagefile[0]-tools provide a way to convert between png and if using > pipes. > > 4.1) Trivial conversions > > $ png2if < image.png > image.if > $ if2png < image.if > im

Re: [dev] Introducing the imagefile-format

2014-07-28 Thread FRIGN
On Mon, 28 Jul 2014 17:40:20 -0400 Lee Fallat wrote: > Why was the "specification in the header" idea ditched? Just curious. > I think the current format is quite nice :) I'm glad you like it! Concerning the idea of "specification in the header", I literally spent half a day making up my mind on

Re: [dev] Introducing the imagefile-format

2014-07-28 Thread Lee Fallat
On Mon, Jul 28, 2014 at 12:55 PM, FRIGN wrote: > > ... > > Bytes Description > 9 "imagefile" > 4 32-bit BE - width > 4 32-bit BE - height > [] RGBA > > ... > > FRIGN Why was the "specification in the header" idea ditched? Just curious. I think the current format is quite

Re: [dev] xscreenshot(1) using suckless image format

2014-07-28 Thread stanio
> > Is there a reliable way to get the X id of a window in a shell script? This > xwininfo could help. that's very helful, thanks a lot, Marcus! cheers --s

Re: [dev] xscreenshot(1) using suckless image format

2014-07-28 Thread Wolfgang Corcoran-Mathe
Quoth Markus Teich on Mon, Jul 28 2014 23:26 +0200: Is there a reliable way to get the X id of a window in a shell script? xwininfo could help. Thanks you, Markus, xwininfo does exactly what I wanted. -- Wolfgang Corcoran-Mathe

Re: [dev] xscreenshot(1) using suckless image format

2014-07-28 Thread Markus Teich
Wolfgang Corcoran-Mathe wrote: > Is there a reliable way to get the X id of a window in a shell script? This > seems basic, but I could not find a way to do this that works for all windows. > Digging around in the output of `xprop -root` as in [0] looks far too ugly, to > me, to be the right thing.

Re: [dev] xscreenshot(1) using suckless image format

2014-07-28 Thread Wolfgang Corcoran-Mathe
Quoth Dimitris Papastamos on Mon, Jul 28 2014 15:14 +0100: Hiltjo Posthuma wrote xscreenshot[0] which basically generates an if on stdout. The imagefile[1] tools can be used to convert the if to png using if2png (thanks FRIGN!). This is a very useful tool, and imagefile looks like a great forma

Re: [dev] Introducing the imagefile-format

2014-07-28 Thread Amadeus Folego
On Mon, Jul 28, 2014 at 06:55:59PM +0200, FRIGN wrote: > As a result I came up with the first implementation, the if-tools[0], > capable of easily converting between png and imagefiles. Looks great! This would make a lot of image handling, automation and editing operations much easier and simple.

Re: [dev] Introducing the imagefile-format

2014-07-28 Thread Alexander Hof
FRIGN dixit: > Hello, > > after literally dozens of mails discussing a new suckless image-format, > I sat down last week to reflect on what could be the best of all > proposed format-specifications. > Awesome. Thanks to everyone who contributed.

Re: [dev] [PATCH] Reorder-and-extend-glyph-attributes

2014-07-28 Thread Ivan Delalande
On Mon, Jul 28, 2014 at 12:35:54PM +0200, Roberto E. Vargas Caballero wrote: > > > Faint, invisible, struck and fast blink are added as glyph attributes. > > > Since there's an edit here, let's take the opportunity to reorder them > > > so that they correspond to the two's power of the correspondin

[dev] Introducing the imagefile-format

2014-07-28 Thread FRIGN
Hello, after literally dozens of mails discussing a new suckless image-format, I sat down last week to reflect on what could be the best of all proposed format-specifications. As a result I came up with the first implementation, the if-tools[0], capable of easily converting between png and imagefi

Re: [dev] xscreenshot(1) using suckless image format

2014-07-28 Thread FRIGN
On Mon, 28 Jul 2014 15:14:46 +0100 Dimitris Papastamos wrote: > The imagefile[1] tools can be used to convert the if to > png using if2png (thanks FRIGN!). For everyone interested, I'm planning on writing a short introduction to the format and how you can work with it this evening. Porting xscr

[dev] xscreenshot(1) using suckless image format

2014-07-28 Thread Dimitris Papastamos
Hi all, Hiltjo Posthuma wrote xscreenshot[0] which basically generates an if on stdout. The imagefile[1] tools can be used to convert the if to png using if2png (thanks FRIGN!). The dependencies are kept to a minimum so xscreenshot only depends on libX11 and the imagefile tools depend on libpng.

Re: [dev] [PATCH] Reorder-and-extend-glyph-attributes

2014-07-28 Thread Roberto E. Vargas Caballero
> > Faint, invisible, struck and fast blink are added as glyph attributes. > > Since there's an edit here, let's take the opportunity to reorder them > > so that they correspond to the two's power of the corresponding escape > > code. (just for neatness, let's hope that property never gets used for

Re: [dev] Re: [patch][dmenu] fix crash with ctrl-enter as input

2014-07-28 Thread Anselm R Garbe
On 28 July 2014 12:15, Hiltjo Posthuma wrote: > On Thu, Jul 24, 2014 at 9:41 PM, Hiltjo Posthuma > wrote: >> For clarification the commit that introduced this bug is >> 0d12a47415edba5db73f56dba76f123394581387: >> http://git.suckless.org/dmenu/commit/?id=0d12a47415edba5db73f56dba76f123394581387

[dev] Re: [patch][dmenu] fix crash with ctrl-enter as input

2014-07-28 Thread Hiltjo Posthuma
On Thu, Jul 24, 2014 at 9:41 PM, Hiltjo Posthuma wrote: > On Thu, Jul 24, 2014 at 7:22 PM, Hiltjo Posthuma > wrote: >> reproduce: ./dmenu; send EOF; press ctrl+enter. >> >> Attached is the patch. > > For clarification the commit that introduced this bug is > 0d12a47415edba5db73f56dba76f123394581