with the requested
depth rather than `infinity' by default.
* subversion/tests/cmdline/depth_tests.py
(update_excluded_path_sticky_depths): New test.
(info_excluded): Remove the locally imported module `re' and make it
globally available.
Suggested by: rhuijben
Patch by:
atch herewith.
[[[
Log:
Ensure the URLs are always canonical.
[ in subversion/libsvn_ra_neon ]
* util.c
(svn_ra_neon__request_get_location): Canonicalize the 'BASE URL' as
per the rule.
* props.c
(end_element): Same.
* options.c
(end_element): Same.
Found by: stsp
Suggested by: stsp, julianfoad
Patch b
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Kannan wrote:
[..]
> Thank you Philip/Bert for the feedback. Attaching an updated patch
> herewith as per Bert's comments.
>
Tweaking the log message.
> [[[
> Log:
> Make `--set-depth (empty|files|immediates) DIR' w
s `unknown'.
* subversion/libsvn_wc/entries.c
(take_from_entry): Set the default depth of the FILE (as
`infinity') had the file been excluded already.
* subversion/tests/cmdline/depth_tests.py
(test_list): Remove the XFail on `excluded_path_update_operation'.
Patch by: Kanna
bout the XFail that need to be updated/removed.
Thank you Philip, for the comments. I'll include this change too in the
next version of the patch.
>
>>excluded_path_misc_operation,
>>excluded_receive_remote_removal,
>>exclude_keeps_hidden_entries,
>>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Kannan wrote:
[..]
Attaching herewith is the updated patch, as per Philip's feedback.
[[[
Log:
Fix issue #3544 -- svn update does not restore excluded files.
* subversion/libsvn_wc/update_editor.c
(complete_directory): Call `svn_wc__set_
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Kannan wrote:
[..]
> [[[
> Log:
> Ensure the URLs are always canonical.
>
> [ in subversion/libsvn_ra_neon ]
>
> * util.c
> (svn_ra_neon__request_get_location): Canonicalize the 'BASE URL' as
>per the
he method where individual entries are obtained and
processed, so made the change there. (In the process of finding some
other place to make the change) please CMIIW. Thank you for the comments.
- --
Thanks & Regards,
Kannan
-BEGIN PGP SIGNATURE-
Versi
7;BASE URL' as
per the rule.
* props.c
(end_element): Same.
* options.c
(end_element): Same.
Found by: stsp
Suggested by: stsp, julianfoad
Patch by: Kannan R
]]]
- --
Thanks & Regards,
Kannan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG
pget').
[1]- http://www.collab.net/community/subversion/articles/merge-info.html
- --
Thanks & Regards,
Kannan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.moz
ts better to do the
canonicalization in just one place.
[[[
Log:
Follow-up r901797. Canonicalization of BASE URL doesn't reflect for
resources having parent info, till now.
* subversion/libsvn_ra_neon/props.c
(end_element): Canonicalize the BASE URL initially itself in order to
reflect the
ne place.
>
> No. (And there are several other places where the variable is used in
> that function, where the value it holds is something other than a URL.)
Yup, saw them after sending the mail :( Thank you Julian.
- --
Thanks & Regards,
Kannan
-BEGIN PGP SIG
nt info, till now.
* subversion/libsvn_ra_neon/props.c
(end_element): Canonicalize the BASE URL for elements having parent
info.
Patch by: Kannan R
Suggested by: julianfoad
]]]
- --
Thanks & Regards,
Kannan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuP
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Log:
Resolve some deprecation warnings using the new dirent/URI/path functions.
* subversion/svnlook/main.c
(print_dirs_changed_tree, print_changed_tree, print_diff_tree): Use
`svn_dirent_join()'.
Patch by: Kannan R
- --
Thanks &
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Log:
Resolve deprecation warnings in 'svnadmin', using the new
dirent/URI/path functions.
* subversion/svnadmin/main.c
(main): Use `svn_dirent_canonicalize()'.
(list_dblogs): Use `svn_dirent_join()'.
Patch by: Kannan R
-
a minor indentation fix.
[in subversion/libsvn_ra_neon]
* commit.c
(get_version_url, create_activity, commit_add_dir, commit_add_file
commit_close_file, add_child): Use `svn_path_url_add_component2()'.
(commit_delete_entry): Use `svn_path_url_add_component2()' and a minor
indenta
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Gavin 'Beau' Baumanis wrote:
> Hi Kannan,
>
> Ping! (Just in case it fell off your radar)
> I can't see this patch has been submitted nor has any more comments been made
> to it since Julian last asked about the outpu
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Julian Foad wrote:
>> If we're to use info_receiver_relpath_wrapper() and a baton to pass the
>> relative path and other info, won't it resemble the implementation(for
>> backward compatibility)which is at present?
>
&g
also make
error message compliant with that of the one in `svn merge'. Refer:
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=2417716
Patch by: Kannan R
- --
Thanks & Regards,
Kannan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Log:
* subversion/libsvn_fs_fs/structure
(): Fix typos.
Patch by: Kannan R
- --
Thanks & Regards,
Kannan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev
ditor, checkout_resource): Canonicalize the
> base before passing to `svn_path_url_add_component2()'.
>
> * props.c
> (svn_ra_neon__get_baseline_info): Canonicalize the base before passing
> to `svn_path_url_add_component2()'.
>
> Patch by: Kannan R
> ]]]
Juli
--
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2424621
>
> Please start new threads on the mailing list.
> To subscribe to the new list, send an empty e-mail to
> .
- --
Thanks & Regards,
Kan
abspath". If the variable needs to serve a dual purpose, please
> rename it to something like "source_abspath_or_url".
Sure, suggested on seeing the code snip. I'll look onto other such
..dirent_absolute() calls made on a URL and send a tested
patch.
()'.
(commit_delete_entry): Use `svn_path_url_add_component2()' and a minor
indentation fix in comment.
(svn_ra_neon__get_commit_editor, checkout_resource, apply_revprops):
Canonicalize the base before passing to
`svn_path_url_add_component2()'.
* props.c
(svn_ra_neon__get_baseline_info)
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Log:
Resolve a deprecation warning using the new dirent/URI/path functions.
* subversion/svn/checkout-cmd.c
(svn_cl__checkout): Use `svn_dirent_join()'.
Patch by: Kannan R
- --
Thanks & Regards,
Kannan
-BEGIN PGP SIGNATURE
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Stefan Sperling wrote:
> On Mon, Nov 30, 2009 at 08:28:19PM +0530, Kannan wrote:
>> @@ -518,7 +518,11 @@
>> _("Unable to parse URL '%s'"), locn);
>> }
>>
>>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Stefan Sperling wrote:
> On Mon, Nov 30, 2009 at 09:30:58PM +0530, Kannan wrote:
>> Stefan Sperling wrote:
>>>> @@ -773,7 +777,7 @@
>>>>
>>>> Note that we're not sending the locks in the If
lta.h
(svn_txdelta_skip_svndiff_window): Same.
* subversion/libsvn_fs_fs/fs_fs.c
(read_window): Same.
Found by: bhuvan
Patch by: Kannan R
[1]-http://hudson.zones.apache.org/hudson/job/subversion-trunk-solaris/lastBuild/console
- --
Thanks & Regards,
Kannan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1
th obtained and invoking `svn_dirent_get_absolute()' only if its a wc
path.
* subversion/libsvn_client/merge.c
(normalize_merge_sources): As above and rename the variable
`source_abspath' to `source_abspath_or_url' as it holds either a wc
abs-path or a url.
* subversi
er changes accordingly.
* merge.c
(normalize_merge_sources): Remove the redundant code.
* diff.c
(check_paths): Same.
* log.c
(svn_client_log5): Same.
* copy.c
(try_copy): Same.
Patch by: Kannan R
]]]
P.S: Part of the changes made in ra.c and merge.c, is also submitted in
[1]. This patch extend
tests.py 8: svn mergeinfo on pegged working copy target
>
> I think that means there are two more places where this mistake is made:
> in 'log.c' and in 'mergeinfo.c'. Would you be willing to fix those, too?
>
Sure, will give it a shot. Thank you
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Log:
Instead of using a separate bool variable, use `svn_path_is_url()'.
* subversion/libsvn_client/log.c
(svn_client_log5): Remove the bool variable `is_url' which is used only
once and substitute with `svn_path_is_url(path)'.
P
ethod. Sort of minor
tweak.
> Speaking for myself... it's clearly just a tiny code improvement. +1.
>
> I thin it is also more consistent with the way such checks are done in
> other svn_client functions.
Thank you.
- --
Thanks & Regards,
Kannan
-BEGIN PGP SIGNATURE---
x27; to `local_abspath_or_url' as it holds either
a WC abs-path or a URL.
Patch by: Kannan R
[1]-http://svn.apache.org/viewvc?rev=887187&view=rev
]]]
- --
Thanks & Regards,
Kannan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Usin
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Kannan wrote:
> Stefan Sperling wrote:
>> On Mon, Nov 30, 2009 at 09:30:58PM +0530, Kannan wrote:
>>> Stefan Sperling wrote:
>>>>> @@ -773,7 +777,7 @@
>>>>>
>>>>>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Julian Foad wrote:
[..]
>
> Or late tonight, in fact.
>
> It's a good patch. Committed revision 887469.
>
> Thank you, Kannan.
>
> I think that fixed the last of the URLs being passed to
> svn_dirent_get_absolute(
add_component2()'.
(svn_ra_neon__get_commit_editor, checkout_resource, apply_revprops):
Canonicalize the base before passing to
`svn_path_url_add_component2()'.
* props.c
(svn_ra_neon__get_baseline_info): Canonicalize the base before
passing to `svn_path_url_add_comp
anks & Regards,
Kannan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEVAwUBSx5PnXlTqcY7ytmIAQIw7AgArNtZbIQcJyjSsYcXxVIqkavh004hEcDv
kuN6Z3FFtuDmxbm/uSccdKB7a909iAuHuwNPKNP6/d8J2nt5qiN35nY//6oL/+bZ
passing to
`svn_path_url_add_component2()'.
* props.c
(svn_ra_neon__get_baseline_info): Canonicalize the base before
passing to `svn_path_url_add_component2()'.
Found and Suggested by: stsp
Patch by: Kannan R
[1]-http://mail-archives.apache.org/mod_mbox/subversion-dev/200912.m
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hyrum K. Wright wrote:
> On Dec 8, 2009, at 7:07 AM, Kannan wrote:
>
>> -BEGIN PGP SIGNED MESSAGE-
>> Hash: SHA1
>>
>> Hyrum K. Wright wrote:
>>> Any chance patch submissions can include [PATCH] in t
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Kannan wrote:
>
> As per discussion in the thread [1], attaching the patch herewith.
>
> Log:
> Make a proper fix to resolve some deprecation warnings using
> `svn_path_url_add_component2()' by canonicalizing the base before
e 'BASE' as
`svn_path_url_add_component2()' won't handle it.
* props.c
(svn_ra_neon__get_baseline_info, svn_ra_neon__get_one_prop): Same.
* options.c
(svn_ra_neon__exchange_capabilities): Same.
Found by: stsp
Suggested by: stsp,julianfoad
Patch by: Kannan R
]]]
- --
Thanks &
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Kannan wrote:
[..]
This patch upgrades ..add_component() to ..add_component2() which
depends on the previous uncommitted patch [1] to canonicalize the URLs.
[[[
Log:
Resolve some deprecation warnings.
* subversion/libsvn_ra_neon/commit.c
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Julian Foad wrote:
> I (Julian Foad) wrote:
>> Hi Kannan.
>>
>> I cannot process these patches at the moment, sorry. I hope somebody
>> else can.
>
> ... but I did have a quick scan through and they look right.
>
the check done using `svn_wc__db_node_hidden()' as it
marks a node as 'hidden' if status is set as
`svn_wc__db_status_excluded'.
Patch by: Kannan R
]]]
- --
Thanks & Regards,
Kannan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Commen
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Julian Foad wrote:
[..]
> Hi Kannan.
>
> With your patch, the code in "commit.c" now looks like this (ignoring
> all the error handling):
>
> do_checkout():
> ...
> *locn = svn_ra_neon__request_get_location(requ
ff-9abf-42ee-8860-a6a9630218e4/
>>
>> (which is generated by do_checkout() and parse.path value would be:
>>
>> /repos/devrepo/!svn/wrk/b4ec0dff-9abf-42ee-8860-a6a9630218e4/ )
>
> Thanks.
Thank you.
- --
Thanks & Regards,
Kannan
-BEGIN PGP SIGNATURE
on__request_get_location): Canonicalize the 'BASE URL' as
`svn_path_url_add_component2()' won't handle it.
* props.c
(svn_ra_neon__get_baseline_info, svn_ra_neon__get_one_prop): Same.
* options.c
(svn_ra_neon__exchange_capabilities): Same.
Found by: stsp
Suggested by
reason for this change is no longer
> specifically to do with svn_path_url_add_component2(), but rather to fix
> violations of our "URLs are canonical" rule.
Thank you Julian, will correct it the next time.
- --
Thanks & Regards,
Kannan
-BEGIN PGP SIGNATURE-
Version: GnuPG
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I (Kannan) wrote:
[..]
>>> (svn_ra_neon__exchange_capabilities): Same.
>> And this?
> Trying to find them out.
With regard to this change, AFAICS the `activity_collection' value is
set in `svn_ra_neon__request_dispatch
depths): s/treate/treat/
Patch by: Kannan R
- --
Thanks & Regards,
Kannan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEVAwUBSzHdBXlTqcY7ytmIAQLjcgf/SDkEdPKHSXuESKZgVdWMpz9F4Qd2ybma
6fvvawbBvPcamwCoi1KyFk
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Kannan wrote:
>
> Hi,
>
> As of now, after excluding a DIR using `--set-depth', for eg, `svn up
> --set-depth=exclude foo', its possible to redefine foo's depth only as
> infinity and not as (empty|files|immediates).
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Kannan wrote:
[..]
Attached herewith is the updated/corrected patch to perform the earlier
proposed functionality.
[[[
Log:
Make `--set-depth (empty|files|immediates) DIR' work, where DIR's depth
had already been set as `exclude'.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Tweaking the log message.
I (Kannan) wrote:
> Attached herewith is the updated/corrected patch to perform the earlier
> proposed functionality.
>
> [[[
> Log:
> Make `--set-depth (empty|files|immediates) DIR' work, where DI
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Wednesday 07 October 2009 04:17 PM, Kannan wrote:
> Stefan Sperling wrote:
>
>> Does this patch fix this case, too?
>
>
[..]
/me digs from the list of yet-to-be-committed patches.
[[[
Log:
While working on a wc of
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Thursday 29 July 2010 01:38 AM, Hyrum K. Wright wrote:
> Does this need to be fixed for serf too?
serf seems to hold good in this case, it was working fine even at the
time of submission of this initial patch.
- --
Thanks & Regards,
:
Export with `--native-eol' doesn't work for now unlike directory
externals.
* subversion/libsvn_client/externals.c
(handle_external_item_change): Make the `--native-eol' work for
export of file externals by passing the argument obtained, missed
in r96
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Tuesday 03 August 2010 02:34 AM, Kannan R wrote:
> On Monday 02 August 2010 11:15 PM, vijayaguru wrote:
>> Hi,
>
>> This is the follow up of issue reported in [1] . Export with
>> --native-eol option did not work wit
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Friday 06 August 2010 06:22 PM, Senthil Kumaran S wrote:
> Hi,
>
> Kannan R wrote:
>> On Wednesday 07 October 2009 04:17 PM, Kannan wrote:
>>> Stefan Sperling wrote:
>>
>>>> Does this patch fix this case,
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Friday 06 August 2010 06:25 PM, Senthil Kumaran S wrote:
> Hi Kannan,
>
> Kannan R wrote:
>> * props.c (svn_ra_neon__get_props) : Call
>> `svn_ra_neon__maybe_store_auth_info' to invoke 'store password
>> u
60 matches
Mail list logo
