-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Kannan wrote:
[..]
This patch upgrades ..add_component() to ..add_component2() which
depends on the previous uncommitted patch [1] to canonicalize the URLs.
[[[
Log:
Resolve some deprecation warnings.
* subversion/libsvn_ra_neon/commit.c
(get_version_url, create_activity, commit_add_dir, commit_add_file
commit_close_file, add_child, commit_delete_entry): Use
`svn_path_url_add_component2()'.
Patch by: Kannan R <[email protected]>
]]]
[1]-http://mail-archives.apache.org/mod_mbox/subversion-dev/200912.mbox/%[email protected]%3e
- --
Thanks & Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEVAwUBSysS6nlTqcY7ytmIAQKmdQf/XPF+FFIIapsA/XrO4X9yAmCp76gS1KpF
pMqhJomM1+o73Eijamg97tAwj0U7dlg1rQJx0bWdz772FsljWS0lhq/DTLIhD+FU
jyIjioU/GEMMVriFjscItCYxdd8VFgmx1/5Va22n/GLp36wAuSAGtCtpYsy6LU/s
75nvxpRpBR6IdHqwt8ZW/LDgwYgV5WQY2kFSBFm3NOsZeXHYZhHnCQc2cf+7lcl9
bT1b9IQ9RBrjwpG2UIYRMV0Hhlb3Nt/igoHprnHIjZ6QPPoPtxcN6mIVjm6Q8anP
ldMaLW8aGlCv03hsqxJLFyweL5TPXZE32A2j6osd/nKhoc6YdPdgvQ==
=XUL1
-----END PGP SIGNATURE-----
Index: subversion/libsvn_ra_neon/commit.c
===================================================================
--- subversion/libsvn_ra_neon/commit.c (revision 890793)
+++ subversion/libsvn_ra_neon/commit.c (working copy)
@@ -203,9 +203,9 @@
the version resource URL of RSRC. */
if (parent && parent->vsn_url && parent->revision == rsrc->revision)
{
- rsrc->vsn_url = svn_path_url_add_component(parent->vsn_url,
- rsrc->name,
- rsrc->pool);
+ rsrc->vsn_url = svn_path_url_add_component2(parent->vsn_url,
+ rsrc->name,
+ rsrc->pool);
return SVN_NO_ERROR;
}
@@ -231,7 +231,7 @@
rsrc->revision,
pool));
- url = svn_path_url_add_component(bc_url.data, bc_relative.data, pool);
+ url = svn_path_url_add_component2(bc_url.data, bc_relative.data, pool);
}
/* Get the DAV:checked-in property, which contains the URL of the
@@ -325,8 +325,8 @@
the activity, and create the activity. The URL for our activity
will be ACTIVITY_COLL/UUID */
SVN_ERR(get_activity_collection(cc, &activity_collection, FALSE, pool));
- url = svn_path_url_add_component(activity_collection->data,
- uuid_buf, pool);
+ url = svn_path_url_add_component2(activity_collection->data,
+ uuid_buf, pool);
SVN_ERR(svn_ra_neon__simple_request(&code, cc->ras,
"MKACTIVITY", url, NULL, NULL,
201 /* Created */,
@@ -338,8 +338,8 @@
if (code == 404)
{
SVN_ERR(get_activity_collection(cc, &activity_collection, TRUE, pool));
- url = svn_path_url_add_component(activity_collection->data,
- uuid_buf, pool);
+ url = svn_path_url_add_component2(activity_collection->data,
+ uuid_buf, pool);
SVN_ERR(svn_ra_neon__simple_request(&code, cc->ras,
"MKACTIVITY", url, NULL, NULL,
201, 0, pool));
@@ -373,7 +373,7 @@
rsrc->pool = pool;
rsrc->revision = revision;
rsrc->name = name;
- rsrc->url = svn_path_url_add_component(parent->url, name, pool);
+ rsrc->url = svn_path_url_add_component2(parent->url, name, pool);
rsrc->local_path = svn_path_join(parent->local_path, name, pool);
/* Case 1: the resource is truly "new". Either it was added as a
@@ -382,7 +382,7 @@
URL by the rules of deltaV: "copy structure is preserved below
the WR you COPY to." */
if (created || (parent->vsn_url == NULL))
- rsrc->wr_url = svn_path_url_add_component(parent->wr_url, name, pool);
+ rsrc->wr_url = svn_path_url_add_component2(parent->wr_url, name, pool);
/* Case 2: the resource is already under version-control somewhere.
This means it has a VR URL already, and the WR URL won't exist
@@ -714,7 +714,7 @@
SVN_ERR(checkout_resource(parent->cc, parent->rsrc, TRUE, NULL, pool));
/* create the URL for the child resource */
- child = svn_path_url_add_component(parent->rsrc->wr_url, name, pool);
+ child = svn_path_url_add_component2(parent->rsrc->wr_url, name, pool);
/* Start out assuming that we're deleting a file; try to lookup the
path itself in the token-hash, and if found, attach it to the If:
@@ -729,8 +729,8 @@
const char *token_header_val;
const char *token_uri;
- token_uri = svn_path_url_add_component(parent->cc->ras->url->data,
- path, pool);
+ token_uri = svn_path_url_add_component2(parent->cc->ras->url->data,
+ path, pool);
token_header_val = apr_psprintf(pool, "<%s> (<%s>)",
token_uri, token);
extra_headers = apr_hash_make(pool);
@@ -888,9 +888,9 @@
"source" argument to the COPY request. The "Destination:"
header given to COPY is simply the wr_url that is already
part of the child object. */
- copy_src = svn_path_url_add_component(bc_url.data,
- bc_relative.data,
- workpool);
+ copy_src = svn_path_url_add_component2(bc_url.data,
+ bc_relative.data,
+ workpool);
/* Have neon do the COPY. */
SVN_ERR(svn_ra_neon__copy(parent->cc->ras,
@@ -1088,9 +1088,9 @@
"source" argument to the COPY request. The "Destination:"
header given to COPY is simply the wr_url that is already
part of the file_baton. */
- copy_src = svn_path_url_add_component(bc_url.data,
- bc_relative.data,
- workpool);
+ copy_src = svn_path_url_add_component2(bc_url.data,
+ bc_relative.data,
+ workpool);
/* Have neon do the COPY. */
SVN_ERR(svn_ra_neon__copy(parent->cc->ras,
@@ -1271,9 +1271,9 @@
svn_ra_neon__set_header
(extra_headers, "If",
apr_psprintf(pool, "<%s> (<%s>)",
- svn_path_url_add_component(cc->ras->url->data,
- file->rsrc->url,
- request->pool),
+ svn_path_url_add_component2(cc->ras->url->data,
+ file->rsrc->url,
+ request->pool),
file->token));
if (pb->base_checksum)