-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Wednesday 07 October 2009 04:17 PM, Kannan wrote:
> Stefan Sperling wrote:
>
>> Does this patch fix this case, too?
>
>
[..]
/me digs from the list of yet-to-be-committed patches.
[[[
Log:
While working on a wc of a repo which needs authentication, 'store
password unencrypted' prompt is getting invoked only for those svn
commands that access the repo URL or that have an URL as argument
(eg. svn ls http://localhost/repo) and not for wc oriented commands
such as `svn ls' or `svn cat -r 5 test.c' which also require
authentication. The prompt gets invoked for the rest of the commands
which need repo access, with the following patch.
[ in subversion/libsvn_ra_neon ]
* props.c
(svn_ra_neon__get_props) : Call
`svn_ra_neon__maybe_store_auth_info' to invoke 'store
password unencrypted' prompt.
* commit.c
* fetch.c
* session.c
Remove redundant invocations of the above method.
]]]
- --
Thanks & Regards,
Kannan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJMUG51AAoJELQAaYkQr+e7t9UIAK3/u+9DzgRifCZawitsWbRr
yLjBWMdZM58SbNziWVRVwAIyvjd2uIT0+5hHaRe3xD9V9QR/GKe1Wss2goJXwy9I
1Ofer7XLTRe1f5p8BeeP2bvWiT7Mbb7IGfjo8weQP16ViF0j1O/LJCYUOjvMax9R
xmCN8P1ZlEl+qaxOEoRyTZZQFo93iibS1GgvhBdxBoZf8qk+Hp8GF+Fpxu+P/o1x
6S1EAWunUQgPjz8r+XN5sy2QYOEv0iYP1yFISigIFk55B+vI4RTDNCdvwiDpRaor
vKzJayxhDAhfvtJ45IYB1gNlrzB9znYAgecWAki9lqkv08l5D8hn2FbMBdINlSM=
=n8SW
-----END PGP SIGNATURE-----
Index: subversion/libsvn_ra_neon/props.c
===================================================================
--- subversion/libsvn_ra_neon/props.c (revision 966749)
+++ subversion/libsvn_ra_neon/props.c (working copy)
@@ -556,6 +556,7 @@
&pc, extra_headers, NULL, FALSE, pool));
*results = pc.props;
+ SVN_ERR(svn_ra_neon__maybe_store_auth_info(sess, pool));
return SVN_NO_ERROR;
}
Index: subversion/libsvn_ra_neon/commit.c
===================================================================
--- subversion/libsvn_ra_neon/commit.c (revision 966749)
+++ subversion/libsvn_ra_neon/commit.c (working copy)
@@ -1355,7 +1355,6 @@
cc->disable_merge_response,
pool));
SVN_ERR(delete_activity(edit_baton, pool));
- SVN_ERR(svn_ra_neon__maybe_store_auth_info(cc->ras, pool));
if (commit_info->revision != SVN_INVALID_REVNUM)
SVN_ERR(cc->callback(commit_info, cc->callback_baton, pool));
Index: subversion/libsvn_ra_neon/fetch.c
===================================================================
--- subversion/libsvn_ra_neon/fetch.c (revision 966749)
+++ subversion/libsvn_ra_neon/fetch.c (working copy)
@@ -1111,7 +1111,6 @@
ras, ras->root.path,
SVN_INVALID_REVNUM, pool));
}
- SVN_ERR(svn_ra_neon__maybe_store_auth_info(ras, pool));
return NULL;
}
@@ -2439,8 +2438,7 @@
_("REPORT response handling failed to complete the editor drive"));
}
- /* store auth info if we can. */
- return svn_ra_neon__maybe_store_auth_info(rb->ras, pool);
+ return SVN_NO_ERROR;
}
static const svn_ra_reporter3_t ra_neon_reporter = {
Index: subversion/libsvn_ra_neon/session.c
===================================================================
--- subversion/libsvn_ra_neon/session.c (revision 966749)
+++ subversion/libsvn_ra_neon/session.c (working copy)
@@ -1170,7 +1170,6 @@
SVN_ERR(svn_ra_neon__search_for_starting_props(&rsrc, &lopped_path,
ras, ras->url->data,
pool));
- SVN_ERR(svn_ra_neon__maybe_store_auth_info(ras, pool));
if (! ras->uuid)
{
