On 3 March 2015 at 01:26, wrote:
> Author: rhuijben
> Date: Mon Mar 2 22:26:07 2015
> New Revision: 1663450
>
> URL: http://svn.apache.org/r1663450
> Log:
> Following up on r1658194, fix removing tokens from the tokens cache.
> Just passing the token to svn_hash_sets() didn't work any more.
>
>
> -Original Message-
> From: Ivan Zhakov [mailto:i...@visualsvn.com]
> Sent: dinsdag 3 maart 2015 11:03
> To: dev@subversion.apache.org; Bert Huijben
> Subject: Re: svn commit: r1663450 -
> /subversion/trunk/subversion/libsvn_ra_svn/editorp.c
>
> On 3 March 2015 at 01:26, wrote:
> > Au
Evgeny Kotkov wrote:
> 1) Currently we allow changing 'svn:check-ood' and 'svn:check-locks'. We also
> silently discard a property change whenever it targets 'svn:client-date'.
> I find the first part questionable, because we basically allow a caller to
> mess with our private implementat
>>> URL: http://svn.apache.org/r1663450
>>> Log:
>>> Following up on r1658194, fix removing tokens from the tokens cache.
>>> Just passing the token to svn_hash_sets() didn't work any more.
Thinking about how to prevent a repeat of the same kind of error, defining
svn_hash_sets and svn_hash_gets
Daniel Shahaf wrote:
> Patch to add the project logo to the top-left of generated doxygen
> pages. Not sure what are the consequences of using a logo larger than
> 200x55 pixels, so won't commit it for now.
+1. Go ahead and commit it. I tried it locally and it looks nice in my version
of Firefox
Evgeny Kotkov writes:
>I propose that we solve this part of the problem with the attached patch.
>Please note that while preparing this patch, I also unveiled that the
>SVN_FS_TXN_CLIENT_DATE flag might not work as expected with BDB.
>I think we should fix this with a separate pat
On 3 March 2015 at 14:17, Julian Foad wrote:
URL: http://svn.apache.org/r1663450
>
Log:
Following up on r1658194, fix removing tokens from the tokens cache.
Just passing the token to svn_hash_sets() didn't work any more.
>
> Thinking about how to prevent a repeat of the same ki
Philip Martin wrote:
> [...] Both BDB and FSFS set the date on the txn when the txn is
> created. This was introduced so that admins could look at the date and
> get the txn creation date which is useful when deciding whether or not
> to delete old txns. The BDB bug is that this setting should
Julian Foad writes:
>> Using svn:date to store txn creation date doesnt't work so well now that
>> we allow clients to set svn:date. It might have been better if the txn
>> creation date was stored in a separate txn property that was deleted on
>> commit. If we were to do that then we would nee
Evgeny Kotkov writes:
> 1) Exploit the BDB problem with SVN_FS_TXN_CLIENT_DATE not working as
> expected in a separate test. Probably, I am also going to create an
> issue, because without a fix we'd be shipping Subversion 1.9 with a
> new transaction flag that doesn't work properly on every FS
On Tue, Mar 3, 2015 at 12:17 PM, Julian Foad
wrote:
> >>> URL: http://svn.apache.org/r1663450
>
> >>> Log:
> >>> Following up on r1658194, fix removing tokens from the tokens cache.
> >>> Just passing the token to svn_hash_sets() didn't work any more.
>
My bad.
Talked about the leak on IRC last
[Switching back to plain text]
Stefan Fuhrmann wrote:
> Julian Foad wrote:
>> Thinking about how to prevent a repeat of the same kind of error,
>> defining svn_hash_sets and svn_hash_gets as functions with prototypes
>> would result in at least a compiler warning (for typical configurations).
>
>
On Tue, Mar 3, 2015 at 5:19 PM, Julian Foad
wrote:
> [Switching back to plain text]
>
> Stefan Fuhrmann wrote:
> > Julian Foad wrote:
> >> Thinking about how to prevent a repeat of the same kind of error,
> >> defining svn_hash_sets and svn_hash_gets as functions with prototypes
> >> would result
> -Original Message-
> From: kot...@apache.org [mailto:kot...@apache.org]
> Sent: dinsdag 3 maart 2015 17:44
> To: comm...@subversion.apache.org
> Subject: svn commit: r1663738 - in /subversion/trunk/subversion: libsvn_fs/fs-
> loader.c tests/cmdline/svnlook_tests.py tests/libsvn_fs/fs-te
Stefan Fuhrmann wrote:
> Julian Foad wrote:
>> #define svn_hash_sets(ht, key, val) \
>> do { \
>> const char *svn_hash__key = (key); \
>> apr_hash_set(ht, svn_hash__key, APR_HA
"Bert Huijben" writes:
>> -Original Message-
>> From: kot...@apache.org [mailto:kot...@apache.org]
>> Sent: dinsdag 3 maart 2015 17:44
>> To: comm...@subversion.apache.org
>> Subject: svn commit: r1663738 - in /subversion/trunk/subversion:
>> libsvn_fs/fs-
>> loader.c tests/cmdline/svnlo
Philip Martin writes:
> We could change the unreleased svn:client-date to something like
> svn:txn:client-date, and use svn:txn: for any others added in future.
> CHECK_OOD has never been implemented so could be deprecated, leaving
> only CHECK_LOCKS outside svn:txn:.
A complication is that colo
On Tue, Mar 3, 2015 at 7:10 PM, Julian Foad
wrote:
> Stefan Fuhrmann wrote:
> > Julian Foad wrote:
> >> #define svn_hash_sets(ht, key, val) \
> >> do { \
> >> const char *svn_hash__key = (key);
On 03.03.2015 19:10, Julian Foad wrote:
> Stefan Fuhrmann wrote:
>> Julian Foad wrote:
>>> #define svn_hash_sets(ht, key, val) \
>>> do { \
>>> const char *svn_hash__key = (key); \
julianf...@apache.org wrote on Tue, Mar 03, 2015 at 18:09:32 -:
> Author: julianfoad
> Date: Tue Mar 3 18:09:32 2015
> New Revision: 1663760
>
> URL: http://svn.apache.org/r1663760
> Log:
> Redefine the svn_hash_gets and svn_hash_sets macros in a way that allows for
> parameter type checking,
Julian Foad wrote on Tue, Mar 03, 2015 at 11:57:26 +:
> Daniel Shahaf wrote:
> > Patch to add the project logo to the top-left of generated doxygen
> > pages. Not sure what are the consequences of using a logo larger than
> > 200x55 pixels, so won't commit it for now.
>
> +1. Go ahead and com
Evgeny Kotkov writes:
> Okay, here is what I am about to do:
>
> 1) Exploit the BDB problem with SVN_FS_TXN_CLIENT_DATE not working as
>expected in a separate test. Probably, I am also going to create an
>issue, because without a fix we'd be shipping Subversion 1.9 with a
>new transa
Bert Huijben writes:
>> Don't expose internal transaction properties like 'svn:check-locks' through
>> the public FS API and error out on attempts to change them.
>
> I wish it would be possible to put these in their own property namespace,
> to avoid those list of properties to check against...
Philip Martin wrote on Tue, Mar 03, 2015 at 18:24:15 +:
> Philip Martin writes:
>
> > We could change the unreleased svn:client-date to something like
> > svn:txn:client-date, and use svn:txn: for any others added in future.
> > CHECK_OOD has never been implemented so could be deprecated, lea
Evgeny Kotkov wrote on Wed, Mar 04, 2015 at 04:42:58 +0300:
> Bert Huijben writes:
>
> >> Don't expose internal transaction properties like 'svn:check-locks' through
> >> the public FS API and error out on attempts to change them.
> >
> > I wish it would be possible to put these in their own prop
On 02.03.2015 20:55, minf...@apache.org wrote:
> Author: minfrin
> Date: Mon Mar 2 19:55:11 2015
> New Revision: 1663412
>
> URL: http://svn.apache.org/r1663412
> Log:
> mod_dav_svn: add expression support for templates in SVNPath and
> SVNParentPath.
Hi Graham,
Thanks!
FYI, we have a bit of a
26 matches
Mail list logo
