"Bert Huijben" <b...@qqmail.nl> writes: >> -----Original Message----- >> From: kot...@apache.org [mailto:kot...@apache.org] >> Sent: dinsdag 3 maart 2015 17:44 >> To: comm...@subversion.apache.org >> Subject: svn commit: r1663738 - in /subversion/trunk/subversion: >> libsvn_fs/fs- >> loader.c tests/cmdline/svnlook_tests.py tests/libsvn_fs/fs-test.c >> >> Author: kotkov >> Date: Tue Mar 3 16:43:39 2015 >> New Revision: 1663738 >> >> URL: http://svn.apache.org/r1663738 >> Log: >> Don't expose internal transaction properties like 'svn:check-locks' through >> the public FS API and error out on attempts to change them. > > I wish it would be possible to put these in their own property > namespace, to avoid those list of properties to check against... > > But that is not really possible any more, is it?
The symbols are private to the FS layer, defined in libsvn_fs/fs-loader.h, but they are stored on disk so effectively it would be changing the on-disk format. If we changed the definition then creating a txn with one library version and committing it with another would silently do the wrong thing. I don't suppose that happens very often, but I guess it is supposed to work. We could change the unreleased svn:client-date to something like svn:txn:client-date, and use svn:txn: for any others added in future. CHECK_OOD has never been implemented so could be deprecated, leaving only CHECK_LOCKS outside svn:txn:. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*
