Julian Foad wrote on Tue, Mar 03, 2015 at 11:57:26 +0000: > Daniel Shahaf wrote: > > Patch to add the project logo to the top-left of generated doxygen > > pages. Not sure what are the consequences of using a logo larger than > > 200x55 pixels, so won't commit it for now. > > +1. Go ahead and commit it. I tried it locally and it looks nice in my > version of Firefox and a quick look at the HTML doesn't indicate there > will be any problem, and it's hardly a disaster if we have to change > or revert it later. >
Fair enough. Committed as r1663837. > > If adding a file external is a problem, it would be straightforward to > > avoid that by using 'svn cat ^/subversion/site/...' in the 'doc' > > Makefile target; the trade-off is requiring an Internet connection and > > an svn binary to be available. > > I can't think of a problem with using the external. If it doesn't work in > production, we can change it. > > > > > (To test it, > > ... put the patch in a file; patch up the whitespace to use a tab > after the filenames and a space at the beginning of context lines; The tabs and whitespace are correct in the copy I received from the list. Perhaps your MUA ate the whitespace? Thanks, Daniel
