Svn Commit and unlock notifications

2012-09-04 Thread Markus Schaber
Hi, When svn_wc_notify_func2 is called with notify->action == svn_wc_notify_commit_modified, the field notify->lock_state is set to svn_wc_notify_lock_state_unknown (value 1) instead of svn_wc_notify_lock_state_unlocked. There also is no further notification that the lock is removed, the svn

Re: Svn Commit and unlock notifications

2012-09-04 Thread Philip Martin
Markus Schaber writes: > My current workaround is that my code memorizes all the pathes where a > svn_wc_notify_commit_XXX notifications occurs, and after the commit > operation has finished successfully, it assumes all those pathes have > been unlocked. > > Can someone confirm that this will cat

Problems with updating external files

2012-09-04 Thread Maciej Jaros
Hi. I'm having problems with updating bundles (make `svn update` on root). I was using Tortoise and received an error, but I also tried a command line version and I got: Fetching external item into 'index.php': svn: warning: W160016: Failure opening '/main/trunk/index.php/index.php' Updating

RE: Svn Commit and unlock notifications

2012-09-04 Thread Bert Huijben
> -Original Message- > From: Markus Schaber [mailto:m.scha...@3s-software.com] > Sent: dinsdag 4 september 2012 10:38 > To: Subversion Dev (dev@subversion.apache.org) > Subject: Svn Commit and unlock notifications > > Hi, > > When svn_wc_notify_func2 is called with notify->action == > s

Re: svn commit: r1379689 - in /subversion/trunk/subversion/libsvn_subr: deprecated.c opt.c opt.h

2012-09-04 Thread Branko Čibej
On 01.09.2012 23:41, Daniel Shahaf wrote: > Branko Čibej wrote on Sat, Sep 01, 2012 at 06:55:40 +0200: >> On 01.09.2012 06:48, br...@apache.org wrote: >>> Author: brane >>> Date: Sat Sep 1 04:48:26 2012 >>> New Revision: 1379689 >>> >>> URL: http://svn.apache.org/viewvc?rev=1379689&view=rev >>> Lo

AW: Svn Commit and unlock notifications

2012-09-04 Thread Markus Schaber
Hi, Von: Markus Schaber [mailto:m.scha...@3s-software.com] > > When svn_wc_notify_func2 is called with notify->action == > svn_wc_notify_commit_modified, the field notify->lock_state is set to > svn_wc_notify_lock_state_unknown (value 1) instead of > svn_wc_notify_lock_state_unlocked. > > There

AW: Svn Commit and unlock notifications

2012-09-04 Thread Markus Schaber
Hi, Bert, Von: Bert Huijben [mailto:b...@qqmail.nl] > From: Markus Schaber [mailto:m.scha...@3s-software.com] > > > > Hi, > > > > When svn_wc_notify_func2 is called with notify->action == > > svn_wc_notify_commit_modified, the field notify->lock_state is set to > > svn_wc_notify_lock_state_unknown

Re: dev digest is getting worse

2012-09-04 Thread Daniel Shahaf
Simon Large wrote on Tue, Sep 04, 2012 at 13:24:18 +0100: > Hi guys, > > Please could you forward this to infra as I could not see any direct > way to contact on the apache site. > Just email infrastruct...@apache.org. (you might be asked to file a ticket if a concrete problem is identified) T

Re: [PATCH] SVN 1.7 and 1.8 generates extra header when diffing with external tool

2012-09-04 Thread Stefan Sperling
On Fri, Aug 31, 2012 at 03:24:18PM -0700, Alexey Neyman wrote: > Hi SVN developers, > > I noticed an issue which prevents the 'post-review' tool from ReviewBoard > (http://www.reviewboard.org) from working with Subversion 1.7.x and trunk > (1.8.0-dev). > > This post-review tool uses external di

[PATCH]: Encoding fix mailer.py

2012-09-04 Thread Igor Galić
Hey folks, I've patched up my local mailer.py[1] to correctly encode "From: " Headers. The attached patch *works* but it's not pretty. Someone who actually knows Python might want to encapsulate my changes in a function. n.b.: I am not subscribed to this ML, if you want notify me of updates, pl

Re: thread safe

2012-09-04 Thread Stefan Küng
On 03.09.2012 22:21, Branko Čibej wrote: On 03.09.2012 22:16, Stefan Küng wrote: On 03.09.2012 22:11, Branko Čibej wrote: Either that, or add a new API that creates a deep-copy of the in-memory svn_config_t structure, making this another way to avoid re-reading the config file for each thread a

Re: [PATCH] SVN 1.7 and 1.8 generates extra header when diffing with external tool

2012-09-04 Thread Alexey Neyman
Could somebody confirm this issue and/or apply the patch? If the patch is accepted, could it be applied to 1.7.x branch as well? Thanks, Alexey. On Friday, August 31, 2012 03:24:18 pm Alexey Neyman wrote: > Hi SVN developers, > > I noticed an issue which prevents the 'post-review' tool from Rev

Re: svn commit: r1379689 - in /subversion/trunk/subversion/libsvn_subr: deprecated.c opt.c opt.h

2012-09-04 Thread Daniel Shahaf
Branko Čibej wrote on Tue, Sep 04, 2012 at 13:24:42 +0200: > On 01.09.2012 23:41, Daniel Shahaf wrote: > > Branko Čibej wrote on Sat, Sep 01, 2012 at 06:55:40 +0200: > >> On 01.09.2012 06:48, br...@apache.org wrote: > >>> Author: brane > >>> Date: Sat Sep 1 04:48:26 2012 > >>> New Revision: 137968

RE: thread safe

2012-09-04 Thread Bert Huijben
That function performs a shallow copy. It doesn't know how to duplicate the referenced values or keys. (And the config is inside something like a multilevel hash) Bert Huijben (Cell phone) From: Stefan Küng Sent: 4-9-2012 19:33 To: dev@subversion.apache.org Subject: Re: thread safe On 03.09.2012 2

Re: svn commit: r1380311 - /subversion/trunk/build/generator/templates/svn_locale.vcxproj.ezt

2012-09-04 Thread Роман Донченко
Bert Huijben писал в своём письме Tue, 04 Sep 2012 04:22:46 +0400: -Original Message- From: rdo...@apache.org [mailto:rdo...@apache.org] Sent: maandag 3 september 2012 21:19 To: comm...@subversion.apache.org Subject: svn commit: r1380311 - /subversion/trunk/build/generator/template

Re: thread safe

2012-09-04 Thread Branko Čibej
On 04.09.2012 19:33, Stefan Küng wrote: > On 03.09.2012 22:21, Branko Čibej wrote: >> On 03.09.2012 22:16, Stefan Küng wrote: >>> On 03.09.2012 22:11, Branko Čibej wrote: Either that, or add a new API that creates a deep-copy of the in-memory svn_config_t structure, making this anoth

Re: thread safe

2012-09-04 Thread Stefan Küng
On 04.09.2012 20:31, Branko Čibej wrote: On 04.09.2012 19:33, Stefan Küng wrote: On 03.09.2012 22:21, Branko Čibej wrote: On 03.09.2012 22:16, Stefan Küng wrote: On 03.09.2012 22:11, Branko Čibej wrote: Either that, or add a new API that creates a deep-copy of the in-memory svn_config_t struc

Re: svn commit: r1357313 - in /subversion/trunk/subversion/svn: cl.h notify.c update-cmd.c

2012-09-04 Thread Paul Burba
On Wed, Jul 4, 2012 at 11:40 AM, wrote: > Author: stsp > Date: Wed Jul 4 15:40:59 2012 > New Revision: 1357313 > > URL: http://svn.apache.org/viewvc?rev=1357313&view=rev > Log: > When running the conflict resolver at the end of an 'svn update' operation, > resolve conflicts only on paths which g

Re: Segfault in HEAD client code.

2012-09-04 Thread Paul Burba
On Fri, Aug 31, 2012 at 9:29 PM, C. Michael Pilato wrote: > I'm getting an intermittent segfault using a HEAD trunk client against the > same pedigree of mod_dav_svn server. Reproduction is straightforward: > >rm -rf wc >time -p svn co http://localhost/repos/subversion/trunk wc >time

Re: thread safe

2012-09-04 Thread Branko Čibej
On 04.09.2012 20:42, Stefan Küng wrote: > Seems I got confused here: > What we have to pass to almost each svn API is the config hash for the > svn_client_ctx_t struct. That's what I need a copy of. The svn_config_* functions work with svn_config_t object. The tmp_key and tmp_value fields in those

Re: thread safe

2012-09-04 Thread Stefan Küng
On 04.09.2012 21:07, Branko Čibej wrote: On 04.09.2012 20:42, Stefan Küng wrote: Seems I got confused here: What we have to pass to almost each svn API is the config hash for the svn_client_ctx_t struct. That's what I need a copy of. The svn_config_* functions work with svn_config_t object. Th

Re: svn commit: r1380311 - /subversion/trunk/build/generator/templates/svn_locale.vcxproj.ezt

2012-09-04 Thread Роман Донченко
Branko Čibej писал в своём письме Tue, 04 Sep 2012 22:42:05 +0400: Generating for Visual Studio 2012 Ah. I thought the fix was obvious because the presence of the NMake*CommandLine elements indicates it ought to be a Makefile project (cf. zlib.vcxproj.ezt); but if you think I'm oversteppi

Re: thread safe

2012-09-04 Thread Branko Čibej
On 04.09.2012 21:14, Stefan Küng wrote: > On 04.09.2012 21:07, Branko Čibej wrote: >> On 04.09.2012 20:42, Stefan Küng wrote: >>> Seems I got confused here: >>> What we have to pass to almost each svn API is the config hash for the >>> svn_client_ctx_t struct. That's what I need a copy of. >> >> Th

Re: Segfault in HEAD client code.

2012-09-04 Thread C. Michael Pilato
On 09/04/2012 03:03 PM, Paul Burba wrote: > On Fri, Aug 31, 2012 at 9:29 PM, C. Michael Pilato > wrote: >> I'm getting an intermittent segfault using a HEAD trunk client against the >> same pedigree of mod_dav_svn server. Reproduction is straightforward: [...] > Mike - Sounds like what I'm see

Consolidating private/svn_subr_private.h

2012-09-04 Thread Stefan Fuhrmann
Hi there, While looking for the appropriate place to declare a few svn-private constants, I realized that libsvn_subr is the only lib that comes with multiple private headers. So, I prepared a patch that moves all their content into private/svn_subr_private.h with two exceptions: svn_sqlite.h an

Re: thread safe

2012-09-04 Thread Stefan Küng
Attached is my first draft of the new svn_config_dup() API. * it does not return an svn_error_t but the duplicate hash directly. The only API call that could return an error is svn_config_create() but that API also returns SVN_NO_ERROR unconditionally (for now at least). * no error checking is

Re: Consolidating private/svn_subr_private.h

2012-09-04 Thread Greg Stein
Go for it! +1 On Tue, Sep 4, 2012 at 4:03 PM, Stefan Fuhrmann wrote: > Hi there, > > While looking for the appropriate place to declare a few > svn-private constants, I realized that libsvn_subr is the > only lib that comes with multiple private headers. > > So, I prepared a patch that moves all

Re: svn commit: r1380608 - in /subversion/trunk/subversion: include/ libsvn_ra_local/ libsvn_repos/ mod_dav_svn/ svnserve/

2012-09-04 Thread Daniel Shahaf
s...@apache.org wrote on Tue, Sep 04, 2012 at 12:43:41 -: > Author: stsp > Date: Tue Sep 4 12:43:40 2012 > New Revision: 1380608 > > URL: http://svn.apache.org/viewvc?rev=1380608&view=rev > Log: > Fix issue #4113, "convert SVNHooksEnv and svnserve.conf[hooks-env] to > use a common configurati

Re: Consolidating private/svn_subr_private.h

2012-09-04 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Tue, Sep 04, 2012 at 22:03:54 +0200: > Hi there, > > While looking for the appropriate place to declare a few > svn-private constants, I realized that libsvn_subr is the > only lib that comes with multiple private headers. > Why is that a problem?

Re: Consolidating private/svn_subr_private.h

2012-09-04 Thread Branko Čibej
On 04.09.2012 23:46, Daniel Shahaf wrote: > Stefan Fuhrmann wrote on Tue, Sep 04, 2012 at 22:03:54 +0200: >> Hi there, >> >> While looking for the appropriate place to declare a few >> svn-private constants, I realized that libsvn_subr is the >> only lib that comes with multiple private headers. >>

Re: thread safe

2012-09-04 Thread Branko Čibej
On 04.09.2012 22:24, Stefan Küng wrote: > Attached is my first draft of the new svn_config_dup() API. > > * it does not return an svn_error_t but the duplicate hash directly. > The only API call that could return an error is svn_config_create() > but that API also returns SVN_NO_ERROR unconditional

RE: Consolidating private/svn_subr_private.h

2012-09-04 Thread Bert Huijben
> -Original Message- > From: Branko Čibej [mailto:br...@wandisco.com] > Sent: woensdag 5 september 2012 00:57 > To: dev@subversion.apache.org > Subject: Re: Consolidating private/svn_subr_private.h > > On 04.09.2012 23:46, Daniel Shahaf wrote: > > Stefan Fuhrmann wrote on Tue, Sep 04, 20

Re: Consolidating private/svn_subr_private.h

2012-09-04 Thread Greg Stein
On Sep 4, 2012 5:47 PM, "Daniel Shahaf" wrote: > > Stefan Fuhrmann wrote on Tue, Sep 04, 2012 at 22:03:54 +0200: > > Hi there, > > > > While looking for the appropriate place to declare a few > > svn-private constants, I realized that libsvn_subr is the > > only lib that comes with multiple privat

Re: [PATCH] SVN 1.7 and 1.8 generates extra header when diffing with external tool

2012-09-04 Thread Alexey Neyman
On Tuesday, September 04, 2012 05:56:27 PM Stefan Sperling wrote: > On Fri, Aug 31, 2012 at 03:24:18PM -0700, Alexey Neyman wrote: > > Hi SVN developers, > > > > I noticed an issue which prevents the 'post-review' tool from ReviewBoard > > (http://www.reviewboard.org) from working with Subversion