> -----Original Message-----
> From: Branko Čibej [mailto:br...@wandisco.com]
> Sent: woensdag 5 september 2012 00:57
> To: dev@subversion.apache.org
> Subject: Re: Consolidating private/svn_subr_private.h
> 
> On 04.09.2012 23:46, Daniel Shahaf wrote:
> > Stefan Fuhrmann wrote on Tue, Sep 04, 2012 at 22:03:54 +0200:
> >> Hi there,
> >>
> >> While looking for the appropriate place to declare a few
> >> svn-private constants, I realized that libsvn_subr is the
> >> only lib that comes with multiple private headers.
> >>
> > Why is that a problem?
> 
> svn_subr contains several quite separate submodules. I think it would be
> a mistake to stuff the declarations into a single private header.

+1

E.g. things like the private fs_path, cache, string and cmdline api are much 
cleaner in their own targeted header file than in a single shared 
svn_subr_private.h.

        Bert
> 
> -- Brane
> 
> --
> Certified & Supported Apache Subversion Downloads:
> http://www.wandisco.com/subversion/download


Reply via email to