Re: [PATCH] Fix deprecation warnings in svnadmin

2009-11-27 Thread Senthil Kumaran S
Kannan wrote: > Log: > Resolve deprecation warnings in 'svnadmin', using the new > dirent/URI/path functions. > > * subversion/svnadmin/main.c > (main): Use `svn_dirent_canonicalize()'. > (list_dblogs): Use `svn_dirent_join()'. > > Patch by: Kannan R Committed in r884792. Thank You. -- Sent

Re: [PATCH] Race condition in svnsync can wedge a mirror repository

2009-11-27 Thread Stefan Sperling
On Wed, Nov 25, 2009 at 07:28:22PM +, Philip Martin wrote: > "Jon Foster" writes: > > > A patch is attached. The patch is against 1.6.6. I've tried to > > keep the changes minimal, because I think this might be a candidate > > for a Subversion 1.6.7 patch release. > > A minimal patch is so

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Senthil Kumaran S
Hi, Bhuvaneswaran A wrote: > Did we discuss about correcting old revisions pointing to svn.collab.net > repository referenced in log messages? Like this one: > $ svn log -r r880575 This is my first attempt at ctypes-python bindings for subversion :) The attached script will do the above. I plan t

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Branko Čibej
Senthil Kumaran S wrote: > Hi, > > Bhuvaneswaran A wrote: > >> Did we discuss about correcting old revisions pointing to svn.collab.net >> repository referenced in log messages? Like this one: >> $ svn log -r r880575 >> > > This is my first attempt at ctypes-python bindings for subversion :

Re: [PATCH] Race condition in svnsync can wedge a mirror repository

2009-11-27 Thread Philip Martin
Stefan Sperling writes: > What about the patch below? > > [[[ > * subversion/svnsync/main.c > (get_lock): The lock attempt is done in iteration N, and success is >checked in iteration N+1. Prevent the case where svnsync attempts >to take the lock in the very last iteration, doesn't chec

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Senthil Kumaran S
Hi Brane, Branko Čibej wrote: > Here's a hint for compliance with the Python coding standards: > > --- log_revnum_change_asf.py 2009-11-27 11:21:44.930709595 +0100 > +++ log_revnum_change_asf.py 2009-11-27 11:22:59.490693784 +0100 > @@ -16,19 +16,20 @@ > #specific language governing permis

Re: svn propchange: r880575 - svn:log

2009-11-27 Thread Senthil Kumaran S
style...@apache.org wrote: > Author: stylesen > Revision: 880575 > Modified property: svn:log > > Modified: svn:log at Fri Nov 27 10:03:23 2009 > -- > (empty) Sorry for the noise! I was testing a script committed in r

RE: [PATCH] Race condition in svnsync can wedge a mirror repository

2009-11-27 Thread Jon Foster
Hi, Stefan Sperling wrote: > What about the patch below? I've tested this, and it fixes the problem. Thanks! Kind regards, Jon ** This email and its attachments may be confidential and are intended solely for the use of the

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Bhuvaneswaran A
On Fri, 2009-11-27 at 15:40 +0530, Senthil Kumaran S wrote: > Hi, > > Bhuvaneswaran A wrote: > > Did we discuss about correcting old revisions pointing to svn.collab.net > > repository referenced in log messages? Like this one: > > $ svn log -r r880575 > > This is my first attempt at ctypes-pytho

Re: [PATCH] Race condition in svnsync can wedge a mirror repository

2009-11-27 Thread Stefan Sperling
On Fri, Nov 27, 2009 at 11:04:26AM +, Philip Martin wrote: > Stefan Sperling writes: > > > What about the patch below? > > > > [[[ > > * subversion/svnsync/main.c > > (get_lock): The lock attempt is done in iteration N, and success is > >checked in iteration N+1. Prevent the case where

Access to the commit mailing list

2009-11-27 Thread Patrick Mayweg
Hi, is there a specific reason, why I am not allowed on the apache commits mailing list? I have been on the collab.net commits for a long time. Regards, Patrick -- Qint Software GmbH Fichtenstr. 19 82110 Germering +49 89 89026749 Sitz: München HRB 117326 Geschäftsführer: Hans Marggraff, Patrick

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Stefan Sperling
On Fri, Nov 27, 2009 at 05:04:42PM +0530, Bhuvaneswaran A wrote: > a) I don't know if the new revisions are sequential. The difference > between last revision in the import (r880588) and HEAD (r836420) is > 44168. It does not match with the last revision (r40515) committed in > svn.collab.net repos

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Senthil Kumaran S
Bhuvaneswaran A wrote: > a) I don't know if the new revisions are sequential. The difference > between last revision in the import (r880588) and HEAD (r836420) is > 44168. It does not match with the last revision (r40515) committed in > svn.collab.net repository. IOW, I don't think we are sure that

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Konstantin Kolinko
2009/11/27 Senthil Kumaran S : > > Already ran a test on r880575 and the script did what it was supposed to do. > How about preserving the old numbers as well (e.g. in brackets)? I also see that, e.g. in http://svn.apache.org/repos/asf/subversion/trunk/CHANGES when several revision numbers are me

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread 25033.76511
On 27.11.2009 11:10, Senthil Kumaran S wrote: Hi, Bhuvaneswaran A wrote: Did we discuss about correcting old revisions pointing to svn.collab.net repository referenced in log messages? Like this one: $ svn log -r r880575 This is my first attempt at ctypes-python bindings for subversion :) The

RE: [PATCH] Race condition in svnsync can wedge a mirror repository

2009-11-27 Thread Jon Foster
Hi, Stefan Sperling wrote: > OK, I will commit it. Thankyou. > There is a much worse race condition, however. Yep, your mail arrived whilst I was testing this race condition in a debugger. I can confirm it's a real bug. But for me, the biggest problem with svnsync's locking right now is that

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Senthil Kumaran S
Konstantin Kolinko wrote: > 2009/11/27 Senthil Kumaran S : >> Already ran a test on r880575 and the script did what it was supposed to do. >> > > How about preserving the old numbers as well (e.g. in brackets)? > > I also see that, e.g. in > http://svn.apache.org/repos/asf/subversion/trunk/CHANGE

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Senthil Kumaran S
25033.76511 wrote: > I would suggest to preserve the old revision numbers, for instance like > r123456[r54321]. > Who knows if we might need them again some day. I like this idea. Lets go with this. -- Senthil Kumaran S http://www.stylesen.org/

Re: [PATCH] Race condition in svnsync can wedge a mirror repository

2009-11-27 Thread Stefan Sperling
On Fri, Nov 27, 2009 at 12:57:09PM -, Jon Foster wrote: > Stefan Sperling wrote: > > There is a much worse race condition, however. > > Yep, your mail arrived whilst I was testing this race condition in > a debugger. I can confirm it's a real bug. > > But for me, the biggest problem with svn

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Hyrum K. Wright
On Nov 27, 2009, at 6:52 AM, 25033.76511 wrote: > On 27.11.2009 11:10, Senthil Kumaran S wrote: >> Hi, >> >> Bhuvaneswaran A wrote: >>> Did we discuss about correcting old revisions pointing to svn.collab.net >>> repository referenced in log messages? Like this one: >>> $ svn log -r r880575 >>

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Stefan Sperling
On Fri, Nov 27, 2009 at 06:36:42PM +0530, Senthil Kumaran S wrote: > 25033.76511 wrote: > > I would suggest to preserve the old revision numbers, for instance like > > r123456[r54321]. > > Who knows if we might need them again some day. > > I like this idea. Lets go with this. I don't think it's

Re: [PATCH] Race condition in svnsync can wedge a mirror repository

2009-11-27 Thread Philip Martin
Stefan Sperling writes: >> Would it be reasonable to add a "--local-lock-file FILENAME" option >> to svnsync, which would turn off the current locking and use file >> locking instead? If so, I can work on a patch to do this. > > I think we need an approach that also works over the network. Netw

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Bhuvaneswaran A
On Fri, 2009-11-27 at 18:06 +0530, Senthil Kumaran S wrote: > > b) If we decide that we should fix those revisions and while we run > the > > script to fix, we should disable post-revprop-change script to avoid > > sending 1000s of prop change emails to commits@ list. > > Yes this is a concern, sh

RE: [PATCH] Race condition in svnsync can wedge a mirror repository

2009-11-27 Thread Jon Foster
Hi, Stefan Sperling wrote: > You can use tools like lockf or lockfile (part of procmail) for that. Thankyou, I didn't know that existed. That saves me the hassle of writing and testing my own locking code. > But it only works if the synsync processes run on the host where the > target repositor

Re: [PATCH] Race condition in svnsync can wedge a mirror repository

2009-11-27 Thread Stefan Sperling
On Fri, Nov 27, 2009 at 01:53:31PM -, Jon Foster wrote: > > But it only works if the synsync processes run on the host where the > > target repository is located (i.e. you have to run synsync pulls from > > a cronjob on the mirror, rather than triggering svnsync pushes from > > a post-commit ho

Re: [PATCH] Race condition in svnsync can wedge a mirror repository

2009-11-27 Thread Stefan Sperling
On Fri, Nov 27, 2009 at 01:42:58PM +, Philip Martin wrote: > Stefan Sperling writes: > > >> Would it be reasonable to add a "--local-lock-file FILENAME" option > >> to svnsync, which would turn off the current locking and use file > >> locking instead? If so, I can work on a patch to do this

Re: Access to the commit mailing list

2009-11-27 Thread Mark Phippard
On Fri, Nov 27, 2009 at 6:59 AM, Patrick Mayweg wrote: > is there a specific reason, why I am not allowed on the apache commits > mailing list? > I have been on the collab.net commits for a long time. Are you saying you attempted to subscribe to the list but couldn't? The ASF does not allow us t

[PATCH] (trivial) Stray blank line in svnsync --help sync

2009-11-27 Thread Jon Foster
Hi, While adding a new option, I noticed what appears to be a stray blank line in the "svnsync --help sync" output. 2-character patch is attached. [[[ * subversion/svnsync/main.c (svnsync_options): Remove stray newline after --config-option help text. Patch by: Jon Foster ]]] Kind regards,

Re: fixing old revisions referenced in log messages ...

2009-11-27 Thread Julian Foad
On Fri, 2009-11-27 at 18:36 +0530, Senthil Kumaran S wrote: > Konstantin Kolinko wrote: > > 2009/11/27 Senthil Kumaran S : > >> Already ran a test on r880575 and the script did what it was supposed to > >> do. > >> > > > > How about preserving the old numbers as well (e.g. in brackets)? > > > >

Re: [PATCH] (trivial) Stray blank line in svnsync --help sync

2009-11-27 Thread Julian Foad
On Fri, 2009-11-27 at 15:39 +, Jon Foster wrote: > * subversion/svnsync/main.c > (svnsync_options): Remove stray newline after --config-option help > text. > > Patch by: Jon Foster I think you forgot to attach the patch, but I won't waste 2KB of email traffic asking you to re-send those 2

Re: An analysis of possible tree conflicts during update

2009-11-27 Thread Julian Foad
Daniel Näslund wrote: > I'm trying to sort out the different tree conflict scenarios for a > possible tree conflict resolver as described in #3144 [1]. Thanks for this. This is just to let you know I see your email, but I won't get around to digesting it and replying today. - Julian

[PATCH] Add svnsync --use-external-locking option

2009-11-27 Thread Jon Foster
Hi, As discussed on this list, we don't always need svnsync's networked lock. If svnsync only runs on a single server, the administrator can use the "flock" tool to prevent running multiple copies of svnsync at the same time. And if svnsync's lock is not needed, then it is actually an inconvenie

RE: [PATCH] Add svnsync --use-external-locking option

2009-11-27 Thread Jon Foster
[Sorry, my mailserver appears to be dropping attachments today. Trying again, with patch inline at end of the mail] Hi, As discussed on this list, we don't always need svnsync's networked lock. If svnsync only runs on a single server, the administrator can use the "flock" tool to prevent runnin

Fix a build issue with finding apr-config for ctypesgen

2009-11-27 Thread Julian Foad
I built ctypes-python for the first time today. It didn't pick up my "apr" and "apr-util" locations automatically, and this patch fixes that. [[[ Fix a problem in the automatic finding of 'apr-1-config' by 'make ctypes-python'. * build/ac-macros/apr.m4 (SVN_LIB_APR): Set the 'SVN_APR_CONFIG' su

Re: Error in abs-path handling in normalize_merge_sources()

2009-11-27 Thread Kannan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julian Foad wrote: >> I spotted an error in the conversion to use abs-paths: >> >> [[[ >> static svn_error_t * >> normalize_merge_sources(apr_array_header_t **merge_sources_p, > [...] >> SVN_ERR(svn_dirent_get_absolute(&source_abspath, source, pool))

Re: Error in abs-path handling in normalize_merge_sources()

2009-11-27 Thread Julian Foad
On Fri, 2009-11-27 at 23:25 +0530, Kannan wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Julian Foad wrote: > >> I spotted an error in the conversion to use abs-paths: > >> > >> [[[ > >> static svn_error_t * > >> normalize_merge_sources(apr_array_header_t **merge_sources_p, > > [...]

Re: Error in abs-path handling in normalize_merge_sources()

2009-11-27 Thread Julian Foad
On Fri, 2009-11-27 at 18:45 +, Julian Foad wrote: > On Fri, 2009-11-27 at 23:25 +0530, Kannan wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > Julian Foad wrote: > > >> I spotted an error in the conversion to use abs-paths: > > >> > > >> [[[ > > >> static svn_error_t * > >

Re: Error in abs-path handling in normalize_merge_sources()

2009-11-27 Thread Kannan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julian Foad wrote: > Oh yes, so you did. However, that patch you initially proposed there > passed a part of the URL to svn_dirent_get_absolute(), which is not > right either. Yes, then I had a different patch altogether. >>> I suggest adding >>> >>