Re: [PATCH] Re: svn commit: r1141447 - /subversion/branches/svn-bisect/BRANCH-MILESTONES

2011-07-03 Thread Arwin Arni
into the "branch-readme" file. Also attached is the log message. Since I am working on this branch, I checked out the branch and started working on it. Hence this patch is with respect to the *svn-bisect* branch. Thanks and regards Prabhu Thanks Prabhu.. Committed revision 1142557.

[PATCH] Re: svn commit: r1141447 - /subversion/branches/svn-bisect/BRANCH-MILESTONES

2011-07-01 Thread Prabhu Gnana Sundar
e log message. Since I am working on this branch, I checked out the branch and started working on it. Hence this patch is with respect to the *svn-bisect* branch. Thanks and regards Prabhu Index: BRANCH-README === --- BRANCH-RE

Re: svn commit: r1141447 - /subversion/branches/svn-bisect/BRANCH-MILESTONES

2011-06-30 Thread C. Michael Pilato
On 06/30/2011 04:58 AM, ar...@apache.org wrote: > Author: arwin > Date: Thu Jun 30 08:58:11 2011 > New Revision: 1141447 > > URL: http://svn.apache.org/viewvc?rev=1141447&view=rev > Log: > Added branch milestones document. > * BRANCH-MILESTONES : New file. Why a second branch-specific file? Put

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-29 Thread Daniel Shahaf
FWIW, my assumption has been that translation from one programming language to another might not suffice to disconnect the link to the original (GPL'd) work. But we're off-topic (and hypothetical) by now. Greg Stein wrote on Wed, Jun 29, 2011 at 06:31:36 -0400: > On Tue, Jun 28, 2011 at 11:24, Hy

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-29 Thread Daniel Shahaf
es: > >>> > >>>>On Tue, Jun 28, 2011 at 03:12:22PM +0530, Arwin Arni wrote: > >>>> > >>>>>On Tuesday 28 June 2011 03:01 PM, Noorul Islam K M wrote: > >>>>>>>+svn bisect start [-rN[:M]] > >>>>>&g

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-29 Thread Greg Stein
On Tue, Jun 28, 2011 at 08:37, Arwin Arni wrote: >... > check for mixed rev, switched subtrees and local mods and error out if it > is. > Initialize the bisect env. This should be pretty simple. If I recall correctly, there is a wc_db API that queries this information for the 'svnversion' program

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-29 Thread Greg Stein
On Tue, Jun 28, 2011 at 11:24, Hyrum K Wright wrote: > On Tue, Jun 28, 2011 at 10:16 AM, Daniel Shahaf > wrote: >> [ Haven't read the whole thread yet, quick response only to this sentence ] >> >> Peter Samuelson wrote on Tue, Jun 28, 2011 at 10:11:45 -0500: >>> This is why you should read the e

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-29 Thread Arwin Arni
, Noorul Islam K M wrote: +svn bisect start [-rN[:M]] + When we discussed you had a concern that above syntax is different from the normal svn sub command syntax. Is this finalized? I wouldn't say it's finalized.. I simply wrote down a spec as a rough draft. I'm sure the community

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Daniel Shahaf
ched subtrees > > > 3) the working copy is at a uniform revision > > > > > >These are also enforced by merge --reintegrate. > > > > > >I think 1 and 2 are very important for a clean bisection. > > >The third one is not really necessary if svn bis

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Peter Samuelson
end up with similar code somewhere. But it would be hard to imagine any of the literal text of a shell script winding up verbatim in a C library implementation. As for the documentation, if there were any point in borrowing anything from my svn-bisect.1, I note it was 100% written by me, is _not_ GP

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Daniel Shahaf
> >>>I wouldn't say it's finalized.. I simply wrote down a spec as a rough > >>>draft. > >>>I'm sure the community will have some ideas about this. (Like implementing > >>>a sub-subcommand interface of some sort.) > >>I

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Daniel Shahaf
Hyrum K Wright wrote on Tue, Jun 28, 2011 at 10:24:29 -0500: > On Tue, Jun 28, 2011 at 10:16 AM, Daniel Shahaf > wrote: > > [ Haven't read the whole thread yet, quick response only to this sentence ] > > > > Peter Samuelson wrote on Tue, Jun 28, 2011 at 10:11:45 -0500: > >> This is why you should

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Hyrum K Wright
On Tue, Jun 28, 2011 at 10:16 AM, Daniel Shahaf wrote: > [ Haven't read the whole thread yet, quick response only to this sentence ] > > Peter Samuelson wrote on Tue, Jun 28, 2011 at 10:11:45 -0500: >> This is why you should read the existing third-party implementations. > > I believe some third-p

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Daniel Shahaf
[ Haven't read the whole thread yet, quick response only to this sentence ] Peter Samuelson wrote on Tue, Jun 28, 2011 at 10:11:45 -0500: > This is why you should read the existing third-party implementations. I believe some third-party implementations are GPL'd --- meaning that we can't borrow c

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Peter Samuelson
Whoa! Didn't think of this at all. Will keep this in mind. This is why you should read the existing third-party implementations. We thought of it. (: For example, svn://svn.debian.org/pkg-subversion/src/1.7.x/debian/bin/svn-bisect svn://svn.debian.org/pkg-subversion/src/1.7.x/debia

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Stefan Sperling
On Tue, Jun 28, 2011 at 06:07:00PM +0530, Arwin Arni wrote: > Considering all these points,it should work this way: > > svn bisect --start -rN:M > > check for mixed rev, switched subtrees and local mods and error out > if it is. > Initialize the bisect env. > &

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Arwin Arni
uniform revision These are also enforced by merge --reintegrate. I think 1 and 2 are very important for a clean bisection. The third one is not really necessary if svn bisect run will always run an update first. Thank's for bringing this up.. I actually considered 1 and 3. Completely overloo

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Stefan Sperling
t; >These are also enforced by merge --reintegrate. > > > >I think 1 and 2 are very important for a clean bisection. > >The third one is not really necessary if svn bisect run will always > >run an update first. > > > > Thank's for bringing this up.. I ac

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Arwin Arni
On Tuesday 28 June 2011 03:36 PM, Noorul Islam K M wrote: Stefan Sperling writes: On Tue, Jun 28, 2011 at 03:12:22PM +0530, Arwin Arni wrote: On Tuesday 28 June 2011 03:01 PM, Noorul Islam K M wrote: +svn bisect start [-rN[:M]] + When we discussed you had a concern that above syntax is

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Arwin Arni
On Tuesday 28 June 2011 03:32 PM, Stefan Sperling wrote: On Tue, Jun 28, 2011 at 03:12:22PM +0530, Arwin Arni wrote: On Tuesday 28 June 2011 03:01 PM, Noorul Islam K M wrote: +svn bisect start [-rN[:M]] + When we discussed you had a concern that above syntax is different from the normal svn

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Noorul Islam K M
Stefan Sperling writes: > On Tue, Jun 28, 2011 at 03:12:22PM +0530, Arwin Arni wrote: > >> On Tuesday 28 June 2011 03:01 PM, Noorul Islam K M wrote: >> >>+svn bisect start [-rN[:M]] >> >>+ >> >When we discussed you had a concern that above syntax is

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Arwin Arni
New file. Added: subversion/branches/svn-bisect/BRANCH-README Hi Arwin, +SPEC + + +svn bisect start [-rN[:M]] + +Initialize the bisection state. +If a state already exists, clean it up and create a fresh one. +If a revision range is specified, limit bisection to this range. +If a si

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Stefan Sperling
On Tue, Jun 28, 2011 at 03:12:22PM +0530, Arwin Arni wrote: > On Tuesday 28 June 2011 03:01 PM, Noorul Islam K M wrote: > >>+svn bisect start [-rN[:M]] > >>+ > >When we discussed you had a concern that above syntax is different from > >the normal svn sub

[Arwin Arni] Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Noorul Islam K M
g/viewvc?rev=1140482&view=rev >> Log: >> Added a branch readme. >> * BRANCH-README : New file. >> >> Added: >> subversion/branches/svn-bisect/BRANCH-README >> >> Added: subversion/branches/svn-bisect/BRANCH-README >> URL: >

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Stefan Sperling
; Added: > subversion/branches/svn-bisect/BRANCH-README Hi Arwin, > > +SPEC > + > + > +svn bisect start [-rN[:M]] > + > +Initialize the bisection state. > +If a state already exists, clean it up and create a fresh one. > +If a revision range is specified, lim

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Noorul Islam K M
ar...@apache.org writes: > Author: arwin > Date: Tue Jun 28 08:43:40 2011 > New Revision: 1140482 > > URL: http://svn.apache.org/viewvc?rev=1140482&view=rev > Log: > Added a branch readme. > * BRANCH-README : New file. > > Added: > subversion/branch

Re: svn bisect

2011-06-21 Thread Arwin Arni
eature or don't use a ubiquitously understood value. Definitely adding support for svn bisect skip. :) So, I'm all in favor of adding bisect one way or another. Bye, Erik.'

Re: svn bisect

2011-06-21 Thread Erik Huelsmann
Hi Arwin, On Tue, Jun 21, 2011 at 9:45 AM, Arwin Arni wrote: > 3. Will this feature be considered at all (if it is any good) or am I simply > doing something to exercise my brain cells? Actually, I think it'd be a good idea to have a standardized command to have where all clients work alike. W

Re: svn bisect

2011-06-21 Thread Daniel Shahaf
t; > > > There are already THREE scripts out there that implement cmdline 'svn > > > > bisect': > > > > one on CPAN, one in Peter's Debian package, one that Julian just posted. > > > > (And we got one sent to the issue tracker a while ago, bu

Re: svn bisect

2011-06-21 Thread Daniel Shahaf
Stefan Sperling wrote on Tue, Jun 21, 2011 at 10:29:24 +0200: > On Tue, Jun 21, 2011 at 01:15:06PM +0530, Arwin Arni wrote: > > Hi All, > > > > I am currently trying to implement "svn bisect" subcommand. Yes, I > > know there are some good scripts out there th

Re: svn bisect

2011-06-21 Thread Arwin Arni
already THREE scripts out there that implement cmdline 'svn bisect': one on CPAN, one in Peter's Debian package, one that Julian just posted. (And we got one sent to the issue tracker a while ago, but the CPAN one was more featureful) Wouldn't having it as a part of our API improv

Re: svn bisect

2011-06-21 Thread Stefan Sperling
t; > > There are already THREE scripts out there that implement cmdline 'svn > > > bisect': > > > one on CPAN, one in Peter's Debian package, one that Julian just posted. > > > (And we got one sent to the issue tracker a while ago, but the CPAN

Re: svn bisect

2011-06-21 Thread Daniel Shahaf
Stefan Sperling wrote on Tue, Jun 21, 2011 at 11:34:46 +0200: > On Tue, Jun 21, 2011 at 12:21:27PM +0300, Daniel Shahaf wrote: > > Please convince me why having svn_client_bisect() is needed. > > > > There are already THREE scripts out there that implement cmdline 'sv

Re: svn bisect

2011-06-21 Thread Julian Foad
gt; There are already THREE scripts out there that implement cmdline 'svn > >> bisect': > >> one on CPAN, one in Peter's Debian package, one that Julian just posted. > >> (And we got one sent to the issue tracker a while ago, but the CPAN one > >> was

Re: svn bisect

2011-06-21 Thread Johan Corveleyn
On Tue, Jun 21, 2011 at 11:34 AM, Arwin Arni wrote: > On Tuesday 21 June 2011 02:51 PM, Daniel Shahaf wrote: >> >> Please convince me why having svn_client_bisect() is needed. >> >> There are already THREE scripts out there that implement cmdline 'svn >> b

Re: svn bisect

2011-06-21 Thread Stefan Sperling
On Tue, Jun 21, 2011 at 12:21:27PM +0300, Daniel Shahaf wrote: > Please convince me why having svn_client_bisect() is needed. > > There are already THREE scripts out there that implement cmdline 'svn bisect': > one on CPAN, one in Peter's Debian package, one that Julian

Re: svn bisect

2011-06-21 Thread Arwin Arni
On Tuesday 21 June 2011 02:51 PM, Daniel Shahaf wrote: Please convince me why having svn_client_bisect() is needed. There are already THREE scripts out there that implement cmdline 'svn bisect': one on CPAN, one in Peter's Debian package, one that Julian just posted. (And we got

Re: svn bisect

2011-06-21 Thread Daniel Shahaf
Please convince me why having svn_client_bisect() is needed. There are already THREE scripts out there that implement cmdline 'svn bisect': one on CPAN, one in Peter's Debian package, one that Julian just posted. (And we got one sent to the issue tracker a while ago, but the CP

Re: svn bisect

2011-06-21 Thread Stefan Sperling
On Tue, Jun 21, 2011 at 02:40:10PM +0530, Arwin Arni wrote: > On Tuesday 21 June 2011 02:35 PM, Stefan Sperling wrote: > >On Tue, Jun 21, 2011 at 02:26:28PM +0530, Arwin Arni wrote: > >>>Stefan Sperling wrote: > I'd like to offer you commit access to a branch in our repository > so you work

Re: svn bisect

2011-06-21 Thread Arwin Arni
On Tuesday 21 June 2011 02:35 PM, Stefan Sperling wrote: On Tue, Jun 21, 2011 at 02:26:28PM +0530, Arwin Arni wrote: Stefan Sperling wrote: I'd like to offer you commit access to a branch in our repository so you work on this there if you like. I'd really appreciate that. Thanks for the suppor

Re: svn bisect

2011-06-21 Thread Stefan Sperling
On Tue, Jun 21, 2011 at 02:26:28PM +0530, Arwin Arni wrote: > >Stefan Sperling wrote: > >>I'd like to offer you commit access to a branch in our repository > >>so you work on this there if you like. > I'd really appreciate that. Thanks for the support. Good, I'll fire off an account request. Do yo

Re: svn bisect

2011-06-21 Thread Stefan Sperling
On Tue, Jun 21, 2011 at 10:00:40AM +0100, Julian Foad wrote: > My patch retrieves the list of operative revisions on the specified > subtree, and binary-searches through that list, not through all possible > revision numbers. Nice. I didn't read it thoroughly enough so :-)

Re: svn bisect

2011-06-21 Thread Julian Foad
Stefan Sperling wrote: > On Tue, Jun 21, 2011 at 09:35:54AM +0100, Julian Foad wrote: > > Here's one I wrote a few months back. I didn't send it here because I > > didn't think it was a serious proposition, just something fun to > > exercise my brain cells. :-) > > > > One thing "git bisect" doe

Re: svn bisect

2011-06-21 Thread Arwin Arni
plemented here is to support a third response, "unable to test", and skip such revisions. I tried thinking about an algorithm to do that nicely, but didn't get anywhere really concrete. - Julian Stefan Sperling wrote: On Tue, Jun 21, 2011 at 01:15:06PM +0530, Arwin Arni wrote: Hi

Re: svn bisect

2011-06-21 Thread Stefan Sperling
On Tue, Jun 21, 2011 at 09:35:54AM +0100, Julian Foad wrote: > Here's one I wrote a few months back. I didn't send it here because I > didn't think it was a serious proposition, just something fun to > exercise my brain cells. :-) > > One thing "git bisect" does that's not implemented here is to

Re: svn bisect

2011-06-21 Thread Julian Foad
e to test", and skip such revisions. I tried thinking about an algorithm to do that nicely, but didn't get anywhere really concrete. - Julian Stefan Sperling wrote: > On Tue, Jun 21, 2011 at 01:15:06PM +0530, Arwin Arni wrote: > > Hi All, > > > > I am currently tryi

Re: svn bisect

2011-06-21 Thread Stefan Sperling
On Tue, Jun 21, 2011 at 01:15:06PM +0530, Arwin Arni wrote: > Hi All, > > I am currently trying to implement "svn bisect" subcommand. Yes, I > know there are some good scripts out there that work, but it's not > part of our API. I figured this would be a decent addi

svn bisect

2011-06-21 Thread Arwin Arni
Hi All, I am currently trying to implement "svn bisect" subcommand. Yes, I know there are some good scripts out there that work, but it's not part of our API. I figured this would be a decent addition to our code. Here are a few things I wanted to ask the community: 1. Would