Re: svn commit: r881265 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

2009-11-17 Thread Philip Martin
[sending again due to an email configuration problem] Stefan Sperling writes: > I don't have the time to look deeper into it right now, and would > appreciate if someone could investigate. To reproduce the crash, > follow the steps outlined in issue #3530 and remove the NULL check > added in the

Re: svn commit: r881265 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

2009-11-17 Thread Philip Martin
Stefan Sperling writes: > I don't have the time to look deeper into it right now, and would > appreciate if someone could investigate. To reproduce the crash, > follow the steps outlined in issue #3530 and remove the NULL check > added in the above commit. r879744 took out the code that opened t

Re: svn commit: r881265 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

2009-11-17 Thread Philip Martin
"Hyrum K. Wright" writes: > On Nov 17, 2009, at 7:54 AM, Philip Martin wrote: > >> s...@apache.org writes: [...] >>> svn_wc_adm_access_t *adm_access = >>> svn_wc__adm_retrieve_internal2(db, local_abspath, iterpool); >>> >>> -SVN_ERR(svn_wc__adm_destroy(adm_access, ite

Re: svn commit: r881265 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

2009-11-17 Thread Stefan Sperling
On Tue, Nov 17, 2009 at 01:54:29PM +, Philip Martin wrote: > s...@apache.org writes: > > > Author: stsp > > Date: Tue Nov 17 13:11:04 2009 > > New Revision: 881265 > > > > URL: http://svn.apache.org/viewvc?rev=881265&view=rev > > Log: > > * subversion/libsvn_wc/adm_ops.c > > (svn_wc__interna

Re: svn commit: r881265 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

2009-11-17 Thread Hyrum K. Wright
On Nov 17, 2009, at 8:26 AM, Philip Martin wrote: > "Hyrum K. Wright" writes: > >> On Nov 17, 2009, at 7:54 AM, Philip Martin wrote: >> >>> s...@apache.org writes: > [...] svn_wc_adm_access_t *adm_access = svn_wc__adm_retrieve_internal2(db, local_abspath, iterpool);

Re: svn commit: r881265 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

2009-11-17 Thread Hyrum K. Wright
On Nov 17, 2009, at 7:54 AM, Philip Martin wrote: > s...@apache.org writes: > >> Author: stsp >> Date: Tue Nov 17 13:11:04 2009 >> New Revision: 881265 >> >> URL: http://svn.apache.org/viewvc?rev=881265&view=rev >> Log: >> * subversion/libsvn_wc/adm_ops.c >> (svn_wc__internal_remove_from_revis

Re: svn commit: r881265 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

2009-11-17 Thread Philip Martin
s...@apache.org writes: > Author: stsp > Date: Tue Nov 17 13:11:04 2009 > New Revision: 881265 > > URL: http://svn.apache.org/viewvc?rev=881265&view=rev > Log: > * subversion/libsvn_wc/adm_ops.c > (svn_wc__internal_remove_from_revision_control): Don't try to destroy >a NULL adm_access. Fixes