On Nov 17, 2009, at 7:54 AM, Philip Martin wrote: > s...@apache.org writes: > >> Author: stsp >> Date: Tue Nov 17 13:11:04 2009 >> New Revision: 881265 >> >> URL: http://svn.apache.org/viewvc?rev=881265&view=rev >> Log: >> * subversion/libsvn_wc/adm_ops.c >> (svn_wc__internal_remove_from_revision_control): Don't try to destroy >> a NULL adm_access. Fixes core dump observed when changing the scheme >> of an external's URL from https:// to http:// and trying to update. >> >> Modified: >> subversion/trunk/subversion/libsvn_wc/adm_ops.c >> >> Modified: subversion/trunk/subversion/libsvn_wc/adm_ops.c >> URL: >> http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/adm_ops.c?rev=881265&r1=881264&r2=881265&view=diff >> ============================================================================== >> --- subversion/trunk/subversion/libsvn_wc/adm_ops.c (original) >> +++ subversion/trunk/subversion/libsvn_wc/adm_ops.c Tue Nov 17 13:11:04 2009 >> @@ -2532,7 +2532,8 @@ >> svn_wc_adm_access_t *adm_access = >> svn_wc__adm_retrieve_internal2(db, local_abspath, iterpool); >> >> - SVN_ERR(svn_wc__adm_destroy(adm_access, iterpool)); >> + if (adm_access) >> + SVN_ERR(svn_wc__adm_destroy(adm_access, iterpool)); >> } >> > > Why is it NULL? Has the directory not been opened? Is the wrong name > being used in the retrieve? Not getting an access baton when one is > expected should really be an error, not something that simply gets > ignored. I suppose this code is going to get removed in wc-ng, but > it doesn't look right.
Not having looked at the file, even that snippet of context looks goofy: "retrieve a baton, then close it, doing nothing with it in the interim." -Hyrum
