"Hyrum K. Wright" <hyrum_wri...@mail.utexas.edu> writes: > On Nov 17, 2009, at 7:54 AM, Philip Martin wrote: > >> s...@apache.org writes: [...] >>> svn_wc_adm_access_t *adm_access = >>> svn_wc__adm_retrieve_internal2(db, local_abspath, iterpool); >>> >>> - SVN_ERR(svn_wc__adm_destroy(adm_access, iterpool)); >>> + if (adm_access) >>> + SVN_ERR(svn_wc__adm_destroy(adm_access, iterpool)); >>> } >>> >> >> Why is it NULL? Has the directory not been opened? Is the wrong name >> being used in the retrieve? Not getting an access baton when one is >> expected should really be an error, not something that simply gets >> ignored. I suppose this code is going to get removed in wc-ng, but >> it doesn't look right. > > Not having looked at the file, even that snippet of context looks goofy: > "retrieve a baton, then close it, doing nothing with it in the interim."
svn_wc__adm_destroy is not "close" it's "delete the .svn directory" -- Philip
