Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

Stefan Fuhrmann writes: [...] > r1686554 removes the intermedite source repo locking layer. You may try > reverting the remainder r1589284, resolve the conflicts and review the > result. If you then still think that the resulting patch is an > improvement, by all means commit it. I reverted the

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

On Fri, Jun 19, 2015 at 8:37 PM, Evgeny Kotkov wrote: > Stefan Fuhrmann writes: > > > Well, it "works" based on SVN's concept of OS-side readonlyness. > > svnadmin_tests.py 51 passes on Windows. > > Did you try the test after doing 'svn merge -c-r1686232'? I tried this on > both > Windows and U

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

Stefan Fuhrmann writes: > Well, it "works" based on SVN's concept of OS-side readonlyness. > svnadmin_tests.py 51 passes on Windows. Did you try the test after doing 'svn merge -c-r1686232'? I tried this on both Windows and Unix, and the test passed, so it's testing something else than the disc

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

On Fri, Jun 19, 2015 at 2:26 PM, Evgeny Kotkov wrote: > Stefan Fuhrmann writes: > > > And the regression should be fixed. > > [...] > > > There is a trivial fix: Try to acquire the lock and fall back to the > > non-locking behavior if you get an EACCESS. The nicer way is to check > > beforehand

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

Stefan Fuhrmann writes: > And the regression should be fixed. [...] > There is a trivial fix: Try to acquire the lock and fall back to the > non-locking behavior if you get an EACCESS. The nicer way is to check > beforehand and make the check slightly more generic. That's what I did in > r16862

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

On Thu, Jun 18, 2015 at 3:24 PM, Evgeny Kotkov wrote: > Stefan Fuhrmann writes: > > > Sorry, my bad, I was wrong there. I only remembered that we had and still > > have the pack/hotcopy race condition in 1.8 and then I saw the recursive > > directory copy calls in the /trunk hotcopy code and had

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

Stefan Fuhrmann writes: > Sorry, my bad, I was wrong there. I only remembered that we had and still > have the pack/hotcopy race condition in 1.8 and then I saw the recursive > directory copy calls in the /trunk hotcopy code and had my false positive. > > You are absolutely right. We already copy

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

Stefan Fuhrmann writes: > The only outstanding consistency issue with hotcopying is the locks > handling: this is the code that does plain tree copies. But I have no > idea whether that is an actual problem and whether we can do anything > about it. http://subversion.tigris.org/issues/show_bug.c

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

On Tue, Jun 16, 2015 at 11:55 PM, Evgeny Kotkov wrote: > Stefan Fuhrmann writes: > > > That makes we wonder how we prevent packing in old format repositories. > > We know that hotcopying while packing can corrupt the destination repo. > > [...] > > > I'm -1 on reverting: Not being able to use ho

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

Stefan Fuhrmann writes: > That makes we wonder how we prevent packing in old format repositories. > We know that hotcopying while packing can corrupt the destination repo. [...] > I'm -1 on reverting: Not being able to use hotcopy on an r/o repo is less > problematic than ending up with a corru

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

On 16.06.2015 22:03, Stefan Fuhrmann wrote: > On Tue, Jun 16, 2015 at 9:38 PM, Branko Čibej > wrote: > > On 16.06.2015 20:49, Stefan Fuhrmann wrote: > > Once we are at it, let's detect pack operations during > > hotcopy (compare pack status before & after the

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

On Tue, Jun 16, 2015 at 9:38 PM, Branko Čibej wrote: > On 16.06.2015 20:49, Stefan Fuhrmann wrote: > > Once we are at it, let's detect pack operations during > > hotcopy (compare pack status before & after the hotcopy). > > Then we can at least warn the user of older format repos > > that their h

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

On 16.06.2015 20:49, Stefan Fuhrmann wrote: > Once we are at it, let's detect pack operations during > hotcopy (compare pack status before & after the hotcopy). > Then we can at least warn the user of older format repos > that their hotcopy is possibly corrupt now. We should probably do that regar

Re: FSFS7: 'svnadmin hotcopy' requires write access to the source

On Tue, Jun 16, 2015 at 8:12 PM, Evgeny Kotkov wrote: > FSFS7 introduced a new on-disk lockfile, db/pack-lock, that allows packing > a repository without completely blocking the commits. We also extended the > svn_fs_fs__hotcopy() logic to take this lock for the source repository, see > r1589284