On 16.06.2015 22:03, Stefan Fuhrmann wrote: > On Tue, Jun 16, 2015 at 9:38 PM, Branko Čibej <br...@wandisco.com > <mailto:br...@wandisco.com>> wrote: > > On 16.06.2015 20:49, Stefan Fuhrmann wrote: > > Once we are at it, let's detect pack operations during > > hotcopy (compare pack status before & after the hotcopy). > > Then we can at least warn the user of older format repos > > that their hotcopy is possibly corrupt now. > > We should probably do that regardless of FSFS format? > > > Yes (and it is probably even less code to do so). > > Alternatively, we could copy revisions explicitly in strict > order as opposed to blindly copying directory contents. > That way, we would detect a pack process removing > files under our very eyes and restart the copying at the > appropriate shard. Disabling pack during hotcopy would > still be a good idea but no longer necessary. > > I guess such a change would be 1.10 material.
In the meantime, if we haven't done so already, we should just document that running hotcopy and pack at the same time is a bad idea. Admins surely have many tools available to prevent such collisions. -- Brane
