Re: [PATCH] pass NULL instead of an unused parameter

2011-01-11 Thread Daniel Shahaf
C. Michael Pilato wrote on Tue, Jan 11, 2011 at 10:03:23 -0500: > On 01/11/2011 07:17 AM, Prabhu Gnana Sundar wrote: > > Hi Kamesh, > > > > > > On Tuesday 11 January 2011 05:23 PM, Kamesh Jayachandran wrote: > >> Hi Prabhu, > >> > >>>SVN_ERR(svn_config_get_config(&config, opt_state->config_di

Re: [PATCH] pass NULL instead of an unused parameter

2011-01-11 Thread C. Michael Pilato
On 01/11/2011 07:17 AM, Prabhu Gnana Sundar wrote: > Hi Kamesh, > > > On Tuesday 11 January 2011 05:23 PM, Kamesh Jayachandran wrote: >> Hi Prabhu, >> >>>SVN_ERR(svn_config_get_config(&config, opt_state->config_dir, pool)); >>>SVN_ERR(svn_repos_create(&repos, opt_state->repository_path, >

Re: [PATCH] pass NULL instead of an unused parameter

2011-01-11 Thread Prabhu Gnana Sundar
Hi Kamesh, On Tuesday 11 January 2011 05:23 PM, Kamesh Jayachandran wrote: Hi Prabhu, SVN_ERR(svn_config_get_config(&config, opt_state->config_dir, pool)); SVN_ERR(svn_repos_create(&repos, opt_state->repository_path, NULL, NULL, - co

Re: [PATCH] pass NULL instead of an unused parameter

2011-01-11 Thread Kamesh Jayachandran
On 01/11/2011 05:05 PM, Prabhu Gnana Sundar wrote: Hi all, Currently, when creating a repo, svnadmin accepts the --config-dir option. But clearly, the code does not use the 'config' option being passed. Hence I am passing NULL value instead of sending the 'config' value. This change has pas