Re: [PATCH] Use neon's system proxy detection if not explicitly specified

2010-10-23 Thread Gavin Beau Baumanis
I have sent this patch to the issue tracker; #3740. http://subversion.tigris.org/issues/show_bug.cgi?id=3740 Gavin "Beau" Baumanis On 27/09/2010, at 9:05 PM, Dominique Leuenberger wrote: > Hi All, > > [[[ > Use Neon's system_proxy autodetection if no proxy has been explicitly > specified. > ]

Re: [PATCH] Use neon's system proxy detection if not explicitly specified

2010-10-09 Thread Gavin Beau Baumanis
Ping. This patch has received no further comments. Gavin "Beau" Baumanis On 29/09/2010, at 8:48 PM, Dominique Leuenberger wrote: > On Wed, 2010-09-29 at 12:42 +0200, Daniel Shahaf wrote: >>> >>> For me either way is fine: I can update the patch to also detect newer >>> versions as suggest by

Re: [PATCH] Use neon's system proxy detection if not explicitly specified

2010-09-29 Thread Dominique Leuenberger
On Wed, 2010-09-29 at 12:42 +0200, Daniel Shahaf wrote: > > > > For me either way is fine: I can update the patch to also detect newer > > versions as suggest by you. Which in turn will still break all the other > > detections of SVN_NEON_0_28 and older. Or we keep them 'in sync' > > together and

Re: [PATCH] Use neon's system proxy detection if not explicitly specified

2010-09-29 Thread Daniel Shahaf
Dominique Leuenberger wrote on Mon, Sep 27, 2010 at 14:48:20 +0200: > On Mon, 2010-09-27 at 13:19 +0100, Jon Foster wrote: > > > Better, but it'll still go wrong with Neon 0.40 or 1.00. I guess it > > needs to be something like: > > > > if test -n ["`echo "$NEON_VERSION" | $EGREP > > '^(([1-

RE: [PATCH] Use neon's system proxy detection if not explicitly specified

2010-09-29 Thread Jon Foster
Dominique wrote: > On Mon, 2010-09-27 at 13:19 +0100, Jon Foster wrote: > > Better, but it'll still go wrong with Neon 0.40 or 1.00. I guess it > > needs to be something like: > > > > if test -n ["`echo "$NEON_VERSION" | $EGREP > > '^(([1-9][0-9]*)|(0\.(29|[3-9][0-9])))\.'`"] ; then > > > >

RE: [PATCH] Use neon's system proxy detection if not explicitly specified

2010-09-29 Thread Dominique Leuenberger
On Mon, 2010-09-27 at 13:19 +0100, Jon Foster wrote: > Better, but it'll still go wrong with Neon 0.40 or 1.00. I guess it > needs to be something like: > > if test -n ["`echo "$NEON_VERSION" | $EGREP > '^(([1-9][0-9]*)|(0\.(29|[3-9][0-9])))\.'`"] ; then > > ? That should match 0.29-0.99 an

RE: [PATCH] Use neon's system proxy detection if not explicitly specified

2010-09-27 Thread Dominique Leuenberger
On Mon, 2010-09-27 at 13:19 +0100, Jon Foster wrote: > Better, but it'll still go wrong with Neon 0.40 or 1.00. I guess it > needs to be something like: > > if test -n ["`echo "$NEON_VERSION" | $EGREP > '^(([1-9][0-9]*)|(0\.(29|[3-9][0-9])))\.'`"] ; then > > ? That should match 0.29-0.99 a

RE: [PATCH] Use neon's system proxy detection if not explicitly specified

2010-09-27 Thread Jon Foster
Dominique Leuenberger wrote: > On Mon, 2010-09-27 at 12:33 +0100, Jon Foster wrote: > > Hi, > > > > + if test -n ["`echo "$NEON_VERSION" | grep '^0\.29\.'`"] ; then > > + AC_DEFINE_UNQUOTED([SVN_NEON_0_29], [1], > > +[Define to 1 if you have Neon 0.29 or later.]) > > + fi > > > > Th

RE: [PATCH] Use neon's system proxy detection if not explicitly specified

2010-09-27 Thread Dominique Leuenberger
On Mon, 2010-09-27 at 12:33 +0100, Jon Foster wrote: > Hi, > > + if test -n ["`echo "$NEON_VERSION" | grep '^0\.29\.'`"] ; then > + AC_DEFINE_UNQUOTED([SVN_NEON_0_29], [1], > +[Define to 1 if you have Neon 0.29 or later.]) > + fi > > The comment says "0.29 or later" (which I think i

RE: [PATCH] Use neon's system proxy detection if not explicitly specified

2010-09-27 Thread Jon Foster
Hi, + if test -n ["`echo "$NEON_VERSION" | grep '^0\.29\.'`"] ; then + AC_DEFINE_UNQUOTED([SVN_NEON_0_29], [1], +[Define to 1 if you have Neon 0.29 or later.]) + fi The comment says "0.29 or later" (which I think is right), but the test looks like it's checking for Neon 0.29 exactly