On Mon, 2010-09-27 at 12:33 +0100, Jon Foster wrote: > Hi, > > + if test -n ["`echo "$NEON_VERSION" | grep '^0\.29\.'`"] ; then > + AC_DEFINE_UNQUOTED([SVN_NEON_0_29], [1], > + [Define to 1 if you have Neon 0.29 or later.]) > + fi > > The comment says "0.29 or later" (which I think is right), but > the test looks like it's checking for Neon 0.29 exactly. Will > this go wrong with Neon 0.30 or 1.00?
Hi, That's the patch for 1.6.12 as I remember. It is rather unclear if neon 0.30 is going to change API or not to me. I would assume not. This is also the reason why the trunk based patch contains: + if test -n ["`echo "$NEON_VERSION" | $EGREP '^0\.(29| 3[0-9])\.'`"] ; then + AC_DEFINE_UNQUOTED([SVN_NEON_0_29], [1], + [Define to 1 if you have Neon 0.29 or later.]) + fi + This should trigger at least 0.3x as valid as well. (the 1.6.12 patch is more for reference, as that is the tested one). Dominique
