Noorul Islam K M writes:
> Julian Foad writes:
>
>> Re:
>> * "svn info ^/b" -> "Not a valid URL"; should be "path '/b' not found
>> in revision REV"?
>>
>> On Wed, 2010-12-08, Noorul Islam K M wrote:
>> [...]
>>> One of the solution that you suggested was to keep what the existing
>>> code is
Julian Foad writes:
> Re:
> * "svn info ^/b" -> "Not a valid URL"; should be "path '/b' not found
> in revision REV"?
>
> On Wed, 2010-12-08, Noorul Islam K M wrote:
> [...]
>> One of the solution that you suggested was to keep what the existing
>> code is doing but saying something more helpfu
Re:
* "svn info ^/b" -> "Not a valid URL"; should be "path '/b' not found
in revision REV"?
On Wed, 2010-12-08, Noorul Islam K M wrote:
[...]
> One of the solution that you suggested was to keep what the existing
> code is doing but saying something more helpful than "Not a valid
> URL". I thoug
On Mon, 2010-12-13, Noorul Islam K M wrote:
> Julian Foad writes:
> >
> > * "svn mv ^/ ^/" -> "Cannot move path
> > 'https:/svn.apache.org/repos/asf' into itself"; should not print the URL
> > as if it's a local path.
>
> Attached is the patch which improves error message displayed.
> [[[
> Ma
On Wed, 2010-12-15, Noorul Islam K M wrote:
> Julian Foad writes:
>
> > Noorul Islam K M wrote:
> >
> >> Julian Foad writes:
> >> > Thank you for the updated patch. Even though this is a very
> >> > simple-looking patch, I need a bit more information to help me review
> >> > it.
> >> >
> >> > D
Julian Foad writes:
> Noorul Islam K M wrote:
>
>> Julian Foad writes:
>> > Thank you for the updated patch. Even though this is a very
>> > simple-looking patch, I need a bit more information to help me review
>> > it.
>> >
>> > Do you think both of the options I suggested are possible solutio
Julian Foad writes:
> On Mon, 2010-12-13, Hyrum K. Wright wrote:
>
>> Random community nit: The attached log message seems to have little to
>> do with email subject of "Input validation observations".
>
> FYI, I'm watching this thread and intend to res
On Mon, 2010-12-13, Hyrum K. Wright wrote:
> Random community nit: The attached log message seems to have little to
> do with email subject of "Input validation observations".
FYI, I'm watching this thread and intend to respond to this patch, which
is one of a series of patc
Julian Foad writes:
>
> * "svn mv ^/ ^/" -> "Cannot move path
> 'https:/svn.apache.org/repos/asf' into itself"; should not print the URL
> as if it's a local path.
>
Attached is the patch which improves error message displayed.
Log
[[[
Make 'svn move' display correct error message while movi
Random community nit: The attached log message seems to have little to
do with email subject of "Input validation observations". In the
future, when sending a new patch to the list, I'd recommend starting a
new thread, complete with it's own "[PATCH] ..." subjec
gards
Noorul
-Original Message-
From: Julian Foad [mailto:julian.f...@wandisco.com]
Sent: Tue 11/30/2010 5:18 PM
To: Subversion Development; noorul Islam. Kamal Malmiyoda
Subject: Input validation observations
I tried some potentially invalid inputs to "svn" a week or two ago and
made
On Fri, 2010-12-10, Noorul Islam K M wrote:
> Julian Foad writes:
> > After you have asserted that all the targets are of the same type, there
> > is no need for a loop that checks all of them in turn, just to find out
> > whether they are paths or URLs, is there?
>
> You are absolutely right. Th
Julian Foad writes:
> Noorul Islam K M wrote:
>
>> Attached is the patch for svn/diff-cmd.c. All tests pass.
>
> Hi Noorul. Thanks for mentioning that all tests pass - that's good to
> know.
>
>> + svn_cl__assert_homogeneous_target_type(targets);
>> +
>>/* Check to see if at l
On 12/10/2010 07:00 AM, Julian Foad wrote:
> Noorul Islam K M wrote:
>> Attached is the patch for svn/diff-cmd.c. All tests pass.
>
> Hi Noorul. Thanks for mentioning that all tests pass - that's good to
> know.
>
>> + svn_cl__assert_homogeneous_target_type(targets);
>> +
>>/*
On Fri, 2010-12-10 at 18:09 +0530, Noorul Islam K M wrote:
> Julian Foad writes:
>
> > Noorul Islam K M wrote:
> >
> >> Attached is the patch for svn/diff-cmd.c. All tests pass.
> >
> > Hi Noorul. Thanks for mentioning that all tests pass - that's good to
> > know.
> >
> >> + svn_cl__assert
Julian Foad writes:
> Noorul Islam K M wrote:
>
>> Attached is the patch for svn/diff-cmd.c. All tests pass.
>
> Hi Noorul. Thanks for mentioning that all tests pass - that's good to
> know.
>
>> + svn_cl__assert_homogeneous_target_type(targets);
>> +
>>/* Check to see if at l
Noorul Islam K M wrote:
> Attached is the patch for svn/diff-cmd.c. All tests pass.
Hi Noorul. Thanks for mentioning that all tests pass - that's good to
know.
> + svn_cl__assert_homogeneous_target_type(targets);
> +
>/* Check to see if at least one of our paths is a working c
Noorul Islam K M writes:
> Julian Foad writes:
>
>> On Sat, 2010-12-04 at 13:01 +0530, Noorul Islam K M wrote:
>>
>>> Julian Foad writes:
>>>
>>> > Noorul Islam K M wrote:
>>> >
>>> >> Julian Foad writes:
>>> >> > * "svn mkdir ^/ a" -> "Illegal repository URL 'a'"; should say "can't
>>> >>
On Wed, 2010-12-08, Noorul Islam K M wrote:
> Attached is the patch which has the new functions to replace the
> existing blocks. All tests pass when tested with 'make check'. No need
> for test cases as they are already available.
Noorul, thank you. This is great.
> Also I have not modified
> l
Julian Foad writes:
> On Sat, 2010-12-04 at 13:01 +0530, Noorul Islam K M wrote:
>
>> Julian Foad writes:
>>
>> > Noorul Islam K M wrote:
>> >
>> >> Julian Foad writes:
>> >> > * "svn mkdir ^/ a" -> "Illegal repository URL 'a'"; should say "can't
>> >> > mix URL and local targets"?
>> > [...
Noorul Islam K M wrote:
> Julian Foad writes:
> > Thank you for the updated patch. Even though this is a very
> > simple-looking patch, I need a bit more information to help me review
> > it.
> >
> > Do you think both of the options I suggested are possible solutions?
> > What are the advantages
Noorul Islam K M wrote:
> Ran test suite and found some failures and fixed them. All of them were
> passing URL to 'svn up' which is not at all required. Now all tests are
> passing with the below attached patch.
Thanks, Noorul. That's lovely. Committed revision 1043409.
- Julian
> Log
> [[[
Julian Foad writes:
> On Sat, 2010-12-04, Noorul Islam K M wrote:
>
>> Julian Foad writes:
>> > Noorul Islam K M wrote:
>> >> Julian Foad writes:
>> >> > * "svn info ^/b" -> "Not a valid URL"; should be "path '/b' not found
>> >> > in revision REV"?
> [...]
>> >> - SVN_ERR(svn_cm
Noorul Islam K M writes:
> Julian Foad writes:
>
>> On Sat, 2010-12-04, Noorul Islam K M wrote:
>>
>>> Julian Foad writes:
>>> > On Fri, 2010-12-03, Noorul Islam K M wrote:
>>> >> Julian Foad writes:
>>> >> > I think we should change this behaviour and make "svn update" throw an
>>> >> > error
Julian Foad writes:
> On Sat, 2010-12-04, Noorul Islam K M wrote:
>
>> Julian Foad writes:
>> > On Fri, 2010-12-03, Noorul Islam K M wrote:
>> >> Julian Foad writes:
>> >> > I think we should change this behaviour and make "svn update" throw an
>> >> > error if any target is a URL.
>> >>
>> >>
On Sat, 2010-12-04, Noorul Islam K M wrote:
> Julian Foad writes:
> > On Fri, 2010-12-03, Noorul Islam K M wrote:
> >> Julian Foad writes:
> >> > I think we should change this behaviour and make "svn update" throw an
> >> > error if any target is a URL.
> >>
> >> Attached is the patch for same.
On Sat, 2010-12-04, Noorul Islam K M wrote:
> Julian Foad writes:
> > Noorul Islam K M wrote:
> >> Julian Foad writes:
> >> > * "svn info ^/b" -> "Not a valid URL"; should be "path '/b' not found
> >> > in revision REV"?
[...]
> >> - SVN_ERR(svn_cmdline_fprintf
> >> -
On Sat, 2010-12-04 at 13:01 +0530, Noorul Islam K M wrote:
> Julian Foad writes:
>
> > Noorul Islam K M wrote:
> >
> >> Julian Foad writes:
> >> > * "svn mkdir ^/ a" -> "Illegal repository URL 'a'"; should say "can't
> >> > mix URL and local targets"?
> > [...]
> >> Make 'svn mkdir' verify tha
Julian Foad writes:
> Noorul Islam K M wrote:
>
>> Julian Foad writes:
>> > * "svn mkdir ^/ a" -> "Illegal repository URL 'a'"; should say "can't
>> > mix URL and local targets"?
> [...]
>> Make 'svn mkdir' verify that both working copy paths and URLs are
>> not passed.
>>
>> * subversion/svn
Julian Foad writes:
> On Fri, 2010-12-03, Noorul Islam K M wrote:
>
>> Julian Foad writes:
>> > I think we should change this behaviour and make "svn update" throw an
>> > error if any target is a URL.
>>
>> Attached is the patch for same.
> [...]
>> Make 'svn update' verify that URLs are not p
Julian Foad writes:
> Noorul Islam K M wrote:
>
>> Julian Foad writes:
>> > * "svn info ^/b" -> "Not a valid URL"; should be "path '/b' not found
>> > in revision REV"?
>>
>> Patch attached.
>
> Hi Noorul.
>
>> Make "svn info" to display the actual error message returned by API when
>> illega
On Fri, 2010-12-03 at 16:53 +, Julian Foad wrote:
> On Fri, 2010-12-03, Julian Foad wrote:
> > On Fri, 2010-12-03 at 19:15 +0530, Noorul Islam K M wrote:
> > > Julian Foad writes:
> > > > Noorul Islam K M wrote:
> > > >> Julian Foad writes:
> > > >> > * "svn mkdir ^/ a" -> "Illegal reposito
On Fri, 2010-12-03, Julian Foad wrote:
> On Fri, 2010-12-03 at 19:15 +0530, Noorul Islam K M wrote:
> > Julian Foad writes:
> > > Noorul Islam K M wrote:
> > >> Julian Foad writes:
> > >> > * "svn mkdir ^/ a" -> "Illegal repository URL 'a'"; should say "can't
> > >> > mix URL and local targets"
On Fri, 2010-12-03 at 19:15 +0530, Noorul Islam K M wrote:
> Julian Foad writes:
> > Noorul Islam K M wrote:
> >> Julian Foad writes:
> >> > * "svn mkdir ^/ a" -> "Illegal repository URL 'a'"; should say "can't
> >> > mix URL and local targets"?
> > [...]
> > Does this validation make the check
On Fri, 2010-12-03, Noorul Islam K M wrote:
> Julian Foad writes:
> > I think we should change this behaviour and make "svn update" throw an
> > error if any target is a URL.
>
> Attached is the patch for same.
[...]
> Make 'svn update' verify that URLs are not passed as targets.
>
> * subversio
On 12/03/2010 06:51 AM, Julian Foad wrote:
> Noorul Islam K M wrote:
>> Julian Foad writes:
[...]
>> Index: subversion/svn/info-cmd.c
>> ===
>> --- subversion/svn/info-cmd.c(revision 1041293)
>> +++ subversion/svn/info-cmd.c
Julian Foad writes:
> Noorul Islam K M wrote:
>
>> Julian Foad writes:
>> > * "svn mkdir ^/ a" -> "Illegal repository URL 'a'"; should say "can't
>> > mix URL and local targets"?
> [...]
>> Make 'svn mkdir' verify that both working copy paths and URLs are
>> not passed.
>>
>> * subversion/svn
Noorul Islam K M wrote:
> Julian Foad writes:
> > * "svn mkdir ^/ a" -> "Illegal repository URL 'a'"; should say "can't
> > mix URL and local targets"?
[...]
> Make 'svn mkdir' verify that both working copy paths and URLs are
> not passed.
>
> * subversion/svn/mkdir-cmd.c,
> subversion/libsvn
Noorul Islam K M wrote:
> Julian Foad writes:
> > * "svn info ^/b" -> "Not a valid URL"; should be "path '/b' not found
> > in revision REV"?
>
> Patch attached.
Hi Noorul.
> Make "svn info" to display the actual error message returned by API when
> illegal URL is passed.
>
> * subversion/sv
Julian Foad writes:
> I tried some potentially invalid inputs to "svn" a week or two ago and
> made notes on what I found. Just posting here in case anyone wants to
> do something about one or more of them.
>
> Noorul, I'm including you in the "To" addresses because you said you
> were looking f
Julian Foad writes:
> I tried some potentially invalid inputs to "svn" a week or two ago and
> made notes on what I found. Just posting here in case anyone wants to
> do something about one or more of them.
>
> Noorul, I'm including you in the "To" addresses because you said you
> were looking f
Julian Foad writes:
> On Thu, 2010-12-02 at 13:58 +0530, Noorul Islam K M wrote:
>
>> Julian Foad writes:
>>
>> > On Tue, 2010-11-30 at 18:42 +0530, Noorul Islam K M wrote:
>> >
>> >> Julian Foad writes:
>> >>
>> >> > I tried some potentially invalid inputs to "svn" a week or two ago and
>> >
On Thu, 2010-12-02 at 13:58 +0530, Noorul Islam K M wrote:
> Julian Foad writes:
>
> > On Tue, 2010-11-30 at 18:42 +0530, Noorul Islam K M wrote:
> >
> >> Julian Foad writes:
> >>
> >> > I tried some potentially invalid inputs to "svn" a week or two ago and
> >> > made notes on what I found. J
On Thu, 2010-12-02 at 14:05 +0530, Noorul Islam K M wrote:
> Julian Foad writes:
>
> > I tried some potentially invalid inputs to "svn" a week or two ago and
> > made notes on what I found. Just posting here in case anyone wants to
> > do something about one or more of them.
> >
> > Noorul, I'm
Julian Foad writes:
> I tried some potentially invalid inputs to "svn" a week or two ago and
> made notes on what I found. Just posting here in case anyone wants to
> do something about one or more of them.
>
> Noorul, I'm including you in the "To" addresses because you said you
> were looking f
Julian Foad writes:
> On Tue, 2010-11-30 at 18:42 +0530, Noorul Islam K M wrote:
>
>> Julian Foad writes:
>>
>> > I tried some potentially invalid inputs to "svn" a week or two ago and
>> > made notes on what I found. Just posting here in case anyone wants to
>> > do something about one or mor
On Tue, 2010-11-30 at 18:42 +0530, Noorul Islam K M wrote:
> Julian Foad writes:
>
> > I tried some potentially invalid inputs to "svn" a week or two ago and
> > made notes on what I found. Just posting here in case anyone wants to
> > do something about one or more of them.
> >
> > Noorul, I'm
Julian Foad writes:
> I tried some potentially invalid inputs to "svn" a week or two ago and
> made notes on what I found. Just posting here in case anyone wants to
> do something about one or more of them.
>
> Noorul, I'm including you in the "To" addresses because you said you
> were looking f
I tried some potentially invalid inputs to "svn" a week or two ago and
made notes on what I found. Just posting here in case anyone wants to
do something about one or more of them.
Noorul, I'm including you in the "To" addresses because you said you
were looking for more small tasks to do, so fee
49 matches
Mail list logo
