Re: Consolidating private/svn_subr_private.h

2012-09-07 Thread Stefan Fuhrmann
On Tue, Sep 4, 2012 at 10:03 PM, Stefan Fuhrmann < stefan.fuhrm...@wandisco.com> wrote: > Hi there, > > While looking for the appropriate place to declare a few > svn-private constants, I realized that libsvn_subr is the > only lib that comes with multiple private headers. > > So, I prepared a pat

Re: Consolidating private/svn_subr_private.h

2012-09-05 Thread Branko Čibej
On 05.09.2012 11:47, Daniel Shahaf wrote: > Greg Stein wrote on Tue, Sep 04, 2012 at 23:11:24 -0400: >> On Sep 4, 2012 5:47 PM, "Daniel Shahaf" wrote: >>> Stefan Fuhrmann wrote on Tue, Sep 04, 2012 at 22:03:54 +0200: Hi there, While looking for the appropriate place to declare a few

Re: Consolidating private/svn_subr_private.h

2012-09-05 Thread Daniel Shahaf
Greg Stein wrote on Tue, Sep 04, 2012 at 23:11:24 -0400: > On Sep 4, 2012 5:47 PM, "Daniel Shahaf" wrote: > > > > Stefan Fuhrmann wrote on Tue, Sep 04, 2012 at 22:03:54 +0200: > > > Hi there, > > > > > > While looking for the appropriate place to declare a few > > > svn-private constants, I realiz

Re: Consolidating private/svn_subr_private.h

2012-09-04 Thread Greg Stein
On Sep 4, 2012 5:47 PM, "Daniel Shahaf" wrote: > > Stefan Fuhrmann wrote on Tue, Sep 04, 2012 at 22:03:54 +0200: > > Hi there, > > > > While looking for the appropriate place to declare a few > > svn-private constants, I realized that libsvn_subr is the > > only lib that comes with multiple privat

RE: Consolidating private/svn_subr_private.h

2012-09-04 Thread Bert Huijben
> -Original Message- > From: Branko Čibej [mailto:br...@wandisco.com] > Sent: woensdag 5 september 2012 00:57 > To: dev@subversion.apache.org > Subject: Re: Consolidating private/svn_subr_private.h > > On 04.09.2012 23:46, Daniel Shahaf wrote: > > Stefan Fu

Re: Consolidating private/svn_subr_private.h

2012-09-04 Thread Branko Čibej
On 04.09.2012 23:46, Daniel Shahaf wrote: > Stefan Fuhrmann wrote on Tue, Sep 04, 2012 at 22:03:54 +0200: >> Hi there, >> >> While looking for the appropriate place to declare a few >> svn-private constants, I realized that libsvn_subr is the >> only lib that comes with multiple private headers. >>

Re: Consolidating private/svn_subr_private.h

2012-09-04 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Tue, Sep 04, 2012 at 22:03:54 +0200: > Hi there, > > While looking for the appropriate place to declare a few > svn-private constants, I realized that libsvn_subr is the > only lib that comes with multiple private headers. > Why is that a problem?

Re: Consolidating private/svn_subr_private.h

2012-09-04 Thread Greg Stein
Go for it! +1 On Tue, Sep 4, 2012 at 4:03 PM, Stefan Fuhrmann wrote: > Hi there, > > While looking for the appropriate place to declare a few > svn-private constants, I realized that libsvn_subr is the > only lib that comes with multiple private headers. > > So, I prepared a patch that moves all

Consolidating private/svn_subr_private.h

2012-09-04 Thread Stefan Fuhrmann
Hi there, While looking for the appropriate place to declare a few svn-private constants, I realized that libsvn_subr is the only lib that comes with multiple private headers. So, I prepared a patch that moves all their content into private/svn_subr_private.h with two exceptions: svn_sqlite.h an