Greg Stein wrote on Tue, Sep 04, 2012 at 23:11:24 -0400: > On Sep 4, 2012 5:47 PM, "Daniel Shahaf" <d...@daniel.shahaf.name> wrote: > > > > Stefan Fuhrmann wrote on Tue, Sep 04, 2012 at 22:03:54 +0200: > > > Hi there, > > > > > > While looking for the appropriate place to declare a few > > > svn-private constants, I realized that libsvn_subr is the > > > only lib that comes with multiple private headers. > > > > > > > Why is that a problem? > > Every other library has a single private header. With subr, you gotta go > search every time to see if the declaration is in svn_subr_private.h, or > some other random header. It's a scattered mess. >
For me it's not a problem as I use ctags. > Unifying the APIs into a single library header would be a huge improvement. > Not necessarily, small files are better for some tasks (eg: searching/greping) than large ones. Given: % grep ^svn svn_subr_private.h | grep \( svn_spillbuf__create(apr_size_t blocksize, svn_spillbuf__get_size(const svn_spillbuf_t *buf); svn_spillbuf__write(svn_spillbuf_t *buf, svn_spillbuf__read(const char **data, svn_spillbuf__process(svn_boolean_t *exhausted, svn_spillbuf__reader_create(apr_size_t blocksize, svn_spillbuf__reader_read(apr_size_t *amt, svn_spillbuf__reader_getc(char *c, svn_spillbuf__reader_write(svn_spillbuf_reader_t *reader, svn_stream__from_spillbuf(apr_size_t blocksize, svn_checksum__from_digest_md5(const unsigned char *digest, svn_checksum__from_digest_sha1(const unsigned char *digest, svn_hash__clear(apr_hash_t *hash, apr_pool_t *pool); svn_hash__get_cstring(apr_hash_t *hash, svn_hash__get_bool(apr_hash_t *hash, svn_hash__make(apr_pool_t *pool); How about splitting svn_subr_private.h to svn_spillbuf_private.h, svn_checksum_private.h, svn_hash_private.h, and removing svn_subr_private.h? > Cheers, > -g
