Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

2010-08-30 Thread Simon Atanasyan
On Tue, Aug 3, 2010 at 18:20, Daniel Shahaf wrote: > Perhaps the patch would face more friendly winds if you retained the API > bit, but replaced --fsfs-no-rep-sharing by some more generic --config-option > flag?  (compare 'svn --config-option') I think moving --fsfs-no-rep-sharing under --config

Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

2010-08-03 Thread Daniel Shahaf
Simon Atanasyan wrote on Tue, Aug 03, 2010 at 12:28:20 +0400: > On Mon, Aug 2, 2010 at 23:04, Daniel Shahaf wrote: > > Simon Atanasyan wrote on Mon, Aug 02, 2010 at 19:59:31 +0400: > >> From the programmer's point of view if you create repository calling > >> svn_fs_create with the new configurati

Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

2010-08-03 Thread Simon Atanasyan
On Mon, Aug 2, 2010 at 23:04, Daniel Shahaf wrote: > Simon Atanasyan wrote on Mon, Aug 02, 2010 at 19:59:31 +0400: >> From the programmer's point of view if you create repository calling >> svn_fs_create with the new configuration option you easily get well commented >> db/fsfs.conf with necessary

Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

2010-08-02 Thread Daniel Shahaf
Simon Atanasyan wrote on Mon, Aug 02, 2010 at 19:59:31 +0400: > From the programmer's point of view if you create repository calling > svn_fs_create with the new configuration option you easily get well commented > db/fsfs.conf with necessary settings. svn_fs_create() already takes an FS_CONFIG pa

Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

2010-08-02 Thread Simon Atanasyan
On Tue, Jul 20, 2010 at 20:29, Hyrum K. Wright wrote: > On Jul 20, 2010, at 9:32 AM, Simon Atanasyan wrote: > > The general idea of the patch is to introduce new svnadmin option > and FSFS filesystem configuration option to allow enabling/disabling > repository sharing on FSFS. > > I am not sure

Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

2010-07-20 Thread Daniel Shahaf
Daniel Shahaf wrote on Tue, Jul 20, 2010 at 23:05:45 +0300: > Hyrum K. Wright wrote on Tue, Jul 20, 2010 at 11:29:38 -0500: > > On Jul 20, 2010, at 9:32 AM, Simon Atanasyan wrote: > > > I am not sure that SQLite locking works correctly over network share > > > due the limit file level locking supp

Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

2010-07-20 Thread Daniel Shahaf
Simon Atanasyan wrote on Tue, Jul 20, 2010 at 19:51:47 +0400: > + apr_hash_set(fs_config, SVN_FS_CONFIG_FSFS_REP_SHARING, > + APR_HASH_KEY_STRING, > + (opt_state->fsfs_no_rep_sharing ? "0" : "1")); > + >apr_hash_set(fs_config, SVN_FS_CONFIG_BDB_TXN_NOSYNC, >

Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

2010-07-20 Thread Daniel Shahaf
Hyrum K. Wright wrote on Tue, Jul 20, 2010 at 11:29:38 -0500: > > > > > On Jul 20, 2010, at 9:32 AM, Simon Atanasyan wrote: > > > The general idea of the patch is to introduce new svnadmin option > > and FSFS filesystem configuration option to allow enabling/disabling > > repository sharing o

Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

2010-07-20 Thread C. Michael Pilato
On 07/20/2010 12:29 PM, Hyrum K. Wright wrote: > Is this in addition or in place of the already-present capability to > disable rep-sharing via the db/fsfs.conf file? Since we already expose > the option elsewhere, I'm not convinced we need an additional option for > svnadmin. There is at least s

Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

2010-07-20 Thread Hyrum K. Wright
On Jul 20, 2010, at 9:32 AM, Simon Atanasyan wrote: > The general idea of the patch is to introduce new svnadmin option > and FSFS filesystem configuration option to allow enabling/disabling > repository sharing on FSFS. > > I am not sure that SQLite locking works correctly over network shar

Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

2010-07-20 Thread Simon Atanasyan
On Tue, Jul 20, 2010 at 18:32, Simon Atanasyan wrote: > The patch itself is in the attachment. The missed patch file. -- Simon Atanasyan VisualSVN Limited Index: subversion/svnadmin/main.c === --- subversion/svnadmin/main.c (revis

Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

2010-07-20 Thread Philip Martin
Simon Atanasyan writes: > The general idea of the patch is to introduce new svnadmin option > and FSFS filesystem configuration option to allow enabling/disabling > repository sharing on FSFS. > > I am not sure that SQLite locking works correctly over network share > due the limit file level lock

[PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

2010-07-20 Thread Simon Atanasyan
The general idea of the patch is to introduce new svnadmin option and FSFS filesystem configuration option to allow enabling/disabling repository sharing on FSFS. I am not sure that SQLite locking works correctly over network share due the limit file level locking support offered by OS for network