Hyrum K. Wright wrote on Tue, Jul 20, 2010 at 11:29:38 -0500:
> 
> 
> 
> 
> On Jul 20, 2010, at 9:32 AM, Simon Atanasyan <si...@visualsvn.com> wrote:
> 
> > The general idea of the patch is to introduce new svnadmin option
> > and FSFS filesystem configuration option to allow enabling/disabling
> > repository sharing on FSFS.
    ^
*Representation* sharing.

> > 
> > I am not sure that SQLite locking works correctly over network share
> > due the limit file level locking support offered by OS for network shares.
> > SQLite is used for repository sharing so it may lead to repository 
> > corruption.
> > svnadmin and filesystem configuration options help users control this issue.
> 
> Is this in addition or in place of the already-present capability to disable
> rep-sharing via the db/fsfs.conf file?  Since we already expose the option
> elsewhere, I'm not convinced we need an additional option for svnadmin.
> 

+1

> Additionally, if the underlying filesystem doesn't support locking correctly,
> you've got bigger problems than SQLite behavior. :)
> 
> -Hyrum

Reply via email to