Re: Kidney blame's behaviour and edge cases

2013-06-13 Thread Prabhu Gnana Sundar
Johan Corveleyn wrote: >On Thu, Jun 13, 2013 at 6:10 PM, Doug Robinson > wrote: >> Daniel: >> >> I think that simply enabling Mcreate the >> situation where the user makes a mistake, gets something they don't >expect >> and tries to interpret it based on their desire - leading to >confusion. I

Re: [PATCH] Support regex in EXPECTED ERR list

2013-01-27 Thread Prabhu Gnana Sundar
On 01/25/2013 01:47 PM, Ben Reser wrote: To add some clarity here to what I'm saying above... There are two options. 1) Build a new class (could be named RegexListOutput) like I mention above or in an earlier email. This will likely be a tad easier, since you don't change the logic existing t

Re: [PATCH] Support regex in EXPECTED ERR list

2013-01-24 Thread Prabhu Gnana Sundar
On 01/23/2013 09:49 PM, Ben Reser wrote: # The EXPECTED lines must match a subset of the ACTUAL lines, # one-to-one, in the same order, with zero or more other ACTUAL # lines interspersed among the matching ACTUAL lines. i_expected = 0 for actual_line in

[PATCH] Support regex in EXPECTED ERR list

2013-01-22 Thread Prabhu Gnana Sundar
Hi, Just while writing test cases for the svnadmin verify --keep-going feature I realized that we do not support regex in the EXPECTED ERR list and felt that it would be really helpful if we supported. So I came up with this patch. This patch would support regex in the entries of the EXPECTE

Re: [PATCH] Implement svnadmin verify --keep-going

2013-01-14 Thread Prabhu Gnana Sundar
wrote: >> Thanks for this version, Prabhu.  It looks much better.  Still a few >more points... >> >> >> Prabhu Gnana Sundar wrote: >> > On 12/20/2012 11:25 PM, Julian Foad wrote: >> >> The output for a failed revision depends on whether --keep-goin

Re: [PATCH] Implement svnadmin verify --keep-going

2013-01-14 Thread Prabhu Gnana Sundar
Julian Foad wrote: >What holds me back from committing it is lack of a test that at least >exercises the 'keep-going' functionality (that is, reports on another >revision after reporting a failed revision) and lack of evidence that >it has been tested and found to work as expected in a few diff

Re: [PATCH] Implement svnadmin verify --keep-going

2013-01-03 Thread Prabhu Gnana Sundar
): New function to notify the verification failure error message. (verification_checks): New wrapper function to perform all the error checks for a particular revision in one go. * subversion/libsvn_repos/deprecated.c (svn_repos_verify_fs2): Deprecate. Call svn_repos_verify_fs3 with keep_going as FA

Re: [PATCH] Implement svnadmin verify --keep-going

2012-12-20 Thread Prabhu Gnana Sundar
return an error SVN_ERR_REPOS_CORRUPTED. (notify_verification_error): New function to notify the verification failure error message. * subversion/libsvn_repos/deprecated.c (svn_repos_verify_fs2): Deprecate. Call svn_repos_verify_fs3 with keep_going as FALSE by default t

Re: [PATCH] Implement svnadmin verify --keep-going

2012-12-14 Thread Prabhu Gnana Sundar
On 12/10/2012 08:15 PM, Julian Foad wrote: Prabhu Gnana Sundar This patch is a follow up of the long discussion we had in thread [1]. This patch implements a new switch "--keep-going" to svnadmin verify. If "--keep-going" is set(True), svnadmin verify would continue to ru

[PATCH] Implement svnadmin verify --keep-going

2012-12-10 Thread Prabhu Gnana Sundar
s/notify.c (svn_repos_notify_create): Initialise the error chain "err" to SVN_NO_ERROR. * subversion/tests/cmdline/svnadmin_tests.py (verify_keep_going): New test case to test svnadmin verify and the new switch --keep-going. Patch by:

Re: [PATCH] Implement svnadmin verify --force

2012-11-05 Thread Prabhu Gnana Sundar
regards Prabhu On 11/05/2012 07:38 PM, Julian Foad wrote: Prabhu Gnana Sundar wrote: Julian Foad wrote: [...] We should choose either "notification" style (that is, messages that are not error messages), such as [...] or "error messages" style, in which case th

Re: [PATCH] Implement svnadmin verify --force

2012-11-05 Thread Prabhu Gnana Sundar
On 11/04/2012 06:14 AM, Daniel Shahaf wrote: Index: subversion/svnadmin/main.c === --- subversion/svnadmin/main.c (revision 1402414) +++ subversion/svnadmin/main.c (working copy) @@ -738,6 +743,16 @@

Re: [PATCH] Implement svnadmin verify --force

2012-11-03 Thread Prabhu Gnana Sundar
But the code moves the E160004 away from its current location immediately after the "svnadmin:" prefix. I am not sure I like that; is there a good reason not to have the message be of the form svnadmin: E160004: %s in the interest of parseability? I agree that would be better: the prefix

Re: [PATCH] Implement svnadmin verify --force

2012-11-01 Thread Prabhu Gnana Sundar
Julian Foad wrote: >Prabhu Gnana Sundar wrote: > >> Julian Foad wrote: >>> At the very least there must be agreement on how it's going to exit >and >>> commitment to make it happen.  I already asked the question several >>> messages back. 

Re: [PATCH] Implement svnadmin verify --force

2012-11-01 Thread Prabhu Gnana Sundar
Julian Foad wrote: > >At the very least there must be agreement on how it's going to exit and >commitment to make it happen.  I already asked the question several >messages back.  Prabhu, please share your thoughts. > Yeah Julian, once an error is encountered, the error message is notified an

Re: [PATCH] Implement svnadmin verify --force

2012-11-01 Thread Prabhu Gnana Sundar
>Near the start of this thread we mentioned the main use cases.  There >are basically two: > >* Confirm that the repository is in a good state (e.g. before/after a >backup); > >* Diagnostic mode for use when a problem has been encountered. > >Keep-going mode is more useful for the latter; stop-q

Re: [PATCH] Implement svnadmin verify --force

2012-11-01 Thread Prabhu Gnana Sundar
On 10/31/2012 11:31 PM, Julian Foad wrote: Daniel Shahaf wrote: Julian Foad wrote on Wed, Oct 31, 2012 at 17:36:09 +: Prabhu Gnana Sundar wrote: > +revstr = ""; > + svn_handle_error2(notify->err, stderr, FALSE /* non-fatal */, > +

Re: [PATCH] Implement svnadmin verify --force

2012-10-31 Thread Prabhu Gnana Sundar
Thanks Daniel, Attaching the patch that would fix the suggestions given by you. Thanks and regards Prabhu On 10/31/2012 08:28 PM, Daniel Shahaf wrote: Index: subversion/libsvn_repos/dump.c === --- subversion/libsvn_repos/dump.

Re: [PATCH] Implement svnadmin verify --force

2012-10-31 Thread Prabhu Gnana Sundar
Thanks Stefan, Addressed the suggestions in this patch. Attaching the log message too with this mail. Please share your thoughts... Thanks and regards Prabhu On 10/30/2012 08:38 PM, Stefan Sperling wrote: On Tue, Oct 30, 2012 at 04:07:49PM +0200, Daniel Shahaf wrote: Prabhu Gnana Sundar

Re: [PATCH] Implement svnadmin verify --force

2012-10-30 Thread Prabhu Gnana Sundar
ed to handle "keep-going" option. (svn_repos_notify_t): Add "err", the error chain which indicates what went wrong during verification. * subversion/libsvn_repos/dump.c (svn_repos_verify_fs3): Handle "keep-going". If "keep-going" is TRUE, the error message is notified and verification process continues. * subversion/libsvn_repos/deprecated.c (svn_repos_verify_fs2): Deprecated. Call svn_repos_verify_fs3 with keep_going as FALSE by default to keep the old default implementation. * subversion/libsvn_repos/notify.c (svn_repos_notify_create): Initialise the error chain "err" to SVN_NO_ERROR. Patch by: Prabhu Gnana Sundar Reviewed by: Stefan Sperling

Re: [PATCH] Implement svnadmin verify --force

2012-10-29 Thread Prabhu Gnana Sundar
patch. Thanks and regards Prabhu On 10/29/2012 05:01 PM, Stefan Sperling wrote: On Mon, Oct 29, 2012 at 03:26:36PM +0530, Prabhu Gnana Sundar wrote: Thanks much Stefan, Now, I have changed the code in libsvn_fs/fs-loader.c to handle the error. Passed the keep_going to the verify_fs so that it

Re: [PATCH] Implement svnadmin verify --force

2012-10-29 Thread Prabhu Gnana Sundar
On 10/29/2012 02:51 PM, Stefan Sperling wrote: On Mon, Oct 29, 2012 at 12:27:32PM +0530, Prabhu Gnana Sundar wrote: On 10/28/2012 01:54 AM, Daniel Shahaf wrote: Index: subversion/libsvn_fs/fs-loader.c === --- subversion/libsvn_fs

Re: [PATCH] Implement svnadmin verify --force

2012-10-29 Thread Prabhu Gnana Sundar
On 10/28/2012 01:54 AM, Daniel Shahaf wrote: Index: subversion/libsvn_fs/fs-loader.c === --- subversion/libsvn_fs/fs-loader.c(revision 1402414) +++ subversion/libsvn_fs/fs-loader.c(working copy) @@ -487,17 +487,21 @@

Re: [PATCH] Implement svnadmin verify --force

2012-10-27 Thread Prabhu Gnana Sundar
andle "keep-going" option. * subversion/include/svn_fs.h (svn_fs_verify) : handles keep-going. If keep-going is TRUE, svn_fs_verify would return no error. * subversion/libsvn_repos/dump.c (svn_repos_verify_fs3): now handles "keep-going". If "keep-going" is TRUE, then the error message is written to the stderr and verify process continues. * subversion/libsvn_repos/deprecated.c (svn_repos_verify_fs2) : deprecated. Now calls svn_repos_verify_fs3 with keep-going as FALSE. Patch by: Prabhu Gnana Sundar

Re: [PATCH] Implement svnadmin verify --force

2012-10-26 Thread Prabhu Gnana Sundar
you might find them useful for your next patch. Prabhu Gnana Sundar wrote on Sun, Oct 21, 2012 at 00:57:47 +0530: Index: subversion/libsvn_repos/dump.c === --- subversion/libsvn_repos/dump.c (revision 1398254) +++ subversion/li

Re: [PATCH] Implement svnadmin verify --force

2012-10-21 Thread Prabhu Gnana Sundar
> >I might think differently if Prabhu says he already wrote >a verify-keep-going.py a year ago, has been using it since, and decided >it's so useful it belongs in the core. But I don't know that to be the >case. Ok. Let me tell you how I started writing this. I had a repo on a windows serve

Re: [PATCH] Implement svnadmin verify --force

2012-10-20 Thread Prabhu Gnana Sundar
08:35:03PM +0530, Prabhu Gnana Sundar wrote: Hi all, Currently svnadmin verify would stop verification process once an error/corruption is found in the repo. It does not go till the HEAD of the repo to see if there are further corruptions/errors. It would be helpful if "--force" switch wo

[PATCH] Implement svnadmin verify --force

2012-10-18 Thread Prabhu Gnana Sundar
with force as FALSE. Patch by: Prabhu Gnana Sundar Index: subversion/libsvn_repos/deprecated.c === --- subversion/libsvn_repos/deprecated.c (revision 1398254) +++ subversion/libsvn_repos/deprecated.c (working copy

[Patch] Improve usage description and remove unused library in mergeinfo-sanitizer.py

2012-03-15 Thread Prabhu Gnana Sundar
ded: svn:executable + * Remove unused library and improve the usage description. * tools/client-side/mergeinfo-sanitizer.py (usage): improve the usage description to show the usage of options Set the 'executable' property Removed the unused 're' library Patch by: Prabhu Gnana Sundar

[Patch] fix for compilation error, when compiled with "-pedantic" option

2011-10-27 Thread Prabhu Gnana Sundar
mp.c Fixed the trailing commas at the end of the enumerator lists. Not sure if they are typos. Found by: Peter Johansson Patch by: Prabhu Gnana Sundar

[Patch] improve usage description and remove unused library in mergeinfo-sanitizer.py

2011-10-11 Thread Prabhu Gnana Sundar
sage description to show the usage of options Patch by: Prabhu Gnana Sundar

Re: [PATCH] python script for issue #3961, fixing the bogus mergeinfo

2011-09-19 Thread Prabhu Gnana Sundar
Attaching a cleaner patch... Removed a couple of commented lines... Regards Prabhu On Monday 19 September 2011 10:24 PM, Prabhu Gnana Sundar wrote: Thanks Kamesh for your valuable review... On Monday 12 September 2011 06:25 PM, Kamesh Jayachandran wrote: I like this patch. We need it

Re: [PATCH] python script for issue #3961, fixing the bogus mergeinfo

2011-09-19 Thread Prabhu Gnana Sundar
Thanks Kamesh for your valuable review... On Monday 12 September 2011 06:25 PM, Kamesh Jayachandran wrote: I like this patch. We need it. Thank you... I found this bogus mergeinfo's were causing 404 file not found, which were sometimes causing the merge to fail, making it run longer than

Re: [PATCH] python script for issue #3961, fixing the bogus mergeinfo

2011-09-12 Thread Prabhu Gnana Sundar
On Friday 19 August 2011 11:45 AM, Prabhu Gnana Sundar wrote: Correcting the issue number as #3961... Minor fix in one of the commented descriptions... Attaching the updated script. Please share your thoughts. Thanks and regards Prabhu #!/usr/bin/env python import svn import sys import

Re: [PATCH] python script for issue #3961, fixing the bogus mergeinfo

2011-09-06 Thread Prabhu Gnana Sundar
Updated/fixed the script to not prompt the certificate even if the certificate is accepted permenantly, similar to the get-location-segments.py script. Attaching the updated script. Thanks and regards Prabhu On Friday 19 August 2011 11:45 AM, Prabhu Gnana Sundar wrote: Correcting the

Re: [PATCH] get-location-segments.py would work on self-signed ssl servers too

2011-09-06 Thread Prabhu Gnana Sundar
On Monday 05 September 2011 05:44 PM, Kamesh Jayachandran wrote: Prabhu, One small problem with your patch. See the below snip [kamesh@kamesh trunk]$ python tools/examples/get-location-segments.py https://svn.eu.apache.org/repos/asf/subversion/trunk The certficate details are as follows: --

Re: [PATCH] python script for issue #3961, fixing the bogus mergeinfo

2011-09-02 Thread Prabhu Gnana Sundar
Attaching an updated tweaked script... Regards Prabhu On Friday 19 August 2011 11:45 AM, Prabhu Gnana Sundar wrote: Correcting the issue number as #3961... On Thursday 18 August 2011 08:32 PM, Prabhu Gnana Sundar wrote: Hi all, With reference to my earlier discussions in http

Re: [PATCH] get-location-segments.py would work on self-signed ssl servers too

2011-09-02 Thread Prabhu Gnana Sundar
Thanks Vijay for the detailed explanation... I am attaching the patch for the script with minor tweaks... Regards Prabhu On Friday 02 September 2011 04:13 PM, vijay wrote: Actually, there are two issues to be noted. 1.Bug with neon (Reproducible in Ubuntu 10.10, svn 1.6.12, neon 0.29.3/GN

Re: [PATCH] get-location-segments.py would work on self-signed ssl servers too

2011-09-01 Thread Prabhu Gnana Sundar
On Friday 02 September 2011 11:54 AM, Prabhu Gnana Sundar wrote: On Monday 22 August 2011 09:37 AM, Prabhu Gnana Sundar wrote: On Thursday 18 August 2011 06:46 PM, Daniel Shahaf wrote: I tried your patch against https://svn.eu.apache.org/repos/asf/subversion/README (which uses a non-self

Re: [PATCH] get-location-segments.py would work on self-signed ssl servers too

2011-09-01 Thread Prabhu Gnana Sundar
On Monday 22 August 2011 09:37 AM, Prabhu Gnana Sundar wrote: On Thursday 18 August 2011 06:46 PM, Daniel Shahaf wrote: I tried your patch against https://svn.eu.apache.org/repos/asf/subversion/README (which uses a non-self-signed cert, but rather one for which the cert's hostname differs

Re: [PATCH] get-location-segments.py would work on self-signed ssl servers too

2011-08-21 Thread Prabhu Gnana Sundar
On Thursday 18 August 2011 06:46 PM, Daniel Shahaf wrote: I tried your patch against https://svn.eu.apache.org/repos/asf/subversion/README (which uses a non-self-signed cert, but rather one for which the cert's hostname differs from the URI's hostname), and it didn't seem to work: [[[ ./tools/

Re: [PATCH] get-location-segments.py would work on self-signed ssl servers too

2011-08-19 Thread Prabhu Gnana Sundar
On Thursday 18 August 2011 10:07 PM, Daniel Shahaf wrote: Prabhu Gnana Sundar wrote on Thu, Aug 18, 2011 at 21:55:28 +0530: On Thursday 18 August 2011 06:46 PM, Daniel Shahaf wrote: I tried your patch against https://svn.eu.apache.org/repos/asf/subversion/README (which uses a non-self-signed

Re: [PATCH] python script for issue #3961, fixing the bogus mergeinfo

2011-08-18 Thread Prabhu Gnana Sundar
Correcting the issue number as #3961... On Thursday 18 August 2011 08:32 PM, Prabhu Gnana Sundar wrote: Hi all, With reference to my earlier discussions in http://svn.haxx.se/dev/archive-2011-07/0432.shtml I am attaching a python script which would find the bogus mergeinfo and fix it

Re: [PATCH] get-location-segments.py would work on self-signed ssl servers too

2011-08-18 Thread Prabhu Gnana Sundar
On Thursday 18 August 2011 06:46 PM, Daniel Shahaf wrote: I tried your patch against https://svn.eu.apache.org/repos/asf/subversion/README (which uses a non-self-signed cert, but rather one for which the cert's hostname differs from the URI's hostname), and it didn't seem to work: [[[ ./tools/

[PATCH] python script for issue #396, fixing the bogus mergeinfo

2011-08-18 Thread Prabhu Gnana Sundar
Hi all, With reference to my earlier discussions in http://svn.haxx.se/dev/archive-2011-07/0432.shtml I am attaching a python script which would find the bogus mergeinfo and fix it. This script would eventually look for the location segments of the source paths against the respective revisio

[PATCH] get-location-segments.py would work on self-signed ssl servers too

2011-08-18 Thread Prabhu Gnana Sundar
). (prompt_func_ssl_unknown_cert): new callback function (prompt_func_simple_prompt): new callback function Patch by: Prabhu Gnana Sundar Index: tools/examples/get-location-segments.py === --- tools/examples/get-location-segments.py (revision 1153033

Help needed on setting the svn_auth_open using python bindings

2011-08-09 Thread Prabhu Gnana Sundar
Hi all, Currently we have the "get-location-segments.py" script in our repo which works fine in normal cases. But when we run it against a repo which throws the authentication challenge, the script fails with error code "170001" ("OPTIONS of 'https://some/path': authorization failed: Could

Re: Bogus mergeinfo in trunk

2011-08-02 Thread Prabhu Gnana Sundar
On Tuesday 02 August 2011 09:11 PM, Philip Martin wrote: Prabhu Gnana Sundar writes: I was in the process of writing a script which would record the mergeinfo and see if there are any bogus mergeinfos. When I ran my script against our trunk source I was able to see the following error

Bogus mergeinfo in trunk

2011-08-02 Thread Prabhu Gnana Sundar
Hi all, I was in the process of writing a script which would record the mergeinfo and see if there are any bogus mergeinfos. When I ran my script against our trunk source I was able to see the following error: svn.core.SubversionException: ("'/repos/asf/!svn/bc/1072301/subversion/trunk/subv

Re: (Possible) bug in the way we track the mergeinfo property

2011-07-15 Thread Prabhu Gnana Sundar
On Thursday 14 July 2011 09:18 PM, Paul Burba wrote: On Thu, Jul 14, 2011 at 11:35 AM, Prabhu Gnana Sundar wrote: Hi all, I am in the process of writing a script which would check for the mergeinfo of a path and see if the path is present through all the revisions mentioned in the mergeinfo

(Possible) bug in the way we track the mergeinfo property

2011-07-14 Thread Prabhu Gnana Sundar
Hi all, I am in the process of writing a script which would check for the mergeinfo of a path and see if the path is present through all the revisions mentioned in the mergeinfo property. If the path was not found for any revision range then the script would suggest(as of now) a better way to

[PATCH] Re: svn commit: r1141447 - /subversion/branches/svn-bisect/BRANCH-MILESTONES

2011-07-01 Thread Prabhu Gnana Sundar
r consistency of code, error[Not Started] -handling and error codes. - No need of a separate Branch-Milestone file * BRANCH-README Added the milestones for this branch. * BRANCH-MILESTONES Deleted the file and moved the contents to BRANCH-README file Patch by: Prabhu Gnana Sundar

[PATCH] remove --config-option argument from svnadmin

2011-05-23 Thread Prabhu Gnana Sundar
ption (main): Did not populate config_options in opt_state. It does not handle the --config-option argument. Patch by: Prabhu Gnana Sundar Suggested by: Kamesh Jayachandran Index: subversion/svnadmin/main.c === --- subversion

Re: [PATCH] - Remove unneeded code from svnadmin

2011-05-23 Thread Prabhu Gnana Sundar
On Monday 23 May 2011 02:02 PM, Stefan Sperling wrote: On Mon, May 23, 2011 at 01:08:28PM +0530, Prabhu Gnana Sundar wrote: Hi all, I have attached my recent patch along with this mail. Please share your views. Can you provide a log message, too? Sure Stefan :) Attaching the log

Re: [PATCH] - Remove unneeded code from svnadmin

2011-05-23 Thread Prabhu Gnana Sundar
Hi all, I have attached my recent patch along with this mail. Please share your views. Thanks and regards Prabhu On Saturday 21 May 2011 09:39 PM, Mark Phippard wrote: On Sat, May 21, 2011 at 11:12 AM, Kamesh Jayachandran wrote: On 05/20/2011 10:28 PM, Mark Phippard wrote: Log messa

Add usage functionality to a few scripts under the tools

2011-05-06 Thread Prabhu Gnana Sundar
name, value in opts: * tools/examples/check-modified.py invoke usage function if there are not enough args * tools/examples/geturl.py (usage): newly added to show the usage of the script (main): invoke usage function if there are not enough args * tools/examples/revplist.py (main): invoke usage function if there are not enough args Patch by: Prabhu Gnana Sundar

Re: [PATCH] New XFail test for issue 3781

2011-02-09 Thread Prabhu Gnana Sundar
e expected error was more specific to the http protocol. Patch by: Prabhu Gnana Sundar Reviewed by: Kamesh Jayachandran ]]] Index: subversion/tests/cmdline/authz_tests.py === --- subversion/tests/cmdline/authz_tests.py (revision 106

Re: [PATCH] New XFail test for issue 3781

2011-02-08 Thread Prabhu Gnana Sundar
l) + # Commit the file. + svntest.actions.run_and_verify_commit(wc_dir, +expected_output, +None, + None, +mu_path) + # Run the tests @@ -1108,6 +1201,7 @@ multiple_matches, wc_wc_copy_revert, authz_recursive_ls, + case_sensitive_authz, ] serial_only = True [[[ XFail testcase for the issue 3781 * subversion/tests/cmdline/authz_tests.py (case_sensitive_authz, test_list): New XFail test for the issue 3781 Patch by: Prabhu Gnana Sundar Reviewed by: Kamesh Jayachandran ]]]

[PATCH] New XFail test for issue 3781

2011-02-07 Thread Prabhu Gnana Sundar
mu_path) + ############ # Run the tests @@ -1092,6 +1184,8 @@ Skip(wc_wc_copy_revert, svntest.main.is_ra_type_file), Skip(authz_recursive_ls, svntest.main.is_ra_type_file), + XFail(Skip(case_sensitive_authz, + svntest.main.is_ra_type_file)), ] serial_only = True [[[ XFail testcase for the issue 3781 * subversion/tests/cmdline/authz_tests.py (case_sensitive_authz, test_list): New XFail test for the issue 3781 Patch by: Prabhu Gnana Sundar Reviewed by: Kamesh Jayachandran ]]]

Re: [PATCH] New XFail test for the issue 3781

2011-02-03 Thread Prabhu Gnana Sundar
Hi Daniel, Thank you for the comments... :) On Friday 04 February 2011 08:12 AM, Daniel Shahaf wrote: Prabhu Gnana Sundar wrote on Thu, Feb 03, 2011 at 16:53:54 +0530: Hi all, Currently, as per the issue 3781, "checkout" reads the authz file in *case insensitive* way, whereas &quo

Re: [PATCH] New XFail test for the issue 3781

2011-02-03 Thread Prabhu Gnana Sundar
On Thursday 03 February 2011 05:23 PM, Noorul Islam K M wrote: Prabhu Gnana Sundar writes: Hi all, Currently, as per the issue 3781, "checkout" reads the authz file in *case insensitive* way, whereas "commit" reads the authz file in *case sensitive* way. Here is

[PATCH] New XFail test for the issue 3781

2011-02-03 Thread Prabhu Gnana Sundar
e for the issue 3781 * subversion/tests/cmdline/authz_tests.py (case_insensitive_authz, test_list): New XFail test for the issue 3781 Patch by: Prabhu Gnana Sundar Suggested by: Kamesh Jayachandran ]]] Index: subversion/tests/cm

Re: [PATCH] pass NULL instead of an unused parameter

2011-01-11 Thread Prabhu Gnana Sundar
e): passed NULL instead of the 'config' value since it is never used in subversion/libsvn_repos/repos.c:svn_repos_create() deleted the 'config' apr_hash and did not populate it since it is never used. Patch by: Prabhu Gnana Sundar Suggested by: Kamesh Jayachandran ]]]

[PATCH] pass NULL instead of an unused parameter

2011-01-11 Thread Prabhu Gnana Sundar
e): passed NULL instead of the 'config' value since it is never used in subversion/libsvn_repos/repos.c:svn_repos_create() Patch by: Prabhu Gnana Sundar Suggested by: Kamesh Jayachandran ]]] Index: subversion/svnadmin/main.c ==

Re: [PATCH] make diff against copy-source by default

2011-01-07 Thread Prabhu Gnana Sundar
Hi Julian, On Fri, 2011-01-07 at 12:17 +, Julian Foad wrote: > I can't look into this in detail, but I have two thoughts: > > 1. Ideally, I would expect the structure of the diff code to be > something like: > > libsvn_client: > call libsvn_wc to get the WC file; > call libsvn_ra t

Re: [PATCH] make diff against copy-source by default

2011-01-07 Thread Prabhu Gnana Sundar
Hi Julian, On Thu, 2011-01-06 at 16:25 +0530, Prabhu Gnana Sundar wrote: > > Isn't it a layering violation for libsvn_wc to know about libsvn_ra? > > Maybe this needs to use callbacks or something, so that all the RA > > knowledge remains in libsvn_client. > >

Re: [PATCH] make diff against copy-source by default

2011-01-06 Thread Prabhu Gnana Sundar
Hi Julian, On Thu, 2011-01-06 at 14:22 +, Julian Foad wrote: > > Please let me know if I am not clear at any point. > > The tabular format is good but it would be easier to follow if instead > of "A" or "B" or "C" etc. you write "Shown as diff against source" or > "Shown as all lines added".

Re: [PATCH] make diff against copy-source by default

2011-01-06 Thread Prabhu Gnana Sundar
Hi Julian, On Wed, 2011-01-05 at 11:41 +, Julian Foad wrote: > On Thu, 2010-12-30, Prabhu Gnana Sundar wrote: > [...] > > I like this change, in principle. > Thank you :) > For example, maybe some tables > something like this would be a good way to summarize the

Re: [PATCH] '--version --quiet' should display only the version info in svnadmin, svnlook, svnsync, svndumpfilter, svnversion, svnserve

2011-01-05 Thread Prabhu Gnana Sundar
Hi Daniel, Since I am just now getting my feet wet with the subversion code, I am finding opportunities in everything I see... :) On Wed, 2011-01-05 at 15:11 +0200, Daniel Shahaf wrote: > Not to say that this patch is unnecessary (maybe you have a usecase > wherein it's required), but if you're l

[PATCH] '--version --quiet' should display only the version info in svnadmin, svnlook, svnsync, svndumpfilter, svnversion, svnserve

2011-01-05 Thread Prabhu Gnana Sundar
rve__options. (version): now accepts 'quiet' argument and handles the 'quiet' option. (main): added booleans 'quiet' and 'is_version'. handles the 'quiet' case. pass the 'quiet' option to version() functio

[PATCH] make diff against copy-source by default

2010-12-30 Thread Prabhu Gnana Sundar
Hi all, This patch is a follow up to the patch that I gave last month (November). Here is the link to the mail archive... http://mail-archives.apache.org/mod_mbox/subversion-dev/201011.mbox/% 3c1291110994.4021.66.ca...@prabhugnanasundar%3e After a few discussions about the inconsistent behaviour

[PATCH] fixes some path related deprecation warnings

2010-12-27 Thread Prabhu Gnana Sundar
add_file, open_file): use 'svn_dirent_join' instead of the deprecated function 'svn_path_join' Patch by: Prabhu Gnana Sundar ]]]

[PATCH] tweaked svnrdump to handle junk values with "--version"

2010-12-16 Thread Prabhu Gnana Sundar
;svnrdump help" would display a better header. (main): "svnrdump --version" would *not* accept junk inputs anymore. Patch by: Prabhu Gnana Sundar Suggested by: Kamesh Jayachandran ]]] Index: subversion/svnrdump/svnrdump.c

Re: [PATCH] enhance svn diff by adding --diff-copy-from switch

2010-12-16 Thread Prabhu Gnana Sundar
oping to get back to solve this problem in a much better new patch :) Thanks and regards Prabhu On Thu, 2010-12-16 at 23:46 +1100, Gavin Beau Baumanis wrote: > Ping. This patch has received no more comments. > > Gavin "Beau" Baumanis > > > > On 30/11/2010, at 12

[PATCH] clears a deprecation warning during "make"

2010-12-16 Thread Prabhu Gnana Sundar
cks); hi; hi = apr_hash_next(hi)) { [[[ Clear a deprecation warning during "make". * subversion/svnadmin/main.c subcommand_lslocks(): svn_repos_fs_get_locks is deprecated, hence using the new svn_repos_fs_get_locks2 with depth as infinity. Patch by: Prabhu Gnana Sundar Suggested by: Kamesh Jayachandran ]]]

[PATCH] svnrdump "help" displays subcommand-specific documentation

2010-12-15 Thread Prabhu Gnana Sundar
n_pool_destroy(pool); + exit(EXIT_FAILURE); +} + } } - /* Check that the subcommand wasn't passed any inappropriate options. */ for (i = 0; i < received_opts->nelts; i++) { [[[ Make svnrdump display the help manual correctly. * subversion/svnrdump/svnrdump.c main(): set the option baton and display the help manual for the corresponding subcommand. Patch by: Prabhu Gnana Sundar Suggested by: Kamesh Jayachandran ]]]

Re: [PATCH] fix a compilation warning

2010-12-09 Thread Prabhu Gnana Sundar
Hi all, I am sorry for the delayed reply and the carelessness. Initially, I did *not* have much context to comment on the patch. Just because the svn_client_relocate() was *deprecated* and it uses svn_client_relocate2() to implement itself in deprecated.c by hardcoding ignore_externals as TRUE,

[PATCH] fix a compilation warning

2010-12-08 Thread Prabhu Gnana Sundar
, TRUE, ctx, pool)); anchor_url = corrected_url; } [[[ fix a compiler warning. * subversion/libsvn_client/update.c (update_internal): changed the 'relocate' to 'relocate2' since 'relocate' is deprecated. Patch by: Prabhu Gnana Sundar Suggested by: Kamesh Jayachandran ]]]

[PATCH] enhance diff to make it behave uniformly

2010-11-30 Thread Prabhu Gnana Sundar
os_repos): pass false for 'diff_copy_from' to svn_ra_do_diff4 function. (svn_client_diff5): introduced the 'diff_copy_from' argument and pass it to do_diff function. (svn_client_diff_peg5): introduced the 'diff_copy_from' argument and pass it to do_diff function. * subversion/libsvn_ra_neon/ra_neon.h (svn_ra_neon__do_diff): introduced the 'diff_copy_from' argument. * subversion/libsvn_ra_neon/fetch.c (svn_ra_neon__do_diff): introduced the 'diff_copy_from' argument and pass it to make_reporter. * subversion/libsvn_ra_serf/ra_serf.h (svn_ra_serf__do_diff): introduced the 'diff_copy_from' argument. * subversion/libsvn_ra_serf/update.c (svn_ra_serf__do_diff): introduced the 'diff_copy_from' argument and pass it to make_update_reporter. * subversion/svnserve/serve.c (diff): introduced the 'diff_copy_from' argument and pass it to accept_reporter. Patch by: Prabhu Gnana Sundar Suggested by: Kamesh Jayachandran ]]]

RE: [PATCH] enhance svn diff by adding --diff-copy-from switch

2010-11-29 Thread Prabhu Gnana Sundar
+, Julian Foad wrote: > On Sun, 2010-11-28, Prabhu Gnana Sundar Ponnarasu wrote: > > [[[ > > Make svn diff to accept "--diff-copy-from" inorder to compare/diff > > against the copy-source file. > > Hi Prabhu. > > I'm not clear about the precise

[PATCH] enhance "svn diff" by adding "--diff-copy-from" switch

2010-11-29 Thread Prabhu Gnana Sundar
rgument and pass it to make_reporter. * subversion/libsvn_ra_serf/ra_serf.h (svn_ra_serf__do_diff): introduced the 'diff_copy_from' argument. * subversion/libsvn_ra_serf/update.c (svn_ra_serf__do_diff): introduced the 'diff_copy_f

RE: [PATCH] enhance svn diff by adding --diff-copy-from switch

2010-11-28 Thread Prabhu Gnana Sundar Ponnarasu
(svn_ra_neon__do_diff): introduced the 'diff_copy_from' argument and pass it to make_reporter. * subversion/libsvn_ra_serf/ra_serf.h (svn_ra_serf__do_diff): introduced the 'diff_copy_from' argument. * subversion/libsvn_ra_serf/update.c (svn_ra_

Re: [PATCH] enhance svn diff by adding --diff-copy-from switch

2010-11-28 Thread Prabhu Gnana Sundar Ponnarasu
Sorry Dan and all, There is some problem with my browser. Sorry for the inconvenience... Thanks and regards Prabhu -Original Message- From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] Sent: Sun 11/28/2010 5:00 PM To: Prabhu Gnana Sundar Ponnarasu Cc: dev@subversion.apache.org

RE: [PATCH] enhance svn diff by adding --diff-copy-from switch

2010-11-28 Thread Prabhu Gnana Sundar Ponnarasu
Sorry Dan, I don't know how I missed the attachments. I have attached it now. Please check out. Thanks and regards Prabhu -Original Message- From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] Sent: Sun 11/28/2010 5:00 PM To: Prabhu Gnana Sundar Ponnarasu Cc

[PATCH] enhance svn diff by adding --diff-copy-from switch

2010-11-28 Thread Prabhu Gnana Sundar Ponnarasu
Hi, This patch enhances the current "svn diff" by adding a new "--diff-copy-from" switch. I have attached the patch and the log message along with this mail. Please review and share your comments on the same. Thanks and regards Prabhu

Re: Will send_copyfrom_args be reverted for 'ra' layers too just like in issue #3711

2010-11-24 Thread Prabhu Gnana Sundar
Hi, Stefan, we are quite aware of the case you mentioned in your previous mail. There the diff is between two explicit paths. I guess the below screenshot would make the intention behind the work much clearer. Here is my screenshot... $ vi file1 $ svn add file1 A file1 $ svn ci -m "adde