l amend it in subsequent revisions. Thanks
>for the patch.
>
>Daniel
No. I get it now. It's better to check if it's a delete and easy out from
within the validation code so all callers of the function will benefit. They
don't have to perform the check themselves.
Regards,
Arwin Arni
On 06/20/2013 07:01 PM, Julian Foad wrote:
Arwin Arni wrote:
Properties are validated regardless of the action on the property. This poses a
problem when it comes to very old repositories that contain "invalid"
properties committed by very old clients that didn't perform th
On 06/20/2013 06:46 PM, Daniel Shahaf wrote:
On Thu, Jun 20, 2013 at 06:15:52PM +0530, Arwin Arni wrote:
Hi,
Properties are validated regardless of the action on the property.
This poses a problem when it comes to very old repositories that
contain "invalid" properties committed b
ity to cleanup after such an errant change has
already occurred" ?
Regards,
Arwin Arni
alidity
of the property only during addition and modification. Validation during
deletion prevents the user from removing what he recognizes as an
invalid property.
Regards,
Arwin Arni
* subversion/libsvn_repos/fs-wrap.c
(svn_repos_fs_change_rev_prop4): Don't valida
Here's the typo fix.
On 12/27/2012 12:52 PM, Arwin Arni wrote:
Oops. I got confused with the revision in which the change was made in
trunk and the revision in which it was merged to the branch.
On 12/27/2012 12:41 PM, Ben Reser wrote:
On Wed, Dec 26, 2012 at 10:35 PM, Arwin Arni
Oops. I got confused with the revision in which the change was made in
trunk and the revision in which it was merged to the branch.
On 12/27/2012 12:41 PM, Ben Reser wrote:
On Wed, Dec 26, 2012 at 10:35 PM, Arwin Arni wrote:
Sorry,
Moved the change to the wrong section. Here'
On 12/27/2012 12:00 PM, Arwin Arni wrote:
Hi,
Fixing a couple of mistakes in the CHANGES file.
Regards,
Arwin Arni
Sorry,
Moved the change to the wrong section. Here's the corrected patch.
* subversion/CHANGES
Fixed a chronological mistake. (1.7.7 has r1237779)
Fixed a typo. (r1399
Hi,
Fixing a couple of mistakes in the CHANGES file.
Regards,
Arwin Arni
* subversion/CHANGES
Fixed a chronological mistake. (1.7.7 has r1237779)
Fixed a typo. (r139917 is r1399174)
Patch by: Arwin Arni
Index: CHANGES
Hi,
The news page shows the date as 2012-02-13 for the release of Subversion
1.7.4. The attached patch fixes this.
Regards,
Arwin Arni
* site/publish/news.html
Fix a date typo.
Patch by: Arwin Arni
Index: news.html
On Tuesday 27 September 2011 02:14 PM, Philip Martin wrote:
Arwin Arni writes:
I've attached a shell script which will help you reproduce this
easily. Also, I'm in the process of writing a test-case for this, but
I don't know which set of tests it belongs to - authz_tests.py o
Also worth noting that the current trunk behaves the same way 1.7.x does.
On Sep 27, 2011 11:50 AM, "Arwin Arni" wrote:
>
> Hi All,
>
> Here is the issue:
>
> Repo contains:
>
> .
> `-- A
> `-- B
>
> This was committed by the user 'admin
doing something nasty,
which I believe causes 'info' to Segfault.
Regards,
Arwin Arni
authz-cp-fail.sh
Description: application/shellscript
* subversion/libsvn_diff/diff_memory.c
(datasource_get_next_token): adapt to renamed adler32() function
* subversion/libsvn_diff/diff_file.c
(datasource_get_next_token): dito
--------
Regards,
Arwin Arni
On Friday 01 July 2011 12:32 PM, Prabhu Gnana Sundar wrote:
On Thursday 30 June 2011 08:19 PM, C. Michael Pilato wrote:
On 06/30/2011 04:58 AM, ar...@apache.org wrote:
Author: arwin
Date: Thu Jun 30 08:58:11 2011
New Revision: 1141447
URL: http://svn.apache.org/viewvc?rev=1141447&view=rev
Log:
On Tuesday 28 June 2011 09:30 PM, Daniel Shahaf wrote:
Arwin Arni wrote on Tue, Jun 28, 2011 at 15:45:04 +0530:
On Tuesday 28 June 2011 03:36 PM, Noorul Islam K M wrote:
Stefan Sperling writes:
On Tue, Jun 28, 2011 at 03:12:22PM +0530, Arwin Arni wrote:
On Tuesday 28 June 2011 03:01 PM
On Tuesday 28 June 2011 05:15 PM, Stefan Sperling wrote:
On Tue, Jun 28, 2011 at 03:36:32PM +0530, Arwin Arni wrote:
On Tuesday 28 June 2011 03:13 PM, Stefan Sperling wrote:
1) the working copy has no local mods
2) the working copy has no switched subtrees
3) the working copy is at a
On Tuesday 28 June 2011 03:36 PM, Noorul Islam K M wrote:
Stefan Sperling writes:
On Tue, Jun 28, 2011 at 03:12:22PM +0530, Arwin Arni wrote:
On Tuesday 28 June 2011 03:01 PM, Noorul Islam K M wrote:
+svn bisect start [-rN[:M]]
+
When we discussed you had a concern that above syntax is
On Tuesday 28 June 2011 03:32 PM, Stefan Sperling wrote:
On Tue, Jun 28, 2011 at 03:12:22PM +0530, Arwin Arni wrote:
On Tuesday 28 June 2011 03:01 PM, Noorul Islam K M wrote:
+svn bisect start [-rN[:M]]
+
When we discussed you had a concern that above syntax is different from
the normal svn
rm to the way git bisect does
+things.
It's a good idea to stick to these values if git also uses them.
Sure. git bisect does make use of these codes. So I think we'll stick.
Regards,
Arwin Arni
On Wednesday 22 June 2011 02:43 AM, Erik Huelsmann wrote:
Hi Arwin,
On Tue, Jun 21, 2011 at 9:45 AM, Arwin Arni wrote:
3. Will this feature be considered at all (if it is any good) or am I simply
doing something to exercise my brain cells?
Actually, I think it'd be a good idea to h
On Tuesday 21 June 2011 03:11 PM, Julian Foad wrote:
On Tue, 2011-06-21 at 11:37 +0200, Johan Corveleyn wrote:
On Tue, Jun 21, 2011 at 11:34 AM, Arwin Arni wrote:
On Tuesday 21 June 2011 02:51 PM, Daniel Shahaf wrote:
Please convince me why having svn_client_bisect() is needed.
There are
On Tuesday 21 June 2011 02:51 PM, Daniel Shahaf wrote:
Please convince me why having svn_client_bisect() is needed.
There are already THREE scripts out there that implement cmdline 'svn bisect':
one on CPAN, one in Peter's Debian package, one that Julian just posted.
(And we got one sent to the
On Tuesday 21 June 2011 02:35 PM, Stefan Sperling wrote:
On Tue, Jun 21, 2011 at 02:26:28PM +0530, Arwin Arni wrote:
Stefan Sperling wrote:
I'd like to offer you commit access to a branch in our repository
so you work on this there if you like.
I'd really appreciate that. Than
plemented here is to support a
third response, "unable to test", and skip such revisions. I tried
thinking about an algorithm to do that nicely, but didn't get anywhere
really concrete.
- Julian
Stefan Sperling wrote:
On Tue, Jun 21, 2011 at 01:15:06PM +0530, Arwin Arni wrote:
Hi
my brain cells?
Regards,
Arwin Arni
On Friday 03 June 2011 05:47 PM, Bert Huijben wrote:
-Original Message-
From: Mark Phippard [mailto:markp...@gmail.com]
Sent: vrijdag 3 juni 2011 14:13
To: Bert Huijben; dev@subversion.apache.org
Subject: Re: Stuck between relocate and upgrade
I do not get the impression that 1.4 is
I remove the prefix location. (rm -rf
/home/arwin/Binaries/svn_trunk).
Why should the make process depend on what exists at the target?
Arwin Arni
On Tuesday 24 May 2011 09:00 PM, C. Michael Pilato wrote:
On 05/24/2011 04:23 AM, Stefan Sperling wrote:
On Tue, May 24, 2011 at 12:04:26PM +0530, Arwin Arni wrote:
Why can't we send the recorded checksum from the server instead of
sending the whole file and then calculating it on the c
On Tuesday 24 May 2011 12:58 AM, Stefan Sperling wrote:
On Mon, May 23, 2011 at 11:07:50PM +0400, Konstantin Kolinko wrote:
In svn 1.7 there is pristine storage area in the working copy, where
all present files are stored by their checksums. If I understand this
pristine storage correctly, if yo
On Thursday 19 May 2011 08:19 PM, Hyrum K Wright wrote:
On Thu, May 19, 2011 at 3:48 PM, Arwin Arni wrote:
In our implementation of SVN_ERR_ASSERT, we do:
#define SVN_ERR_ASSERT(expr)\
do
) regardless of maintainer-mode?
Shouldn't there be some difference between maintainer-mode and production?
Am I missing something here?
Regards,
Arwin Arni
On Wednesday 18 May 2011 08:03 PM, Paul Burba wrote:
On Wed, May 18, 2011 at 9:15 AM, Arwin Arni wrote:
Hi All,
I have attached a test case for Issue 3867
(http://subversion.tigris.org/issues/show_bug.cgi?id=3867)
Issue Summary:
reintegrate merges create mergeinfo for non-existent paths
Hi All,
I have attached a test case for Issue 3867
(http://subversion.tigris.org/issues/show_bug.cgi?id=3867)
Issue Summary:
reintegrate merges create mergeinfo for non-existent paths
Regards,
Arwin Arni
Index: subversion/tests/cmdline/merge_reintegrate_tests.py
Hi All,
In the process of examining the file descriptor leak in Issue#3870
(http://subversion.tigris.org/issues/show_bug.cgi?id=3870), I came
across an error leak. This patch fixes the leak..
Regards,
Arwin Arni
Index: subversion/libsvn_ra/util.c
he
problem and he was going to debug and see where it is failing.
I have created an Issue (Issue#3870
<http://subversion.tigris.org/issues/show_bug.cgi?id=3870>) and
submitted a test case to dev@
(http://svn.haxx.se/dev/archive-2011-05/0086.shtml).
Thanks and Regards,
Arwin Arni
Hi All,
This patch adds a test to svnsync_tests.py, to showcase issue #3870:
(http://subversion.tigris.org/issues/show_bug.cgi?id=3870)
"File descriptor leaks during svnsync"
Regards,
Arwin Arni
Index: subversion/tests/cmdline/svnsyn
eve is known only
to the WC and the master and *not* the out-of-date slave) and cases 4 and 5
PASS.
If neon will be taught in the near future how to operate without the dav-cache,
then this is fine. For now however, I think we should not clear this cache but
rather populate it with the relevant information so that ra_layers can be
switched at will.
Regards,
Arwin Arni
ase 5
svn ci -m "first mod" file --config-option servers:global:http-library=neon
echo "second mod" >> file
svn ci -m "second mod" file --config-option servers:global:http-library=serf
echo "third mod" >> file
svn ci -m "third mod" file
On Monday 18 April 2011 04:05 PM, Arwin Arni wrote:
I'll shortly file an issue in the tigris tracker for this.
Filed Issue #3860 and set the target milestone to 1.7-consider
Regards,
Arwin Arni
^/branches.
i.e Coder 1 does a commit to branches/some-other-branch (master has
received the commit, slave hasn't yet synced)
Coder 2 tries to create a new branch via above command. It fails.
I'll shortly file an issue in the tigris tracker for this.
Regards,
Arwin Arni
Index: subv
Hi All,
The minimal serf version that our trunk requires is 0.7.1. However, the
get-deps.sh script still fetches 0.7.0. Here's a patch to bump this
version. This makes it easier for first-timers to compile and build
subversion.
Regards,
Arwin Arni
Index: get-de
se of enable-maintainer-mode...
Regards,
Arwin Arni
=== TEST RESULTS ==
SVN Version: 1.6.6
(This is what Canonical provides for Ubuntu 10.04)
Tests: Basic Tests
Action TimeMillis
-- - -
Checkou
Arwin Arni wrote:
On Tuesday 15 March 2011 08:34 PM, Julian Foad wrote:
On Wed, 2011-03-02, Arwin Arni wrote:
In my effort to understand the delta editor API, I took it upon myself
to try and implement the --dry-run flag for "svn update".
http://subversion.tigris.org/issues/show_
On Tuesday 15 March 2011 08:34 PM, Julian Foad wrote:
On Wed, 2011-03-02, Arwin Arni wrote:
In my effort to understand the delta editor API, I took it upon myself
to try and implement the --dry-run flag for "svn update".
http://subversion.tigris.org/issues/show_bug.cgi?id=2491
On Monday 14 March 2011 11:40 AM, Arwin Arni wrote:
On Monday 14 March 2011 02:47 AM, Daniel Becroft wrote:
On Mon, Mar 14, 2011 at 7:06 AM, Daniel Becroft <mailto:djcbecr...@gmail.com>> wrote:
On Sat, Mar 12, 2011 at 1:50 AM, C. Michael Pilato
mailto:cmpil...@collab.ne
On Monday 14 March 2011 02:47 AM, Daniel Becroft wrote:
On Mon, Mar 14, 2011 at 7:06 AM, Daniel Becroft <mailto:djcbecr...@gmail.com>> wrote:
On Sat, Mar 12, 2011 at 1:50 AM, C. Michael Pilato
mailto:cmpil...@collab.net>> wrote:
On 03/11/2011 10:03 AM, A
On Friday 11 March 2011 08:26 PM, Arwin Arni wrote:
Hi All,
This patch adds a test to make sure that conflict resolution files are
not created in the event of a *dry-run* merge that has binary file
conflicts.
The relevant discussion on dev@ is here ->
http://svn.haxx.se/dev/archive-2011
Hi All,
This patch adds a test to make sure that conflict resolution files are
not created in the event of a *dry-run* merge that has binary file
conflicts.
The relevant discussion on dev@ is here ->
http://svn.haxx.se/dev/archive-2011-03/0145.shtml
Regards,
Arwin Arni
On Friday 04 March 2011 05:15 PM, Philip Martin wrote:
Arwin Arni writes:
On Friday 04 March 2011 04:52 PM, Philip Martin wrote:
Arwin Arni writes:
Post this fix, I noticed that **merge --dry-run** throws an
interactive conflict resolution dialog and create the merge-left and
merge-right
On Friday 04 March 2011 04:52 PM, Philip Martin wrote:
Arwin Arni writes:
Post this fix, I noticed that **merge --dry-run** throws an
interactive conflict resolution dialog and create the merge-left and
merge-right files.
Does this apply to all files or just binary files?
This applies only
side-effect of this experiment, I noticed this :
Removing these files causes the node to lose it's conflict state (why
should the status command rely on the presence/absence of conflict
resolution files to display the status).
Regards,
Arwin Arni
s and regards,
Arwin Arni
un parameter all the way to the API.
svn_client_update4 accepts this boolean and the notify_func provided by
the client does the notification. I don't understand why this wouldn't
help any other Subversion client.
Thanks and Regards,
Arwin Arni
On Friday 11 February 2011 07:06 PM, Kamesh Jayachandran wrote:
Thanks Arwin. Committed at r1069791.
With regards
Kamesh Jayachandran
Here is the follow-up patch that fixes the deprecated calls of
svn_config_read.
Regards,
Arwin Arni
Index: subversion/libsvn_subr/config.c
On Thursday 10 February 2011 12:48 PM, Arwin Arni wrote:
On Wednesday 09 February 2011 09:21 PM, Arwin Arni wrote:
Hi All,
Here's the patch for the implementation of the logic.
Regards,
Arwin Arni
Sorry, Please ignore the previous patch. There was a stray caller of
svn_config_create (
On Wednesday 09 February 2011 09:21 PM, Arwin Arni wrote:
Hi All,
Here's the patch for the implementation of the logic.
Regards,
Arwin Arni
Sorry, Please ignore the previous patch. There was a stray caller of
svn_config_create (whose signature I changed and didn't rev as it was
Hi All,
Here's the patch for the implementation of the logic.
Regards,
Arwin Arni
Index: subversion/libsvn_subr/config.c
===
--- subversion/libsvn_subr/config.c (revision 1068869)
+++ subversion/libsvn_subr/con
On Wednesday 09 February 2011 07:02 PM, Daniel Shahaf wrote:
Arwin Arni wrote on Wed, Feb 09, 2011 at 17:39:55 +0530:
* subversion/libsvn_repos/authz.c,
subversion/tests/libsvn_subr/cache-test.c,
subversion/tests/libsvn_subr/config-test.c,
subversion/tests/cmdline/atomic-ra-revprop
s.
* subversion/libsvn_repos/authz.c,
subversion/tests/libsvn_subr/cache-test.c,
subversion/tests/libsvn_subr/config-test.c,
subversion/tests/cmdline/atomic-ra-revprop-change.c,
subversion/svnserve/serve.c,
subversion/libsvn_fs_fs/fs_fs.c
(svn_repos_authz_read, test_memcache_basic, test_memcache_longkey,
test_text_retrieval,test_boolean_retrieval, test_has_section,
construct_config, load_configs, read_config) : Fixed callers.
Patch by: Arwin Arni
On Monday 07 February 2011 06:37 PM, Arwin Arni wrote:
Hi All,
I recently discovered what appears to be a bug.
When I blame a file that was added to a branch (say branch A) via a
merge (from, say branch B), the revisions column is populated with the
blame of the original file (as it is in
anches/performance.
This has been the case since 1.4.x. (That's as far back as I have tested
it.)
Should this be documented somewhere/ should the behavior be changed to
be uniform for both newly added files and modified files?
Regards,
Arwin Arni
ors at the definition?
Regards,
Arwin Arni
On Monday 31 January 2011 08:49 PM, C. Michael Pilato wrote:
On 01/31/2011 10:05 AM, Arwin Arni wrote:
On Monday 31 January 2011 08:01 PM, C. Michael Pilato wrote:
On 01/31/2011 04:48 AM, Arwin Arni wrote:
Should I add parameters for options / values / options& values to decide
the cas
On Monday 31 January 2011 08:01 PM, C. Michael Pilato wrote:
On 01/31/2011 04:48 AM, Arwin Arni wrote:
Hi All,
This patch revs subversion/libsvn_subr/config.c:svn_config_read to
svn_config_read2 to accept a *boolean* called *section_names_case_sensitive*.
When TRUE, the section names are
nsitively.
Should I add parameters for options / values / options & values to
decide the case or shall I use a common parameter for all(sections,
options & values) ?
Kindly share your thoughts on this.
Regards,
Arwin Arni
Index: subversion/lib
On Friday 21 January 2011 02:41 AM, anatoly techtonik wrote:
On Thu, Jan 20, 2011 at 8:29 PM, Hyrum K Wright wrote:
On Thu, Jan 20, 2011 at 3:41 AM, Arwin Arni wrote:
On Saturday 15 January 2011 12:24 AM, anatoly techtonik wrote:
Hello,
How can I know if a file is not present in specific
think you're looking for "svn info".
To check if a file existed at revision X,
svn info ^/path/to/file@X (from inside the wc)
svn info URL@X
Regards,
Arwin Arni
On Wednesday 19 January 2011 09:46 PM, C. Michael Pilato wrote:
On 01/19/2011 10:52 AM, Arwin Arni wrote:
Hi All,
Authz section names(and paths too) are parsed/loaded in a case insensitive way.
So they need to be compared in a case-insensitive way.
Following functions do authz,
1
"path"
is NULL (for MKACTIVITY, DELETE).
'1' is leaving it to svn_config_enumerate2() to handle case
(in)sensitiveness.
'2' is explicitly comparing each config item in a case sensitive way.
My patch is just fixing the '2' to check it in a case inse
On Wednesday 19 January 2011 08:58 PM, C. Michael Pilato wrote:
On 01/19/2011 08:48 AM, Arwin Arni wrote:
Hi All,
There are a couple of functions (authz_get_global_access,
authz_global_parse_section) inside libsvn_repos/authz.c which completely
threw me off track by virtue of their names. The
. What they actually do is check to see if the user has *any*
kind of access to *any* part of the repository.
This patch renames these functions to convey a better meaning, and also
inserts a comment that explains the function better. I have attached the
patch and log message.
Regards,
Arwin Arni
e parts that I really
find difficult to assimilate. I think time spent *earlier* to sanitize
the code is time better spent, than trying to read the mind of the
original implementer at a *later* point in time.
Regards,
Arwin Arni
On Tuesday 18 January 2011 07:26 AM, Gavin Beau Baumanis wrote:
Hi Br
Hi Kamesh,
Here is the new patch and log message and the .tar.bz2 file.
Regards,
Arwin Arni
Arwin,
Sorry, I guess my description can be reduced to even simple form.
I mean we do not need *failed commit* condition, just scheduled change
alone is enough.
Can you provide a new patch which
.tar.bz2 file to be
added to
subversion/tests/cmdline/upgrade_tests_data/
Regards,
Arwin Arni
Index: subversion/tests/cmdline/upgrade_tests.py
===
--- subversion/tests/cmdline/upgrade_tests.py (revision 1053802)
+++ subv
the patch and the log message. Please review and respond.
Regards,
Arwin Arni
Index: subversion/libsvn_wc/update_editor.c
===
--- subversion/libsvn_wc/update_editor.c(revision 1053802)
+++ subversion/libsvn_wc/update_editor.c
*relevant* code that I understand as being unreachable. I have attached
the patch and a log message. Please review and respond.
Regards,
Arwin Arni
[[[
Removed a redundant member (skip_descendants) from the dir baton
and removed *relevent* unreachable code.
* subversion/libsvn_wc
cksum);
-}
else
{
SVN_ERR_ASSERT(! fb->new_text_base_sha1_checksum
[[[
Removed a redundant member (added_with_history) from the file baton
and removed *relevent* unreachable code.
* subversion/libsvn_wc/update_editor.c
(struct file_baton): Removed 'added_with_history'.
(merge_file, close_file): Removed unreachable code.
Patch by: Arwin Arni
]]]
On Monday 08 November 2010 07:57 PM, Arwin Arni wrote:
Hi All,
I am a new-comer to the Subversion code-base. I was looking at some of the
header files (svn_path.h) and wanted to use some of the functions
(svn_path_join()) and noticed that they were deprecated. I thought it
would be nice to have
,
svn_path_url_add_component)
Patch by: Arwin Arni
]]]
Index: subversion/include/svn_path.h
===
--- subversion/include/svn_path.h(revision 1032465)
+++ subversion/include/svn_path.h(working copy)
@@ -64,6 +64,10 @@
/** Convert @a path from
80 matches
Mail list logo
