Re: svn upgrade segfaults

[Arwin Arni]

On Thursday 30 December 2010 09:35 PM, Kamesh Jayachandran wrote:

Hi All,

I did the following.

cd /tmp
cd svn-1.6 co file:///repo/abc
touch abc/test
svn-1.6 add abc/test


svn-1.6 ci -m "msg"

svn-1.7 upgrade
Segfaults

My svn-1.7 trunk build corresponds to 1053813:1053833

With regards
Kamesh Jayachandran

#Make sure below commit fails either by a pre-commit hook or File system perm error, we just need this to fail.

Hi Kamesh,




subversion/tests/cmdline/upgrade_tests_data/

Regards,
Arwin Arni


Index: subversion/tests/cmdline/upgrade_tests.py
===================================================================
--- subversion/tests/cmdline/upgrade_tests.py   (revision 1053802)
+++ subversion/tests/cmdline/upgrade_tests.py   (working copy)
@@ -831,6 +831,17 @@
       [sbox.ospath('B/f'), '958eb2d755df2d9e0de6f7b835aec16b64d83f6f'],
       [sbox.ospath('B/g'), '395dfb603d8a4e0348d0b082803f2b7426c76eb9']])
 
+def post_failed_commit_upgrade(sbox):
+  "upgrade after a commit failed"
+  
+  sbox.build(create_wc = False)
+  wc_dir = sbox.wc_dir
+  replace_sbox_with_tarfile(sbox, 'post_failed_commit_upgrade.tar.bz2')
+
+  svntest.actions.run_and_verify_svn(None, None, [],
+                                     'upgrade', sbox.wc_dir)
+  
+   
 ########################################################################
 # Run the tests
 
@@ -855,6 +866,7 @@
               upgrade_tree_conflict_data,
               delete_in_copy_upgrade,
               replaced_files,
+              XFail(post_failed_commit_upgrade),
              ]
 
 

[[[
Adds an XFail test (post_failed_commit_upgrade) in 
upgrade_tests.py
* subversion/tests/cmdline/upgrade_tests_data/post_failed_commit_upgrade.tar.bz2
  Added this .tar.bz2 consumed by upgrade_tests.py

* subversion/tests/cmdline/upgrade_tests.py
  Added post_failed_commit_upgrade test which reproduces
  a Segmentation Fault that occurs when trying to upgrade
  a working copy (1.6.x to 1.7.x) after a commit failure.

Patch by: Arwin Arni <arwin{_AT_}collab.net>
]]]

I've written an XFail test case which reproduces this Seg Fault in upgrade_tests.py I've attached the patch + log message and also a .tar.bz2 file to be added to

post_failed_commit_upgrade.tar.bz2
Description: application/bzip