Hi All,

In the process of examining the file descriptor leak in Issue#3870 (http://subversion.tigris.org/issues/show_bug.cgi?id=3870), I came across an error leak. This patch fixes the leak..

Regards,
Arwin Arni
Index: subversion/libsvn_ra/util.c
===================================================================
--- subversion/libsvn_ra/util.c (revision 1099706)
+++ subversion/libsvn_ra/util.c (working copy)
@@ -99,9 +99,15 @@
                                     be_atomic ? &mylocktoken : NULL, NULL,
                                     scratch_pool);
       if (is_atomicity_error(err))
-        return svn_error_createf(err->apr_err, err,
-                                 _("Lock was stolen by '%s'; unable to "
-                                   "remove it"), reposlocktoken->data);
+        {
+          return svn_error_createf(err->apr_err, err,
+                                   _("Lock was stolen by '%s'; unable to "
+                                     "remove it"), reposlocktoken->data);
+        }
+      else if (err)
+        {
+          return(err)
+        }
     }
 
   return SVN_NO_ERROR;
* subversion/libsvn_ra/util.c
  (svn_ra__release_operational_lock): Handle a previously unhandled error.

Patch by: Arwin Arni <arwin{_AT_}collab.net>

Reply via email to