Was trying to look at a commit that was in another part of the ASF
repo today. Wanted to see the log and the diff. So hey I just do the
following in my command line (trunk SVN in this case) and I get:
[[[
$ svn-trunk log -c r1464241 --diff http://svn.apache.org/repos/asf
Two nits:
bre...@apache.org wrote on Thu, Apr 04, 2013 at 02:56:02 -:
> +of computer system security vulnerabilities. href="http://www.first.org/";>
> +FIRST maintains the the href="http://www.first.org/cvss/cvss-guide.html";>
> +documentation for the standard.
Should be instead:
...
On Wed, Apr 3, 2013 at 4:04 AM, Stefan Sperling wrote:
> To refresh our collective memory, the current trunk code does:
> - prevent newlines from entering filenames at the fsfs layer
> - prevent control characters from entering filenames at the repos layer
+1, I'd prefer that the fs layer was c
You should apply the later one. The check for the kind is redundant.
Just before this check we call svn_fs_base__dag_file_checksum() and
specify that we want tb->base_checksum->kind. Ultimately, this calls
svn_fs_base__rep_contents_checksums() which just does a
svn_checksum_dup on the checksum i
Hi guys,
Saw my name mentioned in IRC regarding caching svn_*_t.
In our custom svn RPC server that exposes svn_repos_t and svn_fs_t, we
cache svn_repos_t, svn_fs_root_t (for both revisions and txns).
I pulled some stats from our live server, here is the svn_repos_t cache:
Max=238
N=238
InUse
Hi Stefan,
I appreciate the immense help and guidance given by the subversion
community and agree that the tasks I have been pursuing haven't been
particularly easy for me (although I did cater the confidence that i will
be able to catch up.). You are right in saying that I would instead need to
fo
Bert Huijben wrote on Wed, Apr 03, 2013 at 22:19:09 +0200:
>
>
> > -Original Message-
> > From: Ivan Zhakov [mailto:i...@visualsvn.com]
> > Sent: woensdag 3 april 2013 21:41
> > To: Mark Phippard
> > Cc: Subversion Development
> > Subject: Re: svnadmin info command was: svn commit: r14640
As part of http://subversion.tigris.org/issues/show_bug.cgi?id=4344 I
was playing with a BDB repository created by driving the svn_fs API
directly in repos-test.c:node_locations2. This creates a revision where
a file has no checksum. A subsequent commit that modifies the file can
SEGV:
Program r
cmpilato: any reason r1464137 didn't include
load-fs-vtable.c:close_revision ?
cmpilato: (I did mention it in my email...)
danielsh: oversight.
i'm clearly failing to multitask today. :-(
No time to fix this at this very moment. Thank you, dear dev-list, for
being my TODO list.
--
C. Michae
> -Original Message-
> From: Ivan Zhakov [mailto:i...@visualsvn.com]
> Sent: woensdag 3 april 2013 21:41
> To: Mark Phippard
> Cc: Subversion Development
> Subject: Re: svnadmin info command was: svn commit: r1464089 -
> /subversion/branches/fsfs-format7/BRANCH-README
>
> On Wed, Apr 3,
On Wed, Apr 03, 2013 at 03:49:03PM -0400, C. Michael Pilato wrote:
> On 04/03/2013 03:14 PM, Bert Huijben wrote:
> > I can???t really see it using just the context in this patch, but doesn???t
> > this
> > undo the don???t parse if no hook script exists patch from Ivan?
>
> Yes, it does. Bummer.
On 04/03/2013 03:43 PM, Bert Huijben wrote:
> I don't think we really have a hybrid story for keyring, gnome, kde. We
> store everything in there (and don't create a file with pointers). It is
> just Windows where we use the two systems in one.
And I quote (from a file in my ~/.subversion/auth/svn
On 04/03/2013 03:14 PM, Bert Huijben wrote:
> I can’t really see it using just the context in this patch, but doesn’t this
> undo the don’t parse if no hook script exists patch from Ivan?
Yes, it does. Bummer. I missed that.
Not sure how to proceed then, unless we just revert my change and retu
> -Original Message-
> From: C. Michael Pilato [mailto:cmpil...@collab.net]
> Sent: woensdag 3 april 2013 21:37
> To: Subversion Development
> Cc: Bert Huijben
> Subject: Remove svn_auth_cleanup_walk()?
>
> While reviewing new-to-1.8 APIs, I found myself rather confused by
> svn_auth_cle
On Wed, Apr 3, 2013 at 9:10 PM, Mark Phippard wrote:
> On Wed, Apr 3, 2013 at 12:15 PM, wrote:
>>
>> +(danielsh adds: if we do this, would be nice to have 'svnadmin info' command
>> +that prints the equivalent of `cat fs-type uuid ../format ../db/format`; but
>> +that's orthogonal to all backend
While reviewing new-to-1.8 APIs, I found myself rather confused by
svn_auth_cleanup_walk(). It took me a bit to understand the approach, and
ultimately I realize that this was because the function and its plumbing
seemed to conflate the idea of the "simple" auth credential type with our
on-disk, p
cmpil...@apache.org wrote on Wed, Apr 03, 2013 at 17:51:56 -:
> Author: cmpilato
> Date: Wed Apr 3 17:51:56 2013
> New Revision: 1464122
>
> URL: http://svn.apache.org/r1464122
> Log:
> Avoid parsing the hooks-env file multiple times for closely-knit hook
> invocations, specifically the pre-/
On Wed, Apr 3, 2013 at 1:15 PM, Daniel Shahaf wrote:
> Mark Phippard wrote on Wed, Apr 03, 2013 at 13:10:54 -0400:
>> On Wed, Apr 3, 2013 at 12:15 PM, wrote:
>> >
>> > +(danielsh adds: if we do this, would be nice to have 'svnadmin info'
>> > command
>> > +that prints the equivalent of `cat fs-t
Mark Phippard wrote on Wed, Apr 03, 2013 at 13:10:54 -0400:
> On Wed, Apr 3, 2013 at 12:15 PM, wrote:
> >
> > +(danielsh adds: if we do this, would be nice to have 'svnadmin info'
> > command
> > +that prints the equivalent of `cat fs-type uuid ../format ../db/format`;
> > but
> > +that's orthog
On Wed, Apr 3, 2013 at 12:15 PM, wrote:
>
> +(danielsh adds: if we do this, would be nice to have 'svnadmin info' command
> +that prints the equivalent of `cat fs-type uuid ../format ../db/format`; but
> +that's orthogonal to all backend changes.)
>
I think having an svnadmin info command would b
On Fri, Mar 22, 2013 at 2:39 PM, Julian Foad wrote:
> Paul Burba wrote:
>
>> On Fri, Mar 8, 2013 at 4:17 PM, Paul Burba wrote:
>>> On Tue, Mar 5, 2013 at 11:37 AM, Julian Foad wrote:
So, what to do exactly? Options seem to be:
0) leave it as it is
1) detect this
On 04/03/2013 10:25 AM, Stefan Sperling wrote:
> Well, the argument goes like this:
>
> Subversion cannot handle \n in filenames at many levels.
>
> It was found that the FSFS layer cannot handle it without repository
> corruption, and it was pointed out that e.g. the unidiff format and the
> Sub
On Wed, Apr 03, 2013 at 09:51:38AM -0400, C. Michael Pilato wrote:
> On 04/03/2013 07:04 AM, Stefan Sperling wrote:
> > - prevent control characters from entering filenames at the repos layer
>
> +0 (It's a bit overly conservative, probably, but at this layer of the API
> I'm less grumpy about t
On 04/03/2013 07:04 AM, Stefan Sperling wrote:
> To refresh our collective memory, the current trunk code does:
> - prevent newlines from entering filenames at the fsfs layer
+1
> - prevent control characters from entering filenames at the repos layer
+0 (It's a bit overly conservative, proba
Branko Čibej writes:
> On 03.04.2013 13:21, phi...@apache.org wrote:
>> Author: philip
>> Date: Wed Apr 3 11:21:29 2013
>> New Revision: 1463922
>>
>> URL: http://svn.apache.org/r1463922
>> Log:
>> * subversion/libsvn_repos/hooks.c (parse_hooks_env): Remove unused variable.
>>
>> Modified:
>>
On Tue, Apr 02, 2013 at 05:18:46PM -0400, C. Michael Pilato wrote:
> I confess I'm a bit confused by the early parts of the test changes, which
> appear to be more about testing the 'random' module and less about testing
> Subversion.
Hi Shivani,
please allow me to divert this discussion away fro
Stefan Sperling wrote on Wed, Apr 03, 2013 at 13:12:12 +0200:
> On Wed, Apr 03, 2013 at 02:58:56PM +0400, Ivan Zhakov wrote:
> > On Wed, Apr 3, 2013 at 2:56 PM, Stefan Sperling wrote:
> > > On Wed, Apr 03, 2013 at 02:03:32PM +0400, Ivan Zhakov wrote:
> > >> I'm still not happy with svn_repos_hooks
Branko Čibej writes:
> I thihk there has to be a way to say all of the following:
>
> 1. do not use a hooks-env file at all
> 2. use the default hooks-env file
> 3. use a specific, non-default hooks-env file
Do we need option 2, the default path?
The hooks-env path is specified in apache con
Stefan Sperling wrote on Wed, Apr 03, 2013 at 13:04:43 +0200:
> To refresh our collective memory, the current trunk code does:
> - prevent newlines from entering filenames at the fsfs layer
+1
> - prevent control characters from entering filenames at the repos layer
+0
On 03.04.2013 13:01, Philip Martin wrote:
> Ivan Zhakov writes:
>
>> On Wed, Apr 3, 2013 at 4:38 AM, Ben Reser wrote:
>>> I've gone ahead and moved the default hooks-env to hooks-env.tmpl.
>>> We'll still try to open the file but we won't bother to read it in or
>>> parse a completely commented o
Stefan Sperling writes:
> On Wed, Apr 03, 2013 at 02:58:56PM +0400, Ivan Zhakov wrote:
>> I think result_pool parameter should be replaced with pool member in
>> svn_repos_t structure.
>
> Or, as Philip suggested, we could replace the svn_repos_hooks_setenv()
> function with a new 'hooks_env_path
On Wed, Apr 03, 2013 at 02:58:56PM +0400, Ivan Zhakov wrote:
> On Wed, Apr 3, 2013 at 2:56 PM, Stefan Sperling wrote:
> > On Wed, Apr 03, 2013 at 02:03:32PM +0400, Ivan Zhakov wrote:
> >> I'm still not happy with svn_repos_hooks_setenv() API, but this is
> >> separate issue.
> >
> > Why aren't you
On Wed, Mar 27, 2013 at 07:19:07PM +0100, Stefan Sperling wrote:
> So I've implemented this proposal in r1461701 and r1461760, and now
> we have code for both approaches in our repository history.
> I'll let everyone else discuss which approach is better and then
> do whatever needs to be done to g
Ivan Zhakov writes:
> On Wed, Apr 3, 2013 at 4:38 AM, Ben Reser wrote:
>> I've gone ahead and moved the default hooks-env to hooks-env.tmpl.
>> We'll still try to open the file but we won't bother to read it in or
>> parse a completely commented out file unless the user puts a file in
>> place.
On Wed, Apr 3, 2013 at 2:56 PM, Stefan Sperling wrote:
> On Wed, Apr 03, 2013 at 02:03:32PM +0400, Ivan Zhakov wrote:
>> I'm still not happy with svn_repos_hooks_setenv() API, but this is
>> separate issue.
>
> Why aren't you happy with it?
>
> It's a new API that has to be called in order to acti
On Wed, Apr 03, 2013 at 02:03:32PM +0400, Ivan Zhakov wrote:
> I'm still not happy with svn_repos_hooks_setenv() API, but this is
> separate issue.
Why aren't you happy with it?
It's a new API that has to be called in order to activate the hooks-env
feature. Server-side tools written against 1.7
On Wed, Apr 3, 2013 at 12:17 AM, Julian Foad wrote:
> Hi Stefan.
>
> In , you wrote:
> [[[
> Merge third batch of changes from the 10Gb branch.
> Switch ra_svn to templated commands.
>
> Revisions 1388276,1390209
> ]]]
>
> I assume the main reason for this change is to remove the run-time
> overhe
On Wed, Apr 3, 2013 at 1:48 PM, Ivan Zhakov wrote:
> On Wed, Apr 3, 2013 at 4:38 AM, Ben Reser wrote:
>> I've gone ahead and moved the default hooks-env to hooks-env.tmpl.
>> We'll still try to open the file but we won't bother to read it in or
>> parse a completely commented out file unless the
On Wed, Apr 3, 2013 at 4:38 AM, Ben Reser wrote:
> I've gone ahead and moved the default hooks-env to hooks-env.tmpl.
> We'll still try to open the file but we won't bother to read it in or
> parse a completely commented out file unless the user puts a file in
> place. The .tmpl is a common patte
On Fri, Mar 29, 2013 at 8:41 AM, Ben Reser wrote:
> The 1.7.9 release artifacts are now available for testing/signing.
> Please get the tarballs from
> https://dist.apache.org/repos/dist/dev/subversion
> and add your signatures there. I plan to try and release on April
> 4th so please try and g
40 matches
Mail list logo
