On Wed, Apr 03, 2013 at 02:58:56PM +0400, Ivan Zhakov wrote: > On Wed, Apr 3, 2013 at 2:56 PM, Stefan Sperling <s...@elego.de> wrote: > > On Wed, Apr 03, 2013 at 02:03:32PM +0400, Ivan Zhakov wrote: > >> I'm still not happy with svn_repos_hooks_setenv() API, but this is > >> separate issue. > > > > Why aren't you happy with it? > > > > It's a new API that has to be called in order to activate the hooks-env > > feature. Server-side tools written against 1.7 and earlier repos APIs > > should not see a behaviour change when using 1.8 libs at runtime. > I think result_pool parameter should be replaced with pool member in > svn_repos_t structure.
Or, as Philip suggested, we could replace the svn_repos_hooks_setenv() function with a new 'hooks_env_path' parameter to svn_repos_open(). > Also it's not possible to deactivate hooks-env feature using > svn_repos_hooks_setenv() because NULL path considered as 'use default > path'. Why would you want to deactivate this feature via the API? Just don't put a hooks-env configuration file into the repository, and don't specify a hooks-env path in the server configuration. Isn't that good enough? Note that the default path exists for ra_local, since there is no good way of passing a config file path to the repos layer when ra_local is used. Using an environment variable to store the hooks-env path was discussed, but I don't like this approach since it doesn't scale well to additional configuration files we might introduce in future releases.
