On Wed, Mar 27, 2013 at 07:19:07PM +0100, Stefan Sperling wrote: > So I've implemented this proposal in r1461701 and r1461760, and now > we have code for both approaches in our repository history. > I'll let everyone else discuss which approach is better and then > do whatever needs to be done to get a fix shipped.
So it seems this discussion has petered out, so no consensus was found. Can we please come to an agreement? Which approach should be used? If I don't hear anything I'll prepare a backport of the current trunk code for 1.7.x and 1.6.x (since this is a data corruption bug). But I don't want to spend extra time on nominating things that will end up being reverted, so I'll ask again: Is the current trunk code good enough for everyone? To refresh our collective memory, the current trunk code does: - prevent newlines from entering filenames at the fsfs layer - prevent control characters from entering filenames at the repos layer
