On Tue, Dec 11, 2012 at 3:14 PM, C. Michael Pilato wrote:
> We should probably link to the "Coding Conventions" section from the "Patch
> submission guidelines" section just to be thorough.
Done in r1420516.
On Tue, Dec 11, 2012 at 6:02 PM, Daniel Shahaf wrote:
> We have code on the client side that removes \r from the log message
> supplied by the user. (I don't really remember whether that is in 'svn' (the
> cmdline client) or in libsvn_client.)
That would be the svn_subst_translate_string2() call
Gabriela Gibson wrote on Wed, Dec 12, 2012 at 00:50:41 +:
> On 11/12/12 00:46, Daniel Shahaf wrote:
>
>
> >
> > subversion/svnrdump/svnrdump.c:554: (apr_err=125005)
> > subversion/libsvn_repos/load.c:583: (apr_err=125005)
> > subversion/libsvn_repos/load.c:260: (apr_err=125005)
> > subversion/
On Wed, Dec 12, 2012 at 04:02:01AM +0200, Daniel Shahaf wrote:
> Ben Reser wrote on Tue, Dec 11, 2012 at 17:59:47 -0800:
> > Your \r at the end of a line being deleted is in a log message. I
> > suspect we have some code someplace that removes trailing new lines
> > from svn:log. But I haven't du
Ben Reser wrote on Tue, Dec 11, 2012 at 17:59:47 -0800:
> Your \r at the end of a line being deleted is in a log message. I
> suspect we have some code someplace that removes trailing new lines
> from svn:log. But I haven't dug too far on that.
We have code on the client side that removes \r fro
On Tue, Dec 11, 2012 at 5:16 PM, Gabriela Gibson
wrote:
> The differences between copy-bad-line-endings.expected.dump and
> copy-bad-line-endings.dump appear to be:
>
> 1. '\r' in the middle of a line is replaced by '\n'.
> 2. '\r' at the end of a line is deleted.
>
> Let's call this "option 1".
Gabriela Gibson wrote on Wed, Dec 12, 2012 at 01:16:34 +:
> The differences between copy-bad-line-endings.expected.dump and
> copy-bad-line-endings.dump appear to be:
>
> 1. '\r' in the middle of a line is replaced by '\n'.
> 2. '\r' at the end of a line is deleted.
>
Actually what happens i
Ben Reser wrote on Tue, Dec 11, 2012 at 17:44:59 -0800:
> I tracked that down by looking at the issue that's referenced in the
> issue you're looking at, which then says it is fixed in r37795. When
> we migrated from tigris.org to apache.org for our repo hosting our
> revision numbers changed. Fo
On Tue, Dec 11, 2012 at 4:50 PM, Gabriela Gibson
wrote:
> I'm concerned that I shouldn't be altering fs-wrap.c. So a logical
> place to put a fix is probably in (set_revision_property).
>
> I could either hand code a "for" loop, or call the function
> (svn_rdump__normalize_props) in svnrdump/util
On 11/12/12 23:01, Daniel Shahaf wrote:
> Gabriela Gibson wrote on Tue, Dec 11, 2012 at 22:18:54 +:
>> On 11/12/12 00:46, Daniel Shahaf wrote:
>>
>>
>> I will attempt to do just this. Also your tip with the libtool was
>> much appreciated, thank you very much :)
>>
>
> Welcome.
>
>> Index: su
On 11/12/12 00:46, Daniel Shahaf wrote:
>
> subversion/svnrdump/svnrdump.c:554: (apr_err=125005)
> subversion/libsvn_repos/load.c:583: (apr_err=125005)
> subversion/libsvn_repos/load.c:260: (apr_err=125005)
> subversion/svnrdump/load_editor.c:858: (apr_err=125005)
> subversion/libsvn_repos/fs-wr
On 12/11/2012 06:01 PM, Daniel Shahaf wrote:
> Gabriela Gibson wrote on Tue, Dec 11, 2012 at 22:18:54 +:
>> On 11/12/12 00:46, Daniel Shahaf wrote:
>>
>>> Need parentheses around the symbol name. Lines should be wrapped at 80
>>> characters and subsequent lines indented.
>>
>> The web page ins
Gabriela Gibson wrote on Tue, Dec 11, 2012 at 22:18:54 +:
> On 11/12/12 00:46, Daniel Shahaf wrote:
>
>> Need parentheses around the symbol name. Lines should be wrapped at 80
>> characters and subsequent lines indented.
>
> The web page instructions[1] need updating because they doesn't menti
I cannot build/test this right now but both patch and log message
look great to me. Thanks!
On Tue, Dec 11, 2012 at 10:18:54PM +, Gabriela Gibson wrote:
> Index: subversion/tests/cmdline/svnrdump_tests.py
> ===
> --- subversion/te
On 11/12/12 00:46, Daniel Shahaf wrote:
Need parentheses around the symbol name. Lines should be wrapped at 80
characters and subsequent lines indented.
The web page instructions[1] need updating because they doesn't mention
this and so, I was trying to stay under a 72 character limit for th
> Author: philip
>
> URL: http://svn.apache.org/viewvc?rev=1420404&view=rev
> Log:
> * subversion/libsvn_wc/token-map.h
> (depth_map): Add some annotations.
>
> * subversion/libsvn_wc/wc-queries.sql
> (STMT_HAS_SPARSE_NODES): Use annotations.
> Modified: subversion/trunk/subversion/libsvn_w
On 12/10/2012 10:53 AM, C. Michael Pilato wrote:
> What if we revved the svn_ra_replay_range() API in such a way that it could
> now handle this "initial revision" scenario? We might add an 'incremental'
> flag that parallels what 'svnadmin dump' and 'svnrdump dump' do. This would
> get us to a s
Shivani Poddar wrote on Wed, Dec 12, 2012 at 00:50:03 +0530:
> On Wed, Dec 12, 2012 at 12:40 AM, Daniel Shahaf wrote:
>
> > Yeah, you're right. Ultimately that's because svn_checksum_size takes
> > a checksum rather than a checksum kind.
> >
> > What should we do then?
> >
> > - revv svn_checksu
On Wed, Dec 12, 2012 at 12:40 AM, Daniel Shahaf wrote:
> Yeah, you're right. Ultimately that's because svn_checksum_size takes
> a checksum rather than a checksum kind.
>
> What should we do then?
>
> - revv svn_checksum_size to take an svn_checksum_kind_t?
>
Does this line mean something like:
Yeah, you're right. Ultimately that's because svn_checksum_size takes
a checksum rather than a checksum kind.
What should we do then?
- revv svn_checksum_size to take an svn_checksum_kind_t?
- svn.core.APR_MD5_DIGESTSIZE? svn.core doesn't export that symbol.
- len(hashlib.md5().hexdigest()) ?
> > +LENGTH =
> > svn.core.svn_checksum_size(svn.core.svn_checksum_create(svn.core.svn_checksum_md5))
> > +self.assertEqual(len(check_val)%LENGTH,0,"Length of digest does
> > not match kind")
Is there a better way to get the expected length?
svn.core.svn_checksum_create(svn.core.svn_ch
On Wed, Dec 12, 2012 at 12:02 AM, Daniel Shahaf wrote:
> Shivani Poddar wrote on Tue, Dec 11, 2012 at 23:49:56 +0530:
> > Log Message:
> >
> > Improve support for svn_checksum.h in SWIG bindings
> > * subversion/bindings/swig/python/tests/checksum.py: Improved
> test_checksum
>
> You haven't fixe
Shivani Poddar wrote on Tue, Dec 11, 2012 at 23:49:56 +0530:
> Log Message:
>
> Improve support for svn_checksum.h in SWIG bindings
> * subversion/bindings/swig/python/tests/checksum.py: Improved test_checksum
You haven't fixed the log message as per my original review.
> Index: subversion/bindi
Log Message:
Improve support for svn_checksum.h in SWIG bindings
* subversion/bindings/swig/python/tests/checksum.py: Improved test_checksum
Modified:
subversion/trunk/subversion/bindings/swig/python/tests/checksum.py
On Tue, Dec 11, 2012 at 11:05 PM, Daniel Shahaf wrote:
> Shivani Poddar wro
Shivani Poddar wrote on Tue, Dec 11, 2012 at 22:54:58 +0530:
> I did use the assert functions on the same line but i did understand the
> earlier concerns cited that although they compiled they werent the exact
Ben was not referring to unittest.assertRaises() but to other
unittest.assertFoo() func
On Tue, Dec 11, 2012 at 10:48 PM, Ben Reser wrote:
> On Tue, Dec 11, 2012 at 3:18 AM, Shivani Poddar
> wrote:
> >
> > Log Message:
> >
> > Improve support for svn_checksum.h in SWIG bindings
> > * subversion/bindings/swig/python/tests/checksum.py: Improved
> test_checksum
> >
> >
> > Modified:
>
On Tue, Dec 11, 2012 at 3:18 AM, Shivani Poddar
wrote:
>
> Log Message:
>
> Improve support for svn_checksum.h in SWIG bindings
> * subversion/bindings/swig/python/tests/checksum.py: Improved test_checksum
>
>
> Modified:
> subversion/trunk/subversion/bindings/swig/python/tests/checksum.py
This d
[Philip Martin]
> I assume WANdisco's package is intended to replace the libraries in the
> standard Debian or Ubuntu libsvn1 package, in which case you need to use
> the same patch. If you ship -1.so.0 libraries then applications linked
> to the -1.so.1 libraries will fail to start.
Well, they'
Philip Martin wrote:
> Gabriela Gibson writes:
>> BTW, I noticed that the python tests in subversion/tests/cmdline/
>> don't support a "list" parameter as suggested in
>> subversion/tests/README. Is there a reason for this? Otherwise, this
>> might something I could fix.
>
> Out-of-date do
Philip Herron writes:
> Looks cool, been building alot of packages only thing i noticed is the
> libraries are re-named from
>
> debian/tmp/usr/lib/libsvn_ra*.so.1* usr/lib
> debian/tmp/usr/lib/libsvn_fs*.so.1* usr/lib
> debian/tmp/usr/lib/libsvn_wc-1.so.1*usr/
On 11/12/12 03:03, Paul Burba wrote:
> On Mon, Dec 10, 2012 at 5:07 PM, Ben Reser wrote:
>> The 1.7.8 release artifacts are now available for testing/signing.
>> Please get the tarballs from
>> https://dist.apache.org/repos/dist/dev/subversion
>> and add your signatures there.
>>
>> Thanks!
>
>
Log Message:
Improve support for svn_checksum.h in SWIG bindings
* subversion/bindings/swig/python/tests/checksum.py: Improved test_checksum
Modified:
subversion/trunk/subversion/bindings/swig/python/tests/checksum.py
Regards,
Shivani Poddar
Bachelors in Computer Sciences and MS in Exact H
On Tue, Dec 11, 2012 at 2:17 PM, Daniel Shahaf wrote:
> Shivani Poddar wrote on Tue, Dec 11, 2012 at 11:51:19 +0530:
> > On Tue, Dec 11, 2012 at 4:08 AM, Daniel Shahaf
> wrote:
> > > Shivani Poddar wrote on Tue, Dec 11, 2012 at 02:22:28 +0530:
> > > > Index: subversion/bindings/swig/python/tests
Philip Martin writes:
> I see no reason why we should not introduce a depth map and use
> svn_sqlite__column_token instead.
For both 1.7 and 1.8 an excluded file has null depth:
$ rm -rf wc && svn co file://`pwd`/repo wc
$ svn up --set-depth exclude wc/A/f
$ sqlite3 -nullvalue - wc/.svn/wc.db "
Philip Martin writes:
> Daniel Shahaf writes:
>
>> Philip Martin wrote on Mon, Dec 10, 2012 at 17:49:44 +:
>>> Daniel Shahaf writes:
>>>
>>> > Philip - perhaps you can move the relevant definitions to that header?
>>> > Then I'll follow up with a transform_sql.py patch.
>>>
>>> OK, I've d
Daniel Shahaf writes:
> Philip Martin wrote on Mon, Dec 10, 2012 at 17:49:44 +:
>> Daniel Shahaf writes:
>>
>> > Philip - perhaps you can move the relevant definitions to that header?
>> > Then I'll follow up with a transform_sql.py patch.
>>
>> OK, I've done that. I didn't annotate the m
Gabriela Gibson writes:
> BTW, I noticed that the python tests in subversion/tests/cmdline/
> don't support a "list" parameter as suggested in
> subversion/tests/README. Is there a reason for this? Otherwise, this
> might something I could fix.
Out-of-date documentation. They do support --list
Shivani Poddar wrote on Tue, Dec 11, 2012 at 11:51:19 +0530:
> On Tue, Dec 11, 2012 at 4:08 AM, Daniel Shahaf wrote:
> > Shivani Poddar wrote on Tue, Dec 11, 2012 at 02:22:28 +0530:
> > > Index: subversion/bindings/swig/python/tests/checksum.py
> > > ===
38 matches
Mail list logo
