On Tue, Dec 11, 2012 at 5:16 PM, Gabriela Gibson <gabriela.gib...@gmail.com> wrote: > The differences between copy-bad-line-endings.expected.dump and > copy-bad-line-endings.dump appear to be: > > 1. '\r' in the middle of a line is replaced by '\n'. > 2. '\r' at the end of a line is deleted. > > Let's call this "option 1". > > I had in mind to replace '\r' with '<space>'. > This would be option 2. > > Which is the prefered option?
I'd say that replacing '\r' with a '<space>' is wrong. That would change the meaning of some properties. E.G. svn:ignore, svn:externals which use lines to handle individual records within them. Your \r at the end of a line being deleted is in a log message. I suspect we have some code someplace that removes trailing new lines from svn:log. But I haven't dug too far on that.
